magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	6a97fa2fed	MeshTools: drop now-obsolete special case for attrib-less meshes. It was incomplete, asserting in some cases anyway.	6 years ago
Vladimír Vondruš	101e8fd11b	MeshTools: isInterleaved() and interleavedData() work with custom formats. The interleavedLayout() etc don't yet (those need to explicitly assert), added a TODO there.	6 years ago
Vladimír Vondruš	1f070cf77d	MeshTools: reduce code duplication in interleavedData() internals.	6 years ago
Vladimír Vondruš	add3eb4b55	MeshTools: MSVC 2015, thanks for being shitty.	6 years ago
Vladimír Vondruš	55ee67c5ca	MeshTools: fix build on old Clang.	6 years ago
Vladimír Vondruš	c3082ac355	MeshTools: expand coverage exclude marker over all affected lines.	6 years ago
Vladimír Vondruš	d843dc2e31	sceneconverter: no, it's not anymore.	6 years ago
Vladimír Vondruš	51ae59ddc1	Primitives: use non-fuzzy duplicate removal in icosphere. Now that it actually works properly, it ... works properly.	6 years ago
Vladimír Vondruš	a91aa47a02	sceneconverter: add --remove-duplicates-fuzzy.	6 years ago
Vladimír Vondruš	145e055b41	MeshTools: implement removeDuplicatesFuzzy() for MeshData.	6 years ago
Vladimír Vondruš	ab7c1b14d4	MeshTools: save memory and speed up removeDuplicates() by storing size once. I also tried storing only a 32-bit index and have the base pointer stored in ArrayEqual/ArrayHash also, but that didn't really improve amything much (probably because the allocated items are 8-byte aligned anyway) and only made the code a lot less clear.	6 years ago
Vladimír Vondruš	a362657dc6	MeshTools: fix removeDuplicates() to not mutate map keys. Now it works reliably. It's (again) slower than the previous variant, I'll try some ideas next.	6 years ago
Vladimír Vondruš	d06b789673	MeshTools: put subdivide / removeDuplicates benchamrks into their tests. One less executable to build, and we need to test more variants. The original measured thing ("when to remove duplicates") is no longer really relevant. Interestingly enough the fuzzy variant isn't that much slower.	6 years ago
Vladimír Vondruš	fcd329ba55	MeshTools: add a soak test for removeDuplicates[Fuzzy]InPlace(). Something fishy going on in there, caused by the algorithm overwriting the key values (and the map relying on them being immutable). Interestingly enough the fuzzy variants works on GCC's libstdc++ even though the key data get changed every entry, fails only on libc++.	6 years ago
Vladimír Vondruš	31960290d5	MeshTools: add a comment to the test. So I don't spend ages searching for where the heck are the other overloads tested, if at all.	6 years ago
Vladimír Vondruš	d846944b7a	MeshTools: de-template removeDuplicatesFuzzy(). Basically using the same idea as with the discrete version -- having the second dimension dynamic, together with restricting the implementation to just Float and Double. According to the SubdivideRemoveDuplicatesBenchmark, this makes the implementation slightly slower. I presume this is due to how minmax and offsets are calculated which is quite cache-inefficient as it goes over the same memory block multiple times. Added a TODO for later.	6 years ago
Vladimír Vondruš	5e7f562dda	MeshTools: use floats for removeDuplicatesFuzzy() tests. Because it makes no sense to use ints for this, and I'll be removing the template to make it work only on floating-point types anyway.	6 years ago
Vladimír Vondruš	1cc2564c53	MeshTools: properly reduce unique prefix in the last iteration. The test passes now.	6 years ago
Vladimír Vondruš	7a72cb06e4	MeshTools: test reducing of last dimension in removeDuplicatesFuzzy(). I spotted a potential bug -- and it clearly is a bug. The test doesn't reduce the data size in the last dimension, leaving a duplicate (and unused) item at the end.	6 years ago
Vladimír Vondruš	70e5606afe	MeshTools: add removeDuplicatesFuzzyInPlaceInto(). I need a variant of removeDuplicatesFuzzyInPlace() that doesn't allocate the output array but instead puts the data into a pre-existing location. The discrete / non-fuzzy variant had this already, but this one not.	6 years ago
Vladimír Vondruš	6f2e4c2981	MeshTools: fix Clang warning about implicit cast changing a value. Magnum/MeshTools/RemoveDuplicates.h:373:30: Requested here: Implicit conversion from 'std::size_t' (aka 'unsigned long') to 'float' changes value from 18446744073709551615 to 18446744073709551616 [-Wimplicit-int-float-conversion]. Not that it would really matter at this scale, but thanks anyway.	6 years ago
Vladimír Vondruš	9474b3e3fc	MeshTools: rename removeDuplicates{ => Fuzzy}[Indexed]InPlace(). A breaking change, sorry, but I don't want to add yet another layer of backwards compatibility on APIs that are in master for just a month or so. This is a test for how many people actually use these APIs -- if nobody complains, great! Conflating the fuzzy operation with the discrete one wasn't a good idea, as people could be unintentionally using the (slower) fuzzy variant on data that could be easily deduplicated using the discrete variant. One such case is in the icosphere primitive, and I'm going to look at that right now.	6 years ago
Vladimír Vondruš	add966e0bd	sceneconverter: add a --remove-duplicates option.	6 years ago
Vladimír Vondruš	7138a53b49	MeshTools: add removeDuplicates() operating directly on MeshData.	6 years ago
Vladimír Vondruš	cee4840b86	DebugTools: fix build on libc++ 10.	6 years ago
Vladimír Vondruš	51e699f0ea	MeshTools: avoid needless zero-initialization.	6 years ago
Vladimír Vondruš	f5822e9384	Trade: properly include array size in attribute stride checks.	6 years ago
Vladimír Vondruš	9742b84815	MeshTools: properly handle array attributes everywhere. Now the tests pass again.	6 years ago
Vladimír Vondruš	753f5afaeb	MeshTools: verify that array attributes are handled correctly everywhere. Nowhere, actually. HAH.	6 years ago
Vladimír Vondruš	dca9dc492d	Trade: fix ambiguity when instantiating nullptr array MeshAttributeData.	6 years ago
Vladimír Vondruš	36a3556c68	MeshTools: document a non-obvious usage for combineIndexedAttributes().	6 years ago
Vladimír Vondruš	521a3dac0b	Trade: make creation of non-owning MeshData references easier. While `27f6cc309d` made it easier to create references to attribute-less meshes by avoiding a branch on attributeCount() (and then using a constructor with explicit vertex count), code still had to branch on isIndexed() because indices() could be called only on indexed meshes. This change allows code like Trade::MeshData reference{data.primitive(), {}, data.indexData(), Trade::MeshIndexData{data.indices()}, {}, data.vertexData(), Trade::meshAttributeDataNonOwningArray(data.attributeData()), data.vertexCount()}; which works correctly for all cases and doesn't introduce extra branches and code paths that would need to be tested. While definitely better, I might still give up at some point and introduce some Trade::MeshData::nonOwningImmutableReference() helper for this.	6 years ago
Vladimír Vondruš	f8f73d2cbb	sceneconverter: print also reference count for each mesh.	6 years ago
Vladimír Vondruš	5be7fbe1e8	Math: make Range2D and Range3D properly convertible from std::pair. Not sure what was I doing in `64f8a90095`.	6 years ago
Vladimír Vondruš	6053cc6fc6	MeshTools: this goes first, usually.	6 years ago
Vladimír Vondruš	dec7904db1	MeshTools: removeDuplicatesIndexedInPlace() for type-erased indices. Next step is a variant operating directly on a MeshData.	6 years ago
Vladimír Vondruš	7205bcf28c	MeshTools: this actually didn't test the erased version at all. The heck was I doing when implementing these.	6 years ago
Vladimír Vondruš	b180dd7bf0	MeshTools: various cleanup.	6 years ago
Vladimír Vondruš	e9a574f948	MeshTools: why am I discovering all those weird things today.	6 years ago
Vladimír Vondruš	a6302ac7d3	MeshTools: test asserts in type-erased flipFaceWinding().	6 years ago
Vladimír Vondruš	766b03fc38	Animation: add TrackViewStorage::values().	6 years ago
Vladimír Vondruš	cda8504b08	Animation: hmm, this isn't right.	6 years ago
Vladimír Vondruš	f3c2bfb093	Animation: why not just cast the thing? The reinterpret is kinda dangerous, and causes strict aliasing warnings.	6 years ago
Vladimír Vondruš	f269a1baa8	Vk: forgotten leftovers from the depths of MeshData renaming.	6 years ago
Vladimír Vondruš	749ae985b1	sceneconverter: support chaining converters.	6 years ago
Vladimír Vondruš	7100e3b6d8	Revert "Platform: choose a GLXFBConfig with a pbuffer." Caused an error when creating a WindowlessGlxApplication on a Mesa with just llvmpipe. Note to self: never again try to fix anything related to Xlib that's not broken. This reverts commit `511d0c1b27`.	6 years ago
Vladimír Vondruš	9d104a7e88	Shaders: document how to propagate generic attribs to shader code.	6 years ago
Vladimír Vondruš	fb32dd4c0e	imageconverter,sceneconverter: support option subgroups as well.	6 years ago
Vladimír Vondruš	0da8f89055	sceneconverter: hook scene converter plugins into this thing.	6 years ago
Vladimír Vondruš	08a51215b6	sceneconverter: add a --profile option.	6 years ago

1 2 3 4 5 ...

3637 Commits (6a97fa2fed8a952725021e82bfb0fb65d0739593)