magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	6cbc37ecda	AnyImageImporter: don't abuse file callbacks to test data opening. It doesn't make the test any simpler, easier to understand or less error prone, on the contrary. And it would stop testing the intended code path once file callbacks are implemented inside the importer.	4 years ago
Vladimír Vondruš	822fa0d644	Updated copyright year.	4 years ago
Vladimír Vondruš	578baf3168	Any{Image,Scene}{Importer,Converter}: improve plugin checks in tests. These checks covered the case when the magnum-plugins repository wasn't installed, but didn't cover the case when it was installed but the plugins were built against an outdated interface, had ABI issues, or didn't load at all for various other reasons.	4 years ago
Vladimír Vondruš	4d14d91d5d	AnyImageConverter: Basis now supports also 3D (2D array) image export.	4 years ago
Vladimír Vondruš	150435ee62	CMake: prefer -pthread over -lpthread. CMake ewhy can't you have this as a default?	4 years ago
Vladimír Vondruš	6ba8695668	AnyImageConverter: whoops, again didn't test the correct path here. Good thing the coverage reports exist.	4 years ago
Vladimír Vondruš	9fbc637f76	AnyImageConverter: recognize KTX2 for basically all image types.	4 years ago
Vladimír Vondruš	fe8681d53a	AnyImageConverter: minor cleanup in the test.	4 years ago
Vladimír Vondruš	8d03168918	AnyImageConverter: BasisImageConverter now has multi-level export also.	4 years ago
Vladimír Vondruš	1f33071b3c	AnyImageConverter: support KTX2 also in 3D and 2D/3D levels code paths. And prefere to use it onver OpenEXR in most AnyImage{Converter,Importer} tests, unless the test really needs something that only OpenEXR has (such as the verbose output for threads or configuration that needs to be set on both export and import to make the import succeed).	4 years ago
Vladimír Vondruš	d2e3d6d82f	AnyImageConverter: why would I want them, anyway.	4 years ago
Vladimír Vondruš	208da2bc0d	AnyImageConverter: whoops, accidentally not testing anything here.	4 years ago
Vladimír Vondruš	4418bec270	Trade: bump AbstractImporter interface version. With the previous commits, existing plugin implementations built and ran against the new code, however it introduced several ABI breaks meaning that existing plugin binaries would crash. This forces them to be recompiled to match the new version string.	4 years ago
Vladimír Vondruš	b9cb395d75	AnySceneImporter: adapt to SceneData redesign.	4 years ago
Vladimír Vondruš	27044a4fef	Trade: ability to open non-temporary memory. Using openMemory() instead of openData() allows the implementation to assume the data will stay in scope for as long as needed, which can prevent unnecessary copies in some plugin implementations. It warranted a new flag, DataFlag::ExternallyOwned, to describe this kind of memory. I couldn't reuse Owned as that's used for allocations owned by the instance, which is too little for certain future use cases. For example returning *Data instances referencing an Owned memory would mean the user has to assume the memory is gone when the importer instance is gone, and that's generally not true for memory passed to openMemory(). Originally I thought I would do this later, but then realized the existing plugin implementations would need to get all updated again to be aware of the new flag, with some being forgotten, and it's just easier to do the whole thing in a single step.	5 years ago
Vladimír Vondruš	e871cabfa6	Adapt plugins to the AbstractImporter interface change.	5 years ago
Vladimír Vondruš	b7335e9264	ObjImporter: test double opening and double import. Like with all other plugins.	5 years ago
Vladimír Vondruš	d1c91b105c	TgaImporter: minor verbosity cleanup in the test.	5 years ago
Vladimír Vondruš	d91203df2f	TgaImporter: wait, what the hell, why this ancient cursed code? Also use a NoInit'd array, to avoid an useless zero-init.	5 years ago
Vladimír Vondruš	cad1f68eba	doc: mention new KTX and glTF plugins.	5 years ago
Vladimír Vondruš	f989630a09	AnyImageImporter: test 3D image loading code path. Using the fresh new OpenExrImporter cubemap support.	5 years ago
Vladimír Vondruš	3e8627e688	AnyImageImporter: test detection of Basis file data as well. Hnngh, why did I have the file there at all, then?	5 years ago
Vladimír Vondruš	a130f26797	AnyImageConverter: add conversion of 3D and multi-level 2D/3D images. Now that OpenExrImageConverter has cubemap and multi-level support we can finally add and test these code paths.	5 years ago
Vladimír Vondruš	a3faf8e7e1	AnyImageConverter: minor cleanup in a test.	5 years ago
Vladimír Vondruš	8ec056bcc9	AnyImageConverter: there's no point in having this test instanced.	5 years ago
Vladimír Vondruš	3265f428fb	AnyImageConverter: uppercase variables? nooo	5 years ago
Vladimír Vondruš	eea9d32959	Trade: tighten AbstractImageConverter input requirements. The multi-level APIs still don't check anything regarding level sizes and order since for example *.ico has no restrictions at all. But the rest (like non-zero size) is a restriction for all file formats I'm aware of. TgaImageConverter test had to be adapted, I expect a lot of breakages in plugins tests as well. But user code should be fine I think. Also reduced the rather excessive dimensions in AbstractImageConverterTest, since the allocation requirement now made the default Emscripten heap OOM.	5 years ago
Vladimír Vondruš	df0b085cdc	AnyImageImporter: doc++	5 years ago
Vladimír Vondruš	f96adfdc37	Doc++, updated changelog.	5 years ago
Vladimír Vondruš	b25ab9d809	AnyImageConverter: recognize KTX2 files. Preparing for the soon-to-be-merged KTX files. Not hooking up 1D/3D and the compressed APIs yet, doing that only when the plugins get merged so I have a way to test.	5 years ago
Pablo Escobar	6e2ff2b707	AnyImageImporter: detect KTX2	5 years ago
Vladimír Vondruš	11268c651b	AnyImageConveter: prepare for multi-level image conversion. No formats / plugins implemeneting this yet, so just a dummy implementation and tests.	5 years ago
Vladimír Vondruš	008583d2b2	Trade: support specifying mip levels in AbstractImageConverter. To avoid combinatorial explosion of functions that have to be implemented on the plugin side, the single-image variants proxy to the multi-level variants, if available. THe plugin interface string had to be bumped because otherwise there was a really nasty silent ABI break where instead of doSetFlags() it was suddenly calling doConvert().	5 years ago
Vladimír Vondruš	f85333e40f	AnyImageConverter: test Basis detection.	5 years ago
Vladimír Vondruš	876976bf33	AnyImageConverter: prepare for 1D and 3D images as well. No formats for those yet either, so again just (code-less) placeholders.	5 years ago
Vladimír Vondruš	c30bfa76ab	AnyImageImporter: proxy 1D and 3D images as well. There's no format/plugin that would support these at the moment, so just placeholder test cases for now.	5 years ago
Vladimír Vondruš	2479b34165	AnySceneConverter: forgot to say this is since 2020.06, huh.	5 years ago
Vladimír Vondruš	047c539a17	ÄnyImageImporter: recognize BMP header magic. I needed to know the signature for a StbImageConverter test, so why not add it here as well now that I managed to figure that out.	5 years ago
Vladimír Vondruš	416704fa47	Any{Image,Scene,Shader}Converter: modernize the string code a bit. Only those use StringViews in the plugin API so far, importers not yet.	5 years ago
Vladimír Vondruš	99395eb69a	Doc++	5 years ago
Vladimír Vondruš	e6d673c279	Propagate configuration options in Any* plugins. Minor but very important convenience feature, especially useful when dealing with command-line apps. This now works: magnum-imageconverter a.png a.jpg -c jpegQuality=0.75 The AnyImageConverter gets the jpegQuality option and then automatically propagates it to the concrete plugin (which is either JpegImageConverter or StbImageConverter), possibly warning in case the target plugin doesn't recognize given option (i.e., doesn't list it in its default configuration). Previously the user had to always specify a concrete converter implementation using -C, which was rather annoying and nonintuitive.	5 years ago
Vladimír Vondruš	4d61cda4a3	AnyImageImporter: don't expect metadata to be present too early. The check that the plugin is loadable should happen before this, not after. All other importer plugins do that already.	5 years ago
Vladimír Vondruš	23712c414e	AnyShaderConverter: assert the metadata validity always. Practically the metadata shouldn't be null if we managed to load the plugin already, so this was probably harmless. But dumb.	5 years ago
Vladimír Vondruš	3452fd7a24	AnyShaderConverter: adapt tests to GlslangShaderCovnerter updates.	5 years ago
Vladimír Vondruš	50e75f90c8	AnyImageConverter: rename a test macro for clarity.	5 years ago
Vladimír Vondruš	15ddae576b	AnyImageConverter: add placeholder tests for compressed 2D support.	5 years ago
Vladimír Vondruš	d6a3be571b	AnySceneConverter,AnySceneImporter: expand tests with external plugins. The AnyShaderConverter tests are doing this already anyway, so why not here as well.	5 years ago
Vladimír Vondruš	22d1484814	Test: rename Any* plugin test cases for clarity.	5 years ago
Vladimír Vondruš	ffdbae5974	ObjImporter: fix a GCC 11 warning. Ew, this code is terrible.	5 years ago
Vladimír Vondruš	ec19c25e46	Adapt to Corrade changes.	5 years ago

1 2 3 4 5 ...

367 Commits (6cbc37ecda13d14cc78a66160ef506e32c28bbd7)