magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	8150e06616	DebugTools: support half floats in CompareImage for pixel views. For images it was supported already, but here I forgot somehow.	3 years ago
Vladimír Vondruš	f589aa1a5d	DebugTools: improve pixel view format autodetection in CompareImage. Originally it was just assuming that any Vector3ub or Color3ub is a normalized format. That was kinda enough for many cases, but it started to get annoying with sRGB image comparisons, as those had to be manually reinterpret with a sRGB-less format in order to pass. Now the pixel format detection looks at the expected image format as well, and if the underlying type and component count matches, it inherits the sRGB and normalized property from it as well. If not, it falls back to an integer format for vectors, and normalized format for colors. For vectors this is different from previous behavior but shouldn't cause any problem in practice -- the only result will be that the image comparison fails with a different message for pixel format mismatch than before. This now also properly and fully tests the pixelFormatFor() helper, and adds a missing Color3 specialization of it.	3 years ago
Vladimír Vondruš	79c42fee6e	DebugTools: special-case CompareImage delta calculation for integer types. Integer / packed formats are the majority of uses for this utility, and for them the additional complexity with NaN and infinity handling isn't needed at all. Running ShadersMeshVisualizerGLTest with this change in a Debug build led to its runtime being reduced by about 35%, the total test time excluding benchmarks went from 14.5 seconds to 11. Not bad.	3 years ago
Vladimír Vondruš	4785bbe9da	DebugTools: remove unnecessary std::tuple usage from CompareImage.	4 years ago
Vladimír Vondruš	6bdffb2796	Test: make use of CORRADE_SKIP_IF_NO_ASSERT().	4 years ago
Vladimír Vondruš	a5bc6be094	DebugTools: port CompareImage to Utility::Path, remove all std::strings. Basically mirroring the changes done for Corrade::Compare::File, including storing the filenames as string views to avoid unnecessary copies (and then paying extra attention to not pass temporaries to them in its own tests).	4 years ago
Vladimír Vondruš	37f826c85c	DebugTools: use Debug instead of Error for testing comparator output. Otherwise unrelated error messages such as file read failures would get included, making the tests fail. The Debug output on the other hand isn't used for any internal reporting.	4 years ago
Vladimír Vondruš	822fa0d644	Updated copyright year.	4 years ago
Vladimír Vondruš	d89675e8b0	DebugTools: properly skip CompareImage tests with converters missing. It only checked for importers, but the second part of these tests uses also image converters to produce the actual files.	4 years ago
Vladimír Vondruš	5c6b98391d	Math,DebugTools: adapt tests for Android differences in NaN printing. What a waste of energy. I need my own float printing code already.	4 years ago
Vladimír Vondruš	ce63928efc	Make plugin existence checks in tests consistent.	4 years ago
Vladimír Vondruš	a2f7e1222b	DebugTools: fix CompareImage test to pass on MSVC 2019 16.10(11?). Wow, it's just amazing how printing NaNs can differ among toolchains.	5 years ago
Vladimír Vondruš	ec19c25e46	Adapt to Corrade changes.	5 years ago
Vladimír Vondruš	41bea89c04	DebugTools: restore usage of external plugins in the CompareImage test. This was working originally, but got broken when all plugin interfaces got switched to look for plugins next to the library and not in a hardcoded install path.	5 years ago
Vladimír Vondruš	5719b8fb30	DebugTools: support half-float formats in CompareImage.	5 years ago
Vladimír Vondruš	aea8722729	Add generic depth/stencil PixelFormat values. The 32-bit float depth be needed for the upcoming OpenEXR plugin, added also the remaining ones that will be eventually supported by KTX and DDS plugins.	5 years ago
Vladimír Vondruš	3d136503d8	Updated copyright year.	5 years ago
Vladimír Vondruš	19e0e96d74	Updated copyright year.	6 years ago
Vladimír Vondruš	6721c0e3b2	DebugTools: ugh WTF. I really need to implement my own float printer already, this is a mess.	6 years ago
Vladimír Vondruš	65a2ced2a7	Make this compile and test cleanly with CORRADE_NO_ASSERT defined.	6 years ago
Vladimír Vondruš	88ec50127e	DebugTools: I'm starting to get tired of this.	6 years ago
Vladimír Vondruš	dc56bf413a	DebugTools: update test to pass on clang-cl. NaN printing strikes again.	6 years ago
Vladimír Vondruš	f7f676e01d	DebugTools: remove unused declaration in a test. THis one is split into imageFileZeroDelta() and imageFileNonZeroDelta().	6 years ago
Vladimír Vondruš	f077fc1ada	DebugTools: update test to pass with newer Emscripten on the CI.	6 years ago
Vladimír Vondruš	d89b74d40a	DebugTools: now it can happen that the pixel list is empty.	7 years ago
Vladimír Vondruš	5b1c521f99	DebugTools: provide verbose diagnostic from CompareImage.	7 years ago
Vladimír Vondruš	cb492f932a	DebugTools: don't print a newline after comparison delta image. It makes other stuff too nasty.	7 years ago
Vladimír Vondruš	dbfc145362	DebugTools: copypaste oops, so this wasn't testing the correct thing.	7 years ago
Vladimír Vondruš	f84a91ea06	DebugTools: improve CompareImage failure message. The comparison is <=, so if it passes, it's not "below".	7 years ago
Vladimír Vondruš	a0232e8506	DebugTools: CompareImage can now compare against pixel views. This is getting too good.	7 years ago
Vladimír Vondruš	069c81b9cb	Deprecate passing nullptr to images. Causes too much pain. Ugh.	7 years ago
Vladimír Vondruš	c6737e1958	DebugTools: PIMPL all CompareImage's state. The distinction didn't make sense and we had to include more than necessary. It's great how easy those refactorings are with the 100% code coverage.	7 years ago
Vladimír Vondruš	ed6cde9536	DebugTools: support --save-diagnostic in CompareImage.	7 years ago
Vladimír Vondruš	f102b86645	DebugTools: prepare CompareImage for more than one plugin manager.	7 years ago
Vladimír Vondruš	9e0b24fa5b	DebugTools: doc++, minor cleanup.	7 years ago
Vladimír Vondruš	5d9fb386f5	DebugTools: make CompareImage work correctly with NaNs and infinities.	7 years ago
Vladimír Vondruš	3626562e1d	Adapted to Corrade changes. Mostly missing includes now.	7 years ago
Vladimír Vondruš	e6fb085db7	DebugTools: minor cleanup.	7 years ago
Vladimír Vondruš	10fec86534	DebugTools: no need to use std::vector in CompareImage internals. Containers::Array will do juust fine.	7 years ago
Vladimír Vondruš	930a323c05	GL: removed deprecated aliases to GL functionality in the root namespace. Deprecated for 2018.04, it's been almost a year since. Whoever is using Magnum regularly updated already, and who not can always upgrade gradually (2018.02, 2018.04, 2018.10, 2019.01 etc.).	7 years ago
Vladimír Vondruš	8357442ad7	DebugTools: don't try to use system plugin dirs in CompareImage test. Due to that, all the tests got skipped on the CI and moreover when ABI was broken, tests were failing hard due to ABI mismatches with system installed plugins. No good. Some variants still need to access the system plugin dir (such as checks for compressed data), but those are minimal. Sanitized them nevertheless so a broken system-installed plugin doesn't break the test.	7 years ago
Vladimír Vondruš	24b8ff086c	Removed std::optional backwards compatibility. This was a dirty mess. Good riddance. Also removing the include from the header now, as it has a forward declaration and thus is not needed.	7 years ago
Vladimír Vondruš	2149f7b869	Wrap all tests in unnamed namespaces. This makes the compiler warn about test cases that aren't ever used, which is a good thing.	7 years ago
Vladimír Vondruš	e6b7aa12fa	Updated copyright year.	7 years ago
Vladimír Vondruš	7ad64bda2a	DebugTools: add CompareImageFile, CompareImageToFile + CompareFileToImage. These provide more convenience for the usual cases of comparing a generated image to a file and vice versa.	8 years ago
Vladimír Vondruš	4d565a8f73	DebugTools: CompareImage now supports only generic pixel formats.	8 years ago
Vladimír Vondruš	7785698d35	Split the OpenGL layer out, pt 21: adapted DebugTools.	8 years ago
Vladimír Vondruš	9dcaf23389	Split the OpenGL layer out, pt 4: new Magnum::GL namespace. At the moment just the GL library itself w/o the tests, and without backwards compatibility aliases. The following types were left in the root namespace, despite being in the GL/ directory, as they will get moved back soon: * Image, CompressedImage and their dimensional typedefs * ImageView, CompressedImageView and their dimensional typedefs * PixelStorage Not PixelFormat etc., that one will stay in the GL namespace and a completely new PixelFormat enum will be provided in the root namespace.	8 years ago
Vladimír Vondruš	623fa97970	Updated copyright year.	8 years ago
Vladimír Vondruš	7a16273e5d	Updated copyright year.	9 years ago

1 2

52 Commits (8150e0661681ca3e18be28315ad0786fe1633dd4)