magnum

9892 Commits

21 Branches

19 Tags

70 MiB

Tree: 9cf7ee62f5

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	ded328cd18	imageconverter: start testing this executable as well. Just the --info for now. This seemingly adds quite a lot of uncovered lines, but those were uncovered before as well, it's just actually visible now.	4 years ago
Vladimír Vondruš	7067ed91c8	{scene,image}converter: split implementation and executable tests. They're each a totally different beast and putting them into the same test file doesn't really make sense: - We want to link certain plugins statically on static builds to test certain code paths in the implementation. However this is counter-productive for the executable tests because there we are checking for plugin presence from the test with the assumption that the executable and the test have the exact same set of plugins available (or linked statically). - The executable tests are implemented on Unix only at the moment, thus it's wasteful to try to build it on any other platforms. Having it in a separate file makes it much easier to deal with.	4 years ago
Vladimír Vondruš	cc29cbcc73	{image,scene}converter: extract and test --info printing code. It was quite a pile, and all of it was written just once, relying only on hopefully-available model files that would hopefully touch most code paths. Which means, extremely annoying to make changes in. I extracted the code to a header that can be tested with a mocked-up importer and without having to execute the utility itself, deduplicated the image info printing code, fixed various inconsistencies (such as data/field flags sometimes denoted with superfluous "flags:" and sometimes not) and TODOs (such as 2D/3D skins, where there was no format whatsoever that would have 2D skin support, so the code couldn't get written). Now it's finally possible to easily add the remaining missing features, such as printing camera info.	4 years ago

Author

SHA1

Message

Date

Vladimír Vondruš

ded328cd18

imageconverter: start testing this executable as well.

Just the --info for now. This seemingly adds quite a lot of uncovered
lines, but those were uncovered before as well, it's just actually
visible now.

4 years ago

Vladimír Vondruš

7067ed91c8

{scene,image}converter: split implementation and executable tests.

They're each a totally different beast and putting them into the same
test file doesn't really make sense:

 - We want to link certain plugins statically on static builds to test
   certain code paths in the implementation. However this is
   counter-productive for the executable tests because there we are
   checking for plugin presence from the test with the assumption that
   the executable and the test have the exact same set of plugins
   available (or linked statically).
 - The executable tests are implemented on Unix only at the moment,
   thus it's wasteful to try to build it on any other platforms. Having
   it in a separate file makes it much easier to deal with.

4 years ago

Vladimír Vondruš

cc29cbcc73

{image,scene}converter: extract and test --info printing code.

It was quite a pile, and all of it was written just once, relying only
on hopefully-available model files that would hopefully touch most code
paths. Which means, extremely annoying to make changes in.

I extracted the code to a header that can be tested with a mocked-up
importer and without having to execute the utility itself, deduplicated
the image info printing code, fixed various inconsistencies (such as
data/field flags sometimes denoted with superfluous "flags:" and
sometimes not) and TODOs (such as 2D/3D skins, where there was no format
whatsoever that would have 2D skin support, so the code couldn't get
written).

Now it's finally possible to easily add the remaining missing features,
such as printing camera info.

4 years ago

3 Commits (9cf7ee62f58f317da3048475d4fe37c06b33d379)