magnum

3329 Commits

21 Branches

19 Tags

70 MiB

Tree: b28876ec70

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	f46cda1900	Remove redundant ifdefs and docs from desktop-GL-only code.	12 years ago
Vladimír Vondruš	7376e8f36d	Use functions to bind textures to shader rather than Texture::bind(). Why did I do this: It is more clean, shorter and nice looking with method chaining, i.e. instead of: shader.setColor(...) .setOtherParam(5); texture1.bind(MyShader::Texture1Layer); texture2.bind(MyShader::Texture2Layer); We now have this: shader.setColor(...) .setOtherParam(5) .setTexture1(texture1) .setTexture2(texture2); * It is now also clear which texture type is expected, the layer constant did not say anything about type. * Also it is possible to use new features (multi bind, bindless textures etc.) while preserving the same public API. The only potential disadvantage is that the textures don't stay bound like uniform values do, but this become a non-issue with bindless textures. As usual, the old way is now deprecated and will be removed in some future release.	12 years ago
Vladimír Vondruš	959d40a02d	Split Texture into TextureArray, MultisampleTexture and RectangleTexture. Each texture has slightly different usage requirements and having everything under one generic class is not worth the additional runtime checks and whatnot. The current way with Texture::Target enum (hopefully not too widely used) is now deprecated and will be removed in some future release. However general Texture1D/2D/3D usage is not changed in any way.	12 years ago

Author

SHA1

Message

Date

Vladimír Vondruš

f46cda1900

Remove redundant ifdefs and docs from desktop-GL-only code.

12 years ago

Vladimír Vondruš

7376e8f36d

Use functions to bind textures to shader rather than *Texture::bind().

Why did I do this:

 * It is more clean, shorter and nice looking with method chaining,
   i.e. instead of:

    shader.setColor(...)
          .setOtherParam(5);
    texture1.bind(MyShader::Texture1Layer);
    texture2.bind(MyShader::Texture2Layer);

   We now have this:

    shader.setColor(...)
          .setOtherParam(5)
          .setTexture1(texture1)
          .setTexture2(texture2);

 * It is now also clear which texture type is expected, the layer
   constant did not say anything about type.
 * Also it is possible to use new features (multi bind, bindless
   textures etc.) while preserving the same public API.

The only potential disadvantage is that the textures don't stay bound
like uniform values do, but this become a non-issue with bindless
textures. As usual, the old way is now deprecated and will be removed in
some future release.

12 years ago

Vladimír Vondruš

959d40a02d

Split Texture into TextureArray, MultisampleTexture and RectangleTexture.

Each texture has slightly different usage requirements and having
everything under one generic class is not worth the additional runtime
checks and whatnot. The current way with Texture::Target enum
(hopefully not too widely used) is now deprecated and will be removed in
some future release. However general Texture1D/2D/3D usage is not
changed in any way.

12 years ago

3 Commits (b28876ec7067a0b9c3621725afb19bd70bb2caba)