magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	bf6caece50	Trade: fix MeshData range checks for array attributes. And add a comment explaining why we don't check the pointer for empty meshes -- otherwise empty interleaved meshes would fail with stuff like Trade::MeshData: attribute 0 [0xc:0xc] is not contained in passed vertexData array [0x0:0x0] which ... helps nobody.	5 years ago
Vladimír Vondruš	b4666a2194	Trade: improve tests for MeshData index/attribute view range checks. Found a bug with attribute array size not being taken into account. It triggers now.	5 years ago
Vladimír Vondruš	2059b2b164	Trade: doc++	5 years ago
Vladimír Vondruš	093957a6ed	Trade: no need to zero-init memory in MeshData::*AsArray() helpers. It's all going to get overwritten by the data anyway, so this just unnecessarily hurts perf.	5 years ago
Vladimír Vondruš	3eb5f887d0	Trade: move a helper definition above where it's used first.	5 years ago
Vladimír Vondruš	cc8d88cbb1	Trade: move a test case to where it fits better.	5 years ago
Vladimír Vondruš	206c4d7a9e	Trade: no need to type that much.	5 years ago
Vladimír Vondruš	26a0bf94ff	Trade: improve MeshData type mismatch assertions. We do know what type the user requested, so why not print it as well. And for the array access the message was especially lazy.	5 years ago
Vladimír Vondruš	7a91b56aa1	Trade: test all MeshData mutable/array attribute assertion variants.	5 years ago
Vladimír Vondruš	c904cd0599	Trade: properly propagate array size from MeshData::attributeData(). The test now passes again.	5 years ago
Vladimír Vondruš	f4da3d78cc	Trade: merge MeshData array attribute tests with the main test. Because otherwise we don't properly test all cases. Case in point -- attributeData(UnsignedInt) wasn't correctly propagating the array size, causing the new tests to fail. Fix in the next commit.	5 years ago
Vladimír Vondruš	0ba5f33f73	Trade: consistent terminology in an assert message.	5 years ago
Vladimír Vondruš	343fc8794d	Trade: don't need to delegate trivial things.	5 years ago
Vladimír Vondruš	c24a762e15	Trade: not sure what's up with this silly temporary. Some places have it, some don't. It's shorter without.	5 years ago
Vladimír Vondruš	2b8d9c7e74	Trade: internal API was named in an outdated way. Long ago, during one of the few initial MeshData iterations. there was no VertexFormat, but rather Trade::MeshAttributeType. I managed to get rid of it mostly, except this place.	5 years ago
Vladimír Vondruš	fe57f23e12	Trade: const++	5 years ago
Vladimír Vondruš	e1d62fb154	Trade: typos.	5 years ago
Vladimír Vondruš	46a6724198	Trade: doc++	5 years ago
Vladimír Vondruš	03b7adf71b	imageconverter: some examples of how to use the new functionality. Originally I wanted to show how to convert a JPEG to an EXR directly, however after trying and miserably failing to implement that inside OpenExrImageConverter I realized the plugin is definitely not the place where to perform such conversion. So this will have to wait until there's some proper API in TextureTools or somewhere.	5 years ago
Vladimír Vondruš	77b979041b	imageconverter: ability to extract layers again.	5 years ago
Vladimír Vondruš	5d4342f1c1	imageconverter: implicitly import and convert all image levels. In case of --layers and --levels this only works if the input images have a single level, otherwise --level has to be set. The internal implementation would be too complex otherwise. As a consequence, combining a set of 2D mipmapped images into a 3D mipmapped image means one first has to combine particular 2D image levels to 3D levels and then combine all 3D levels to a 3D mipmapped image, it can't be done in a single step and it also can't be done by first combining levels and then layers.	5 years ago
Vladimír Vondruš	e017ba135c	imageconverter: ability to combine multiple levels together. I still have to figure out the interactions between --layers and --levels and how to implicitly handle conversion of multi-level files.	5 years ago
Vladimír Vondruš	b83099a8c6	imageconverter: ability to combine multiple image layers together. Hey, this was fun, after all!	5 years ago
Vladimír Vondruš	c3213cff9b	imageconverter: print the input filename in each error message. In preparation for support of multiple input files.	5 years ago
Vladimír Vondruš	7a072c59c2	imageconverter: ability to convert also 1D and 3D images. As well as a proper, graceful and helpful diagnostic for images and levels out of bounds. Before the thing just asserted and died.	5 years ago
Vladimír Vondruš	7702c579a5	imageconverter: shorten the argument help a bit.	5 years ago
Vladimír Vondruš	36b7446a6a	Trade: add docs about multi-level image conversion.	5 years ago
Vladimír Vondruš	eea9d32959	Trade: tighten AbstractImageConverter input requirements. The multi-level APIs still don't check anything regarding level sizes and order since for example *.ico has no restrictions at all. But the rest (like non-zero size) is a restriction for all file formats I'm aware of. TgaImageConverter test had to be adapted, I expect a lot of breakages in plugins tests as well. But user code should be fine I think. Also reduced the rather excessive dimensions in AbstractImageConverterTest, since the allocation requirement now made the default Emscripten heap OOM.	5 years ago
Vladimír Vondruš	696e9fb105	imageconverter: note how many dimensions the image has in --info.	5 years ago
Vladimír Vondruš	8ce842117e	imageconverter: am I stupid? yes!	5 years ago
Vladimír Vondruš	008583d2b2	Trade: support specifying mip levels in AbstractImageConverter. To avoid combinatorial explosion of functions that have to be implemented on the plugin side, the single-image variants proxy to the multi-level variants, if available. THe plugin interface string had to be bumped because otherwise there was a really nasty silent ABI break where instead of doSetFlags() it was suddenly calling doConvert().	5 years ago
Vladimír Vondruš	4a7b15cc95	Trade: simplify AbstractImageConverter tests a bit. No need to fill in the images with data if these won't get used at all.	5 years ago
Vladimír Vondruš	b0dc496cba	Trade: doc++	5 years ago
Vladimír Vondruš	95d19de8f0	ShaderTools,Trade: test printing of Feature flag supersets.	5 years ago
Vladimír Vondruš	360ca834e1	Trade: GCC 11 CAN YOU STOP with the pointless fucking warnings. The "funniest" of all is that those get printed in a totally random fashion. Some in Debug, some in Release, some not at all (like, half of the MaterialDataTest doesn'ŧ initialize `state` and yet it doesn't complain). Fuck these half-assed features that achieve nothing except bullying people WHO KNOW WHAT THEY ARE DOING FFS.	5 years ago
Vladimír Vondruš	4c4b259676	Trade: add TextureType::Texture1DArray, Texture2DArray and CubeMapArray.	5 years ago
Vladimír Vondruš	046b9558b7	Trade: rename/deprecate TextureData::Type to TextureType. Because::This::Is::Colon::Cancer. Also rename Cube to CubeMap and get rid of the comment that said cube map images are six consecutive 2D images. Now it's one 3D image instead because that makes more sense, in the very rare case we'd need to have six different images again we could probably add a CubeFace value or some such.	5 years ago
Vladimír Vondruš	90e8798d36	Trade: "flip Y" is not a good idea, "Y up" is clearer.	5 years ago
Vladimír Vondruš	4a06f4d048	Trade: improve docs for the main importer / converter plugins. Interestingly enough, there were no docs whatsoever for image and scene conversion, and neither it was mentioned what all scene data can be imported. Sigh.	5 years ago
Vladimír Vondruš	c13c61e17d	Trade: hint on related APIs in mutable MeshData access.	5 years ago
Vladimír Vondruš	27b0527fc0	Trade: use consistent naming in an assert message.	5 years ago
Vladimír Vondruš	49a5756f70	Trade: minor.	5 years ago
Vladimír Vondruš	1c3f4844e9	Trade: doc++	5 years ago
Vladimír Vondruš	c1c02dea58	Trade: make Abstract{Image,Scene}Converter::doConvertToFile() protected. This is already done for the AbstractImporter and the new AbstractShaderConverter, as there's a common use case of checking just the filename for input/output path or file type detection and then delegating to the common implementation working directly on data.	5 years ago
Vladimír Vondruš	6087107e0d	Trade: don't use deprecated APIs in deprecated APIs. Because MSVC IS STUPID and emits a ton of warnings here. All sane compilers are sane and silent. It doesn't fucking make sense to warn here, COME ON.	5 years ago
Vladimír Vondruš	e6d673c279	Propagate configuration options in Any* plugins. Minor but very important convenience feature, especially useful when dealing with command-line apps. This now works: magnum-imageconverter a.png a.jpg -c jpegQuality=0.75 The AnyImageConverter gets the jpegQuality option and then automatically propagates it to the concrete plugin (which is either JpegImageConverter or StbImageConverter), possibly warning in case the target plugin doesn't recognize given option (i.e., doesn't list it in its default configuration). Previously the user had to always specify a concrete converter implementation using -C, which was rather annoying and nonintuitive.	5 years ago
Aaron Gokaslan	ca677c69fe	Fix typos	5 years ago
Vladimír Vondruš	f216320da6	GCC 11, your fancy new warnings are NOT helpful.	5 years ago
Vladimír Vondruš	2066d82ea4	Shaders: suffix all existing shaders with GL. To make room for Vulkan shaders. Also renaming the headers, of course everything is still aliased to the old names (and marked as deprecated).	5 years ago
Vladimír Vondruš	ec19c25e46	Adapt to Corrade changes.	5 years ago

1 2 3 4 5 ...

466 Commits (bf6caece50900cdf45f7af8c9371da8a17a78fb8)