magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	d0b792791f	Text: taking a pointer in cache.findFont() is stupid, don't. Especially given that nullptr causes an assert. All call sites basically ended up passing a &font and all that extra annoyance just doesn't make sense. Given this API is still relatively recent, I'm not bothering with backwards compatibility.	3 years ago
Vladimír Vondruš	2a6ebf091f	Text: drop a workaround for zero-size items in GlyphCache reserve(). The AtlasLandfill no longer rejects those, so it's unnecessary.	3 years ago
Vladimír Vondruš	6707534ce6	Text: rework AbstractGlyphCache for better flexibility and efficiency. The class now supports incremental filling, multiple fonts, texture arrays, removes all reliance on STL containers and is finally properly documented. To avoid complete breakage of every use, as much as possible was kept as deprecated APIs -- in particular the reserve() with the nasty std::vectors, the insert() that assumes a 2D cache and a single font and textureSize() that returns a 2D vector. Those behave the same as before, but will assert if the cache is an array or contains more than one font. On the other hand, begin() / end() access with std::unordered_map iterators (ew!) was removed as the internals simply aren't a hashmap anymore. The image() that returned an Image2D is now used to fill the glyph cache instead of querying its potentially processed contents, and returns a MutableImageView3D. I considered keeping it and adding sourceImage() instead, but such naming turned out to be too inconsistent. For querying processed image data (such as with the distance field cache) there's a new processedImage() query, guarded by new GlyphCacheFeature bits -- if both ImageProcessing and ProcessedImageDownload is set, it can be used to retrieve the processed image (so, similar as ImageDownload was before), and if neither is set, the cache contents are queryable directly through image(), without needing any special support from the GPU API. Existing code is updated only in the minimal way possible to ensure that no serious breakage was introduced by reimplementing the deprecated APIs on top of the new backend. Porting away from deprecated APIs will be done in next commits. The GlyphCache and DistanceFieldGlyphCache have their public API kept intact for now, as a similar rework will be needed for them as well. Additionally, the MagnumFont and MagnumFontConverter plugins aren't compiling yet as they require substantial changes to deal with the new glyph cache features. That is not the case with other plugins in the magnum-plugins repository tho, for those the backwards compatibility "just works". On the other hand, since layout of the AbstractGlyphChange changed, I'm bumping the AbstractFont plugin interface version to force-trigger a rebuild of dependent projects. Because I ran a stale magnum-player binary, it worked without crashing or GL errors but just didn't show ANY text whatsoever due to ABI differences, and I wasted some precious minutes before realizing that a simple rebuild would fix it.	3 years ago
Vladimír Vondruš	d460134122	Text: test glyph cache access with padding included. It's been [0] days since the last issue caused by "100%" coverage.	3 years ago
Vladimír Vondruš	ebe15db906	Text: test with inserting a non-zero glyph and one that is in bounds. Not sure how this assertion even fired before since it's just replacing the default invalid glyph.	3 years ago
Vladimír Vondruš	2692ff216c	Text: use the new landfill packer in AbstractGlyphCache. Not yet the full extent of it including rotations and incremental packing, as the existing interface is too awful, also patching over zero-sized glyphs that the new packer doesn't like. Another round of deprecations needs to happen first.	3 years ago
Vladimír Vondruš	06d8a80fac	Text: properly test AbstractGlyphCache::reserve() behavior. Once again a case of "100%" coverage.	3 years ago
Vladimír Vondruš	bab1559852	Consistently use "out of range" instead of "out of bounds". Not that C++ STL and exceptions would be anything to take inspiration from, but there's std::out_of_range. Python IndexError is also specified as "index out of range", not "bounds".	3 years ago
Vladimír Vondruš	82691fcd50	Text: full test coverage for the GlyphCache classes. About time this got done. This also has an XFAIL for the case where a distance field image is processed with an offset, have to fix the underlying issue in TextureTools first. Also added a range assertion for the distance field image setter to match what the abstract base does, together with a corresponding getter.	3 years ago
Vladimír Vondruš	cec98b5278	Text: various minor cleanup.	3 years ago
Vladimír Vondruš	bbb54a9df8	It's 2023 already!	3 years ago
Vladimír Vondruš	6bdffb2796	Test: make use of CORRADE_SKIP_IF_NO_ASSERT().	4 years ago
Vladimír Vondruš	822fa0d644	Updated copyright year.	4 years ago
Vladimír Vondruš	3d136503d8	Updated copyright year.	5 years ago
Vladimír Vondruš	19e0e96d74	Updated copyright year.	6 years ago
Vladimír Vondruš	65a2ced2a7	Make this compile and test cleanly with CORRADE_NO_ASSERT defined.	6 years ago
Vladimír Vondruš	71a9f1bbbf	Reserve zero [Compressed]PixelFormat for an invalid value. Catches accidents better -- just look at the diff. Might catch accidents in your code now as well, so beware!	7 years ago
Vladimír Vondruš	069c81b9cb	Deprecate passing nullptr to images. Causes too much pain. Ugh.	7 years ago
Vladimír Vondruš	93789721b2	De-inline Image headers, remove dependency on ImageView. This means users have to add some more #includes on their side. Sorry but it's for your own good :P	7 years ago
Vladimír Vondruš	3626562e1d	Adapted to Corrade changes. Mostly missing includes now.	7 years ago
Vladimír Vondruš	2b30246ff2	Fixed various MSVC warnings about clashing variable names.	7 years ago
Vladimír Vondruš	834c5fe40d	Text: API-independent base for glyph caches. Allows the Font and FontConverter plugins be built without TARGET_GL enabled. That was the last piece missing for making the magnum-plugins repo completely GL-free.	7 years ago

22 Commits (e2523097d28b2722fab715e6b8dedf1f2449ad04)