magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	ee27d42a37	ShaderTools,Trade: properly test failure states of all plugin APIs. Until now, these were only transitively tested in concrete plugin implementations, meaning that if the base implementation would have an error (such as accessing a null optional), it would only get discovered when building a plugin, worst case a plugin in a completely different repo.	4 years ago
Vladimír Vondruš	59c163d963	Trade: we can use test verification macros in unrelated functions now.	4 years ago
Vladimír Vondruš	02f679e91c	Revert "Trade: expand SceneConverterFeature to 64 bits." Shouldn't have gone to master yet, sorry. This reverts commit `ee983fd098`.	4 years ago
Vladimír Vondruš	3684160db3	Trade: minor AbstractSceneConverter test improvement.	4 years ago
Vladimír Vondruš	7b2a56a5e9	Trade: test growable and non-owning deleters in all SceneConverter cases.	4 years ago
Vladimír Vondruš	ee983fd098	Trade: expand SceneConverterFeature to 64 bits. We'll need many MANY more than just 8 bits for the generic export.	4 years ago
Vladimír Vondruš	8f311ad5fd	Adapt remaining code to not use deprecated Optional<Array> conversion.	4 years ago
Vladimír Vondruš	51f7862e00	ShaderTools,Trade: return Optional<Array<char>> from converter plugins. Consistently with changes done to Utility::Path, this enforces proper error handling on user side. Originally I didn't want to do this and instead wanted to have a special Array instance devoted for an error state, but that still would allow the error state be errorneously treated as a successful but empty array.	4 years ago
Vladimír Vondruš	98296567a7	Trade: port to the new Utility::Path. For file opening there's no longer an unatomic pair of exists() + read(), but since Path::read() now returns an Optional, it means we can reliably distinguish between empty files and failures. While at it, also added TODOs for removal of the StringStl.h header that's needed in various places for compatibility with APIs still using STL strings.	4 years ago
Vladimír Vondruš	97e45ea14d	Adapt tests to changes in Utility::Directory error reporting. Now comparing just the message coming out of our code, ignoring the system-specific message Directory prints.	4 years ago
Vladimír Vondruš	44db05a13c	Don't call Utility::Directory::rm() unconditionally in tests. It now prints an error message in case of failure, so if the file is not there, it generates noise in the output.	4 years ago
Vladimír Vondruš	822fa0d644	Updated copyright year.	4 years ago
Vladimír Vondruš	95d19de8f0	ShaderTools,Trade: test printing of Feature flag supersets.	5 years ago
Vladimír Vondruš	06e039dbe7	Trade: reverse AbstractSceneConverter::convertToFile() argument order. It should be input first, output second, like with all other APIs. I remember I was trying something else here, but that didn't really make sense in the end. Also took that opportunity to get rid of one std::string. The original signature is a deprecated alias to the new one and will be removed in a future release.	5 years ago
Vladimír Vondruš	29ac7b5a4d	Trade,ShaderTools: add addFlags() / clearFlags() to all plugin interfaces. There will be Flag::FlipY for images at some point, enabled by default for compatibility with existing GL code, and so it makes sense to start discouraging setFlags() as early as possible to avoid people resetting the default by accident. Also update the imageconverter, sceneconverter and shaderconverter utils to use these instead of setFlags().	5 years ago
Vladimír Vondruš	3d136503d8	Updated copyright year.	5 years ago
Vladimír Vondruš	fb972b262b	Trade: explicitly test a case with failed conversion written to a file. Too easy to forget this check, write an empty file and return true.	6 years ago
Vladimír Vondruš	485780af3a	Trade: KDevelop, come on, learn to not do this already.	6 years ago
Vladimír Vondruš	3fd5a734ae	Trade: I'm too old for this much needless code duplication.	6 years ago
Vladimír Vondruš	19e0e96d74	Updated copyright year.	6 years ago
Vladimír Vondruš	2dc47839ef	Trade: bootstrap scene converter plugins.	6 years ago

21 Commits (ee27d42a3743aedbe8790652a3389deaa2514aff)