magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	f91ce08591	Trade: mention upfront that all *Data are basically immutable.	2 years ago
Vladimír Vondruš	eef921c238	It's October already?!	2 years ago
Vladimír Vondruš	7a05ddbf07	doc: explicitly prefix all Corrade API references with Corrade::. Doxygen 1.12 has no longer a completely insane matcher and discards those as it should. With 1.8.17 classes had to be referenced with Corrade:: but functions, typedefs and variables didn't need to be and it was a complete utter chaos.	2 years ago
Vladimír Vondruš	2619dc33f1	doc: drop the redundant Magnum prefix from snippet files. I accidentally did that at first, and then "for consistency" continued with that for a decade.	2 years ago
Vladimír Vondruš	c9e13a5c30	Trade: doc++	2 years ago
Vladimír Vondruš	17f79deca8	Trade: doc++	2 years ago
Vladimír Vondruš	5d1369f570	Use Utility::move() and swap() instead of STL almost everywhere. Partially needed to avoid build breakages because Corrade itself switched as well, partially because a cleanup is always good. Done except for (STL-heavy) code that's deprecated or SceneGraph-related APIs that are still quite full of STL as well.	3 years ago
Vladimír Vondruš	bbb54a9df8	It's 2023 already!	3 years ago
Vladimír Vondruš	041b1aa654	Trade: improve MeshData, SceneData and MaterialData population docs. Especially the part about non-owned data was lacking, with basically no information about what are offset-only attributes and fields actually good for.	3 years ago
Vladimír Vondruš	6d8999eefd	Trade: expect MaterialData attrs to not be larger than end layer offset. Such an unnecessary footgun -- I was already checking the other case, having attribute data too short, but this I thought is fine because it's not leading to any crash. Well it's leading to needless pain and suffering, that's what it is doing! And of course already found FIVE such bugs in just Magnum tests alone.	3 years ago
Vladimír Vondruš	6ab446f7ed	Trade: document that MaterialAttributeData expect a non-empty name. It's good to have that explicitly mentioned to not have to guess (or, worse, browse the code).	3 years ago
Vladimír Vondruš	f0b4459ce3	Trade: doc++ I spent some time wondering if as<PbrClearCoatMaterialData>() can be used on a material that doesn't neccessarily have that layer. It can, so hint that in the docs.	3 years ago
Vladimír Vondruš	f0cbb8d3c1	Doc++ Forgot to run Doxygen after `a475c92d99`.	4 years ago
Vladimír Vondruš	649017c0ff	Trade: add MaterialData::attributeDataOffset().	4 years ago
Vladimír Vondruš	7ce5efc102	Trade: doc++	4 years ago
Vladimír Vondruš	36f7e0c1d4	Trade: rename MaterialData::tryAttribute() to findAttribute(). Which is consistent with about everything else. No idea why I picked such a strange API name. Backwards compatibility aliases in place, as these are likely used by a lot of code already. To ensure I didn't break anything, I'm updating all code to use the new API in the next commit.	4 years ago
Vladimír Vondruš	fcbb9d230d	Trade: document MaterialAttribute defaults. They were documented in the convenience accessor classes, but here it makes sense too. The only attribute for which I'm hesitating to specify a default is Phong shininess -- the value of 80 feels a bit too arbitrary to be useful.	4 years ago
Vladimír Vondruš	df45cfadd7	Trade: add a MaterialData::attributeData(layer, id) accessor. For cases where the whole MaterialAttributeData instance is needed and calculating the right offset into the array returned by attributeData() would be too error-prone. Similar accessor is in MeshData already, so this achieves better feature parity between the two.	4 years ago
Vladimír Vondruš	30bd1cd3b6	Trade: add MaterialDataType::Buffer. Because storing arbitrary data as a string was not good: - It never followed alignment requirements due to the last byte being used for size. Instead the size is now stored before the data, and thus the data is always on the 64 byte boundary. - As it could contain arbitrary binary data, it could cause magnum-sceneconverter --material-info to print garbage, corrupt the terminal or, worst case, crash. Not good. - It stored an implicit \0, which was unnecessary.	4 years ago
Vladimír Vondruš	26c973bd9b	Trade: doc++	4 years ago
Vladimír Vondruš	e1619e5aab	Trade: expose materialLayerName() and materialAttributeName(). The enum-to-string conversion was just a private API and we need to use it in various material filtering code. It was also a private class member for some reason, even though it has no relation to / dependency on the MaterialData class. So it's made a free function instead.	4 years ago
Vladimír Vondruš	16703f3137	Trade: doc++	4 years ago
Vladimír Vondruš	3cb7fe5993	Trade: doc++ The MeshData and SceneData find APIs had the complexity documented, do the same for MaterialData too. Plus cross-link this API from hasAttribute() / hasField() so it's easier to find.	4 years ago
Vladimír Vondruš	a9a4caf740	Trade: add MaterialData::findAttributeId() and findLayerId(). Similar to SceneData::findFieldId() and MeshData::findAttributeId(), useful to avoid a double lookup with hasAttribute() + attribute().	4 years ago
Vladimír Vondruš	9941d83e1d	Trade: rename internal MaterialData helpers for consistency. This is how SceneData names it, a prep for introducing findAttributeId() and findLayerId().	4 years ago
Vladimír Vondruš	e7f9e74346	Trade: support for texture array layers in all MaterialData attributes. Logic mostly the same as with MaterialAttribute::*TextureCoordinates -- attribute not present is treated the same way as if the layer was 0 (since that's what a 2D non-array texture is, a single-slice array), and conversely if the attribute is 0 it's the same as if it would be not present at all. Plus it also gets checked in queries for packed textures, if everything is the same but the layer is different, then it's not a packed texture. The rest of the commit is just busywork for convenience APIs.	4 years ago
Vladimír Vondruš	cb7dd224db	Trade: doc++, minor.	4 years ago
Vladimír Vondruš	b0bfcbe00e	Adapt to Corrade changes.	4 years ago
Vladimír Vondruš	822fa0d644	Updated copyright year.	4 years ago
Vladimír Vondruš	72f686377e	Trade: doc++	4 years ago
Vladimír Vondruš	e08efa62a1	Trade: disallow empty MaterialAttributeData names. Overlooked during the initial design -- it'd sort before " LayerName", which is undesirable.	4 years ago
Vladimír Vondruš	aeeff73a71	Trade: use ` LayerName` instead of `$LayerName` in MaterialData. Reason is that Assimp custom material attribute names are also prefixed with $ and other weird characters, which could lead to them appearing before $LayerName, causing a layer to falsely appear unnamed. A space, instead, is before all printable characters so it's guaranteed to be always first. Some things you just don't realize at first. Fortunately the binary layout isn't pinned yet for the serialization format so this change is mostly fine.	5 years ago
Vladimír Vondruš	78cf81bfca	Trade: mutable access to MaterialData attribute values. Hah, so many overloads. Not providing mutable access to keys or layer offsets as that would break the invariant of the internal array always being sorted.	5 years ago
Vladimír Vondruš	145d41dcff	Trade: doc++	5 years ago
Vladimír Vondruš	5ef7bd26e7	Trade: improve MaterialData type mismatch assertions. Followup to `26a0bf94ff` where it was done for MeshData, forgot that this class suffers from the same issue.	5 years ago
Vladimír Vondruš	ebfbfcbb73	Trade: doc++	5 years ago
Vladimír Vondruš	781c5c3e08	Trade: doc++	5 years ago
Vladimír Vondruš	46a6724198	Trade: doc++	5 years ago
Vladimír Vondruš	807c337db1	Trade: adapt to CORRADE_ALIGNAS() deprecation.	5 years ago
Vladimír Vondruš	3d136503d8	Updated copyright year.	5 years ago
Vladimír Vondruš	7498d5742f	Trade: fix unused variable warning when building with CORRADE_NO_ASSERT.	5 years ago
Vladimír Vondruš	329ea4d33d	Trade: shh, GCC 4.8. Or does THIS cause the OOMs?	5 years ago
Vladimír Vondruš	5a1f43f20b	Switch to the new & optimized GenerateSequence from Corrade. This should help slightly with compiler memory usage, on GCC 10 the huge Trade::MaterialData test used "only" 309 instead of 318 MB after this change.	5 years ago
Vladimír Vondruš	78f38b89ad	Trade: doc++ Huh, so much copypaste bullshit.	6 years ago
Vladimír Vondruš	ec22b33e01	Trade: document how normal texture scale is meant to be applied.	6 years ago
janos	12529efa89	Trade: various doc fixes.	6 years ago
Vladimír Vondruš	44f67e7748	Trade: rethink common material texture coordinate transform/sets. There's actually a lot of code involved in checking if all textures use the same transform or coordinate set, especially when considering all fallback variants and potential future expansion with separate texture offset/scale/rotation attributes. A lot of the complexity was thus hidden in plugin implementations, which were each trying to find a common value for all textures to save the user from doing the same. All that code can now be removed and left up to the material APIs themselves -- now it's just about checking hasCommonTextureTransformation() and then retrieving that one common transformation, independently on how the material actually defines it.	6 years ago
Vladimír Vondruš	81f5468b65	Trade: custom material attribs can start with non-letters as well. Becase $assimp ?does +that.	6 years ago
Vladimír Vondruš	829e9b6d0f	Trade: add forgotten OcclusionTextureStrength attribute. Whoops, again.	6 years ago
Vladimír Vondruš	baa23ffd10	Trade: and you, MSVC 2015, need a special place in hell.	6 years ago

1 2

68 Commits (f91ce085917cf972ac2f3e2459e2ebb658e4e252)