From 1723e5f05fe1ce7ba9997804c5742b2642177faa Mon Sep 17 00:00:00 2001 From: "U-olece-PC\\olece" Date: Mon, 7 Dec 2015 18:43:26 +0100 Subject: [PATCH] Fixed a memory leak and updated a comment --- src/process.hpp | 2 +- src/process_win.cpp | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/process.hpp b/src/process.hpp index 79d5ef5..60ddad5 100644 --- a/src/process.hpp +++ b/src/process.hpp @@ -57,7 +57,7 @@ public: ///Kill the process. void kill(bool force=false); - ///Kill a given process id. + ///Kill a given process id. Use kill(bool force) instead if possible. static void kill(id_type id, bool force=false); private: diff --git a/src/process_win.cpp b/src/process_win.cpp index 703a607..6132732 100644 --- a/src/process_win.cpp +++ b/src/process_win.cpp @@ -124,7 +124,9 @@ Process::id_type Process::open(const std::string &command, const std::string &pa BOOL bSuccess = CreateProcess(NULL, command_cstr, NULL, NULL, TRUE, 0, NULL, path_ptr, &siStartInfo, &process_info); - + delete[] path_ptr; + delete[] command_cstr; + if(!bSuccess) { CloseHandle(process_info.hProcess); CloseHandle(process_info.hThread);