diff --git a/src/process.hpp b/src/process.hpp index 60ddad5..6eb50e4 100644 --- a/src/process.hpp +++ b/src/process.hpp @@ -14,8 +14,8 @@ #endif ///Create a new process given command and run path. -///Note: on Windows it seems impossible to specify which pipes to use. -///Thus, if read_stdout==nullptr, read_stderr==nullptr and open_stdin==false, +///TODO: on Windows it is harder to specify which pipes to redirect. +///Thus, at the moment, if read_stdout==nullptr, read_stderr==nullptr and open_stdin==false, ///the stdout, stderr and stdin are sent to the parent process instead. ///Compile with -DMSYS_PROCESS_USE_SH to run command using "sh -c [command]" on Windows as well. class Process { diff --git a/src/process_win.cpp b/src/process_win.cpp index 1371e0d..7bf8242 100644 --- a/src/process_win.cpp +++ b/src/process_win.cpp @@ -8,8 +8,6 @@ using namespace std; //TODO: remove Process::Data::Data(): id(0), handle(NULL) {} //Based on the example at https://msdn.microsoft.com/en-us/library/windows/desktop/ms682499(v=vs.85).aspx. -//Note: on Windows it seems impossible to specify which pipes to use. -//Thus, if read_stdout==nullptr, read_stderr==nullptr and open_stdin==false, the stdout, stderr and stdin are sent to the parent process instead. Process::id_type Process::open(const std::string &command, const std::string &path) { if(open_stdin) stdin_fd=std::unique_ptr(new fd_type);