From c2da91c9787d8ff8e7f52ed6b27ec2e116973c71 Mon Sep 17 00:00:00 2001 From: es Date: Mon, 15 Jun 2015 14:08:06 +0200 Subject: [PATCH 01/16] Proof of concept --- juci/notebook.cc | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/juci/notebook.cc b/juci/notebook.cc index 2d671d2..c9c6ad1 100644 --- a/juci/notebook.cc +++ b/juci/notebook.cc @@ -1,6 +1,8 @@ #include #include "notebook.h" #include "logging.h" +#include // c-library + Notebook::Model::Model() { cc_extension_ = ".cpp"; @@ -412,8 +414,8 @@ void Notebook::Controller::OnEditSearch() { } void Notebook::Controller::Search(bool forward) { - INFO("Notebook search"); - int page = CurrentPage(); + INFO("Notebook search"); + /* int page = CurrentPage(); std::string search_word; search_word = entry_.text(); Gtk::TextIter test; @@ -440,6 +442,14 @@ void Notebook::Controller::Search(bool forward) { search_match_start_, search_match_end_); } +*/ + auto buffer = CurrentTextView().get_source_buffer(); + auto settings = gtk_source_search_settings_new(); + gtk_source_search_settings_set_search_text(settings, entry_.text().c_str()); + auto context = gtk_source_search_context_new(buffer->gobj(), settings); + gtk_source_search_context_set_highlight(context, forward); + auto itr = buffer->get_insert()->get_iter().gobj(); + gtk_source_search_context_forward(context, itr, NULL, NULL); } void Notebook::Controller From 6602bc58dd49d89698dda395857f8901c7be3c9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8rgen=20Lien=20Sell=C3=A6g?= Date: Tue, 16 Jun 2015 00:05:32 +0200 Subject: [PATCH 02/16] Scroll to on search now works --- juci/notebook.cc | 36 +++++++----------------------------- juci/notebook.h | 1 + 2 files changed, 8 insertions(+), 29 deletions(-) diff --git a/juci/notebook.cc b/juci/notebook.cc index c9c6ad1..9b7b060 100644 --- a/juci/notebook.cc +++ b/juci/notebook.cc @@ -29,6 +29,8 @@ Notebook::Controller::Controller(Gtk::Window* window, ispopup = false; view().pack1(directories_.widget(), true, true); CreateKeybindings(keybindings); + end = CurrentTextView().get_source_buffer()->end(); + start = CurrentTextView().get_source_buffer()->end(); INFO("Notebook Controller Success"); } // Constructor @@ -415,41 +417,17 @@ void Notebook::Controller::OnEditSearch() { void Notebook::Controller::Search(bool forward) { INFO("Notebook search"); - /* int page = CurrentPage(); - std::string search_word; - search_word = entry_.text(); - Gtk::TextIter test; - - if ( !forward ) { - if ( search_match_start_ == 0 || - search_match_start_.get_line_offset() == 0) { - search_match_start_ = Buffer(*text_vec_.at(CurrentPage()))->end(); - } - search_match_start_. - backward_search(search_word, - Gtk::TextSearchFlags::TEXT_SEARCH_TEXT_ONLY | - Gtk::TextSearchFlags::TEXT_SEARCH_VISIBLE_ONLY, - search_match_start_, - search_match_end_); - } else { - if ( search_match_end_ == 0 ) { - search_match_end_ = Buffer(*text_vec_.at(CurrentPage()))->begin(); - } - search_match_end_. - forward_search(search_word, - Gtk::TextSearchFlags::TEXT_SEARCH_TEXT_ONLY | - Gtk::TextSearchFlags::TEXT_SEARCH_VISIBLE_ONLY, - search_match_start_, - search_match_end_); - } -*/ auto buffer = CurrentTextView().get_source_buffer(); auto settings = gtk_source_search_settings_new(); gtk_source_search_settings_set_search_text(settings, entry_.text().c_str()); auto context = gtk_source_search_context_new(buffer->gobj(), settings); gtk_source_search_context_set_highlight(context, forward); auto itr = buffer->get_insert()->get_iter().gobj(); - gtk_source_search_context_forward(context, itr, NULL, NULL); + gtk_source_search_context_forward(context, + end ? end.gobj() : itr, + start.gobj(), + end.gobj()); + CurrentTextView().scroll_to(end); } void Notebook::Controller diff --git a/juci/notebook.h b/juci/notebook.h index fa3fc80..c8f0d9f 100644 --- a/juci/notebook.h +++ b/juci/notebook.h @@ -74,6 +74,7 @@ namespace Notebook { bool OnKeyRelease(GdkEventKey* key); std::string OnSaveFileAs(); bool LegalExtension(std::string extension); + Gtk::TextIter start, end; protected: void TextViewHandlers(Gtk::TextView& textview); From 07d7741928b2c958137971f0a3548ada14abe4fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8rgen=20Lien=20Sell=C3=A6g?= Date: Tue, 16 Jun 2015 00:16:27 +0200 Subject: [PATCH 03/16] Add wrapping search --- juci/notebook.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/juci/notebook.cc b/juci/notebook.cc index 9b7b060..f4862da 100644 --- a/juci/notebook.cc +++ b/juci/notebook.cc @@ -420,8 +420,12 @@ void Notebook::Controller::Search(bool forward) { auto buffer = CurrentTextView().get_source_buffer(); auto settings = gtk_source_search_settings_new(); gtk_source_search_settings_set_search_text(settings, entry_.text().c_str()); +gtk_source_search_settings_set_wrap_around(settings, TRUE); auto context = gtk_source_search_context_new(buffer->gobj(), settings); gtk_source_search_context_set_highlight(context, forward); + + + auto itr = buffer->get_insert()->get_iter().gobj(); gtk_source_search_context_forward(context, end ? end.gobj() : itr, From bca64014af20d42cbbd3d7f1bb35b86d581b93f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8rgen=20Lien=20Sell=C3=A6g?= Date: Wed, 17 Jun 2015 16:02:45 +0200 Subject: [PATCH 04/16] Add mark of current search result, needs more work --- juci/config.json | 1 + juci/notebook.cc | 13 +++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/juci/config.json b/juci/config.json index 7c0b9d1..1a73d5c 100644 --- a/juci/config.json +++ b/juci/config.json @@ -2,6 +2,7 @@ "source": { "colors": { "text_color": "black", + "search": "orange", "string": "#CC0000", "namespace_ref": "#990099", "type": "#0066FF", diff --git a/juci/notebook.cc b/juci/notebook.cc index c8fae34..39cbaab 100644 --- a/juci/notebook.cc +++ b/juci/notebook.cc @@ -416,20 +416,25 @@ void Notebook::Controller::OnEditSearch() { void Notebook::Controller::Search(bool forward) { INFO("Notebook search"); + + // fetch buffer and greate settings auto buffer = CurrentTextView().get_source_buffer(); auto settings = gtk_source_search_settings_new(); + + // get search text from entry gtk_source_search_settings_set_search_text(settings, entry_.text().c_str()); -gtk_source_search_settings_set_wrap_around(settings, TRUE); + + // make sure the search continues + gtk_source_search_settings_set_wrap_around(settings, true); auto context = gtk_source_search_context_new(buffer->gobj(), settings); gtk_source_search_context_set_highlight(context, forward); - - - auto itr = buffer->get_insert()->get_iter().gobj(); gtk_source_search_context_forward(context, end ? end.gobj() : itr, start.gobj(), end.gobj()); + + buffer->apply_tag_by_name("search", start, end); CurrentTextView().scroll_to(end); } From d79349cc9ad301ee79e7996b9dcc33280c6f122a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8rgen=20Lien=20Sell=C3=A6g?= Date: Sat, 20 Jun 2015 14:41:04 +0200 Subject: [PATCH 05/16] jumping search now works --- juci/notebook.cc | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/juci/notebook.cc b/juci/notebook.cc index bffd6e5..ce4fea2 100644 --- a/juci/notebook.cc +++ b/juci/notebook.cc @@ -426,16 +426,31 @@ void Notebook::Controller::Search(bool forward) { // get search text from entry gtk_source_search_settings_set_search_text(settings, entry_.text().c_str()); - // make sure the search continues + // make sure the search continues at top again gtk_source_search_settings_set_wrap_around(settings, true); + auto context = gtk_source_search_context_new(buffer->gobj(), settings); - gtk_source_search_context_set_highlight(context, forward); - auto itr = buffer->get_insert()->get_iter().gobj(); - gtk_source_search_context_forward(context, - end ? end.gobj() : itr, + + // makes the search mark all results + gtk_source_search_context_set_highlight(context, true); + + // gets iter at user input + auto itr = buffer->get_insert()->get_iter(); + DEBUG("Removing search tag") + buffer->remove_tag_by_name("search", start ? start : itr, end ? end : itr); + DEBUG("Before search"); + if (forward) { + gtk_source_search_context_forward(context, + end ? end.gobj() : itr.gobj(), start.gobj(), end.gobj()); - + } else { + gtk_source_search_context_backward(context, + start ? end.gobj() : itr.gobj(), + start.gobj(), + end.gobj()); + } + DEBUG("Before mark of search"); buffer->apply_tag_by_name("search", start, end); CurrentTextView().scroll_to(end); } From 88c83660c174911b6415efee54774af349a2e881 Mon Sep 17 00:00:00 2001 From: eidheim Date: Thu, 25 Jun 2015 13:09:43 +0200 Subject: [PATCH 06/16] Cleaned up entry.*. New file now works, but did simplify it abit, that is removed new header and new c++ file, hope that was ok. More cleanup of source.* too. --- juci/config.json | 2 - juci/entry.cc | 121 ++++++++++++++++++++------------------------ juci/entry.h | 50 ++++++------------ juci/menu.xml | 6 +-- juci/notebook.cc | 128 ++++++++++++++++------------------------------- juci/notebook.h | 25 ++------- juci/window.cc | 2 +- 7 files changed, 118 insertions(+), 216 deletions(-) diff --git a/juci/config.json b/juci/config.json index 7c0b9d1..90723a7 100644 --- a/juci/config.json +++ b/juci/config.json @@ -40,8 +40,6 @@ }, "keybindings": { "new_file": "n", - "new_h_file": "h", - "new_cc_file": "c", "open_folder": "o", "open_file": "o", "save": "s", diff --git a/juci/entry.cc b/juci/entry.cc index 011ce6c..429016c 100644 --- a/juci/entry.cc +++ b/juci/entry.cc @@ -1,74 +1,61 @@ #include "entry.h" -Entry::View::View() : - view_(Gtk::ORIENTATION_HORIZONTAL), - button_apply_(Gtk::Stock::APPLY), - button_close_(Gtk::Stock::CLOSE), - button_next_("Next"), - button_prev_("Prev"){ -} -Gtk::Box& Entry::View::view() { - return view_; -} -void Entry::View::OnShowSetFilenName(std::string exstension) { - entry_.set_max_length(50); - entry_.set_text(exstension); - view_.pack_start(entry_); - view_.pack_end(button_close_, Gtk::PACK_SHRINK); - view_.pack_end(button_apply_, Gtk::PACK_SHRINK); -} -void Entry::View::OnShowSearch(std::string current){ - entry_.set_max_length(50); - entry_.set_text(current); - view_.pack_start(entry_); - view_.pack_start(button_next_, Gtk::PACK_SHRINK); - view_.pack_start(button_prev_, Gtk::PACK_SHRINK); - view_.pack_end(button_close_, Gtk::PACK_SHRINK); -} -void Entry::View::OnHideEntry(bool is_new_file) -{ - view_.remove(entry_); - view_.remove(button_close_); - if(!is_new_file){ - view_.remove(button_next_); - view_.remove(button_prev_); - }else{ - view_.remove(button_apply_); - } -} -Entry::Controller::Controller() { -} -Gtk::Box& Entry::Controller::view() { - return view_.view(); -} -void Entry::Controller::OnShowSetFilenName(std::string exstension) { - view_.OnShowSetFilenName(exstension); - view_.view().show_all(); - view_.entry().grab_focus(); - view_.entry().set_position(0); -} -void Entry::Controller::OnShowSearch(std::string current){ - view_.OnShowSearch(current); - view_.view().show_all(); - view_.entry().grab_focus(); - view_.entry().set_position(0); +Entry::Entry() : + Gtk::Box(Gtk::ORIENTATION_HORIZONTAL), + button_apply_set_filename(Gtk::Stock::APPLY), + button_close(Gtk::Stock::CLOSE), + button_next("Next"), + button_prev("Prev"){ + entry.signal_activate().connect([this](){ + if(activate) { + activate(); + } + }); + entry.signal_key_press_event().connect(sigc::mem_fun(*this, &Entry::on_key_press), false); } -void Entry::Controller::OnHideEntries(bool is_new_file){ - view_.OnHideEntry(is_new_file); -} -std::string Entry::Controller::text(){ - return view_.entry().get_text(); -} -Gtk::Button& Entry::Controller::button_apply(){ - return view_.button_apply(); -} -Gtk::Button& Entry::Controller::button_close(){ - return view_.button_close(); + +bool Entry::on_key_press(GdkEventKey* key) { + if(key->keyval==GDK_KEY_Escape) + hide(); + return false; } -Gtk::Button& Entry::Controller::button_next(){ - return view_.button_next(); + +void Entry::show_set_filename() { + hide(); + entry.set_max_length(50); + entry.set_text(""); + pack_start(entry); + pack_end(button_close, Gtk::PACK_SHRINK); + pack_end(button_apply_set_filename, Gtk::PACK_SHRINK); + show_all(); + entry.grab_focus(); + entry.set_position(0); + activate=[this](){ + button_apply_set_filename.clicked(); + }; } -Gtk::Button& Entry::Controller::button_prev(){ - return view_.button_prev(); + +void Entry::show_search(const std::string& current){ + hide(); + entry.set_max_length(50); + entry.set_text(current); + pack_start(entry); + pack_start(button_next, Gtk::PACK_SHRINK); + pack_start(button_prev, Gtk::PACK_SHRINK); + pack_end(button_close, Gtk::PACK_SHRINK); + show_all(); + entry.grab_focus(); + entry.set_position(0); + activate=[this](){ + button_next.clicked(); + }; +} +void Entry::hide() { + auto widgets=get_children(); + for(auto &w: widgets) + remove(*w); } +std::string Entry::operator()() { + return entry.get_text(); +} diff --git a/juci/entry.h b/juci/entry.h index ec8b888..36a45e2 100644 --- a/juci/entry.h +++ b/juci/entry.h @@ -2,43 +2,21 @@ #define JUCI_ENTRY_H_ #include +#include #include "gtkmm.h" -#include "keybindings.h" - -namespace Entry { - class View { - public: - View(); - Gtk::Box& view(); - Gtk::Entry& entry(){return entry_;} - Gtk::Button& button_apply(){return button_apply_;}; - Gtk::Button& button_close(){return button_close_;}; - Gtk::Button& button_next(){return button_next_;}; - Gtk::Button& button_prev(){return button_prev_;}; - void OnShowSetFilenName(std::string exstension); - void OnShowSearch(std::string current); - void OnHideEntry(bool is_new_file); - protected: - Gtk::Box view_; - Gtk::Entry entry_; - Gtk::Button button_apply_, button_close_, button_next_, button_prev_; - }; - class Controller { - public: - Controller(); - Gtk::Box& view(); - Gtk::Button& button_apply(); - Gtk::Button& button_close(); - Gtk::Button& button_next(); - Gtk::Button& button_prev(); - - std::string text(); - void OnShowSetFilenName(std::string exstension); - void OnShowSearch(std::string current); - void OnHideEntries(bool is_new_file); - View view_; - };// class controller -} // namespace notebook +class Entry: public Gtk::Box { +public: + Entry(); + void show_set_filename(); + void show_search(const std::string& current); + void hide(); + std::string operator()(); + Gtk::Entry entry; + Gtk::Button button_apply_set_filename, button_close, button_next, button_prev; +private: + bool on_key_press(GdkEventKey* key); + std::function activate; +}; #endif // JUCI_ENTRY_H_ diff --git a/juci/menu.xml b/juci/menu.xml index 2eab08a..18f82e3 100644 --- a/juci/menu.xml +++ b/juci/menu.xml @@ -1,11 +1,7 @@ - - - - - + diff --git a/juci/notebook.cc b/juci/notebook.cc index d0ba733..c1889d7 100644 --- a/juci/notebook.cc +++ b/juci/notebook.cc @@ -2,12 +2,6 @@ #include "notebook.h" #include "logging.h" -Notebook::Model::Model() { - cc_extension_ = ".cpp"; - h_extension_ = ".hpp"; - scrollvalue_ = 50; -} - Notebook::View::View() : notebook_() { view_.pack2(notebook_); view_.set_position(120); @@ -40,31 +34,12 @@ void Notebook::Controller::CreateKeybindings(Keybindings::Controller Gtk::Stock::FILE)); keybindings.action_group_menu()-> - add(Gtk::Action::create("FileNewStandard", - "New empty file"), + add(Gtk::Action::create("FileNewFile", + "New file"), Gtk::AccelKey(keybindings.config_ .key_map()["new_file"]), [this]() { - is_new_file_ = true; - OnFileNewEmptyfile(); - }); - keybindings.action_group_menu()-> - add(Gtk::Action::create("FileNewCC", - "New source file"), - Gtk::AccelKey(keybindings.config_ - .key_map()["new_cc_file"]), - [this]() { - is_new_file_ = true; - OnFileNewCCFile(); - }); - keybindings.action_group_menu()-> - add(Gtk::Action::create("FileNewH", - "New header file"), - Gtk::AccelKey(keybindings.config_ - .key_map()["new_h_file"]), - [this]() { - is_new_file_ = true; - OnFileNewHeaderFile(); + OnFileNewFile(); }); keybindings.action_group_menu()-> add(Gtk::Action::create("WindowCloseTab", @@ -80,7 +55,6 @@ void Notebook::Controller::CreateKeybindings(Keybindings::Controller Gtk::AccelKey(keybindings.config_ .key_map()["edit_find"]), [this]() { - is_new_file_ = false; OnEditSearch(); // TODO(Oyvang) Zalox, Forgi)Create function OnEditFind(); }); @@ -141,33 +115,41 @@ void Notebook::Controller::CreateKeybindings(Keybindings::Controller INFO("Done Redo"); }); - entry_.view_.entry().signal_activate(). - connect( - [this]() { - if (is_new_file_) { - //OnNewPage(entry_.text()); //TODO: rewrite new file (the file needs to be created before opened with Source::Controller in order to choose the correct view implementation) - entry_.OnHideEntries(is_new_file_); - } else { - Search(true); - } - }); - entry_.button_apply().signal_clicked(). - connect( - [this]() { - //OnNewPage(entry_.text()); //TODO: rewrite new file (the file needs to be created before opened with Source::Controller in order to choose the correct view implementation) - entry_.OnHideEntries(is_new_file_); - }); - entry_.button_close().signal_clicked(). + entry.button_apply_set_filename.signal_clicked().connect([this]() { + std::string filename=entry(); + if(filename!="") { + if(project_path!="" && !boost::filesystem::path(filename).is_absolute()) + filename=project_path+"/"+filename; + boost::filesystem::path p(filename); + if(boost::filesystem::exists(p)) { + //TODO: alert user that file already exists + } + else { + std::ofstream f(p.string().c_str()); + if(f) { + OnOpenFile(boost::filesystem::canonical(p).string()); + if(project_path!="") + directories.open_folder(project_path); //TODO: Do refresh instead + } + else { + //TODO: alert user of error creating file + } + f.close(); + } + } + entry.hide(); + }); + entry.button_close.signal_clicked(). connect( [this]() { - entry_.OnHideEntries(is_new_file_); + entry.hide(); }); - entry_.button_next().signal_clicked(). + entry.button_next.signal_clicked(). connect( [this]() { Search(true); }); - entry_.button_prev().signal_clicked(). + entry.button_prev.signal_clicked(). connect( [this]() { Search(false); @@ -184,9 +166,6 @@ Notebook::Controller::~Controller() { Gtk::Paned& Notebook::Controller::view() { return view_.view(); } -Gtk::Box& Notebook::Controller::entry_view() { - return entry_.view(); -} void Notebook::Controller::OnOpenFile(std::string path) { INFO("Notebook open file"); @@ -233,28 +212,22 @@ void Notebook::Controller::OnCloseCurrentPage() { editor_vec_.erase(editor_vec_.begin()+page); } } -void Notebook::Controller::OnFileNewEmptyfile() { - entry_.OnShowSetFilenName(""); -} -void Notebook::Controller::OnFileNewCCFile() { - entry_.OnShowSetFilenName(model_.cc_extension_); -} -void Notebook::Controller::OnFileNewHeaderFile() { - entry_.OnShowSetFilenName(model_.h_extension_); +void Notebook::Controller::OnFileNewFile() { + entry.show_set_filename(); } void Notebook::Controller::OnEditCopy() { if (Pages() != 0) { - Buffer(*text_vec_.at(CurrentPage()))->copy_clipboard(refClipboard_); + CurrentTextView().get_buffer()->copy_clipboard(refClipboard_); } } void Notebook::Controller::OnEditPaste() { if (Pages() != 0) { - Buffer(*text_vec_.at(CurrentPage()))->paste_clipboard(refClipboard_); + CurrentTextView().get_buffer()->paste_clipboard(refClipboard_); } } void Notebook::Controller::OnEditCut() { if (Pages() != 0) { - Buffer(*text_vec_.at(CurrentPage()))->cut_clipboard(refClipboard_); + CurrentTextView().get_buffer()->cut_clipboard(refClipboard_); } } @@ -263,8 +236,8 @@ std::string Notebook::Controller::GetCursorWord() { int page = CurrentPage(); std::string word; Gtk::TextIter start, end; - start = Buffer(*text_vec_.at(page))->get_insert()->get_iter(); - end = Buffer(*text_vec_.at(page))->get_insert()->get_iter(); + start = CurrentTextView().get_buffer()->get_insert()->get_iter(); + end = CurrentTextView().get_buffer()->get_insert()->get_iter(); if (!end.ends_line()) { while (!end.ends_word()) { end.forward_char(); @@ -275,28 +248,28 @@ std::string Notebook::Controller::GetCursorWord() { start.backward_char(); } } - word = Buffer(*text_vec_.at(page))->get_text(start, end); + word = CurrentTextView().get_buffer()->get_text(start, end); // TODO(Oyvang) fix selected text return word; } void Notebook::Controller::OnEditSearch() { search_match_end_ = - Buffer(*text_vec_.at(CurrentPage()))->get_iter_at_offset(0); - entry_.OnShowSearch(GetCursorWord()); + CurrentTextView().get_buffer()->get_iter_at_offset(0); + entry.show_search(GetCursorWord()); } void Notebook::Controller::Search(bool forward) { INFO("Notebook search"); int page = CurrentPage(); std::string search_word; - search_word = entry_.text(); + search_word = entry(); Gtk::TextIter test; if ( !forward ) { if ( search_match_start_ == 0 || search_match_start_.get_line_offset() == 0) { - search_match_start_ = Buffer(*text_vec_.at(CurrentPage()))->end(); + search_match_start_ = CurrentTextView().get_buffer()->end(); } search_match_start_. backward_search(search_word, @@ -306,7 +279,7 @@ void Notebook::Controller::Search(bool forward) { search_match_end_); } else { if ( search_match_end_ == 0 ) { - search_match_end_ = Buffer(*text_vec_.at(CurrentPage()))->begin(); + search_match_end_ = CurrentTextView().get_buffer()->begin(); } search_match_end_. forward_search(search_word, @@ -348,11 +321,6 @@ int Notebook::Controller::CurrentPage() { return Notebook().get_current_page(); } -Glib::RefPtr -Notebook::Controller::Buffer(Source::Controller &source) { - return source.view->get_buffer(); -} - int Notebook::Controller::Pages() { return Notebook().get_n_pages(); } @@ -360,14 +328,6 @@ Gtk::Notebook& Notebook::Controller::Notebook() { return view_.notebook(); } -void Notebook::Controller::BufferChangeHandler(Glib::RefPtr - buffer) { - buffer->signal_end_user_action().connect( - [this]() { - //UpdateHistory(); - }); -} - std::string Notebook::Controller::CurrentPagePath(){ return text_vec_.at(CurrentPage())->view->file_path; } diff --git a/juci/notebook.h b/juci/notebook.h index 98af702..597ec6f 100644 --- a/juci/notebook.h +++ b/juci/notebook.h @@ -11,15 +11,9 @@ #include #include #include "clangmm.h" +#include "keybindings.h" namespace Notebook { - class Model { - public: - Model(); - std::string cc_extension_; - std::string h_extension_; - int scrollvalue_; - }; class View { public: View(); @@ -35,37 +29,29 @@ namespace Notebook { Source::Config& config, Directories::Config& dir_cfg); ~Controller(); - Glib::RefPtr Buffer(Source::Controller &source); Source::View& CurrentTextView(); int CurrentPage(); - Gtk::Box& entry_view(); Gtk::Notebook& Notebook(); std::string CurrentPagePath(); - void OnBufferChange(); - void BufferChangeHandler(Glib::RefPtr - buffer); void OnCloseCurrentPage(); std::string GetCursorWord(); void OnEditCopy(); void OnEditCut(); void OnEditPaste(); void OnEditSearch(); - void OnFileNewCCFile(); - void OnFileNewEmptyfile(); - void OnFileNewHeaderFile(); - void OnFileOpenFolder(); + void OnFileNewFile(); bool OnSaveFile(); bool OnSaveFile(std::string path); void OnDirectoryNavigation(const Gtk::TreeModel::Path& path, Gtk::TreeViewColumn* column); void OnOpenFile(std::string filename); - bool ScrollEventCallback(GdkEventScroll* scroll_event); int Pages(); Gtk::Paned& view(); void Search(bool forward); std::string OnSaveFileAs(); std::string project_path; - Directories::Controller directories; + Directories::Controller directories; //Todo: make private after creating open_directory() + Entry entry; private: void CreateKeybindings(Keybindings::Controller& keybindings); void AskToSaveDialog(); @@ -73,9 +59,6 @@ namespace Notebook { Glib::RefPtr refActionGroup; Source::Config& source_config; View view_; - Model model_; - bool is_new_file_; //TODO: Remove this - Entry::Controller entry_; std::vector > text_vec_; std::vector scrolledtext_vec_; diff --git a/juci/window.cc b/juci/window.cc index 47ef193..4c61bc0 100644 --- a/juci/window.cc +++ b/juci/window.cc @@ -111,7 +111,7 @@ Window::Window() : window_box_.pack_start(menu_.view(), Gtk::PACK_SHRINK); - window_box_.pack_start(notebook_.entry_view(), Gtk::PACK_SHRINK); + window_box_.pack_start(notebook_.entry, Gtk::PACK_SHRINK); paned_.set_position(300); paned_.pack1(notebook_.view(), true, false); paned_.pack2(terminal_.view(), true, true); From 68ac889879eaf234ab91649ad9fa10818d62abc0 Mon Sep 17 00:00:00 2001 From: eidheim Date: Thu, 25 Jun 2015 13:56:00 +0200 Subject: [PATCH 07/16] A little cleanup, mostly getting rid of warnings (Added -Wall and -Wno-reorder to compilation). --- juci/CMakeLists.txt | 2 +- juci/directories.cc | 4 +--- juci/juci.cc | 2 +- juci/notebook.cc | 15 +++++---------- juci/notebook.h | 1 - juci/source.cc | 4 ++-- juci/terminal.cc | 2 +- juci/window.cc | 12 ++++++------ 8 files changed, 17 insertions(+), 25 deletions(-) diff --git a/juci/CMakeLists.txt b/juci/CMakeLists.txt index 4dcf244..b7a518e 100644 --- a/juci/CMakeLists.txt +++ b/juci/CMakeLists.txt @@ -3,7 +3,7 @@ set(project_name juci) set(module juci_to_python_api) project (${project_name}) add_definitions(-DBOOST_LOG_DYN_LINK) -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3 -std=c++11 -pthread") +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3 -std=c++11 -pthread -Wall -Wno-reorder") set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_LIST_DIR}/cmake/Modules/") #You are of course using Homebrew: diff --git a/juci/directories.cc b/juci/directories.cc index 199e4dd..6e8ca9e 100644 --- a/juci/directories.cc +++ b/juci/directories.cc @@ -43,8 +43,6 @@ list_dirs(const boost::filesystem::path& dir_path, unsigned row_id) { boost::filesystem::directory_iterator end_itr; - unsigned dir_counter = row_id; - unsigned file_counter = 0; Gtk::TreeModel::Row child; Gtk::TreeModel::Row row; DEBUG(""); @@ -82,7 +80,7 @@ list_dirs(const boost::filesystem::path& dir_path, int Directories::Controller::count(const std::string path) { int count = 0; - for (int i = 0; i < path.size(); i++) + for (size_t i = 0; i < path.size(); i++) if (path[i] == '/') count++; return count; diff --git a/juci/juci.cc b/juci/juci.cc index 1a6ec46..1ac98c6 100644 --- a/juci/juci.cc +++ b/juci/juci.cc @@ -16,7 +16,7 @@ int Juci::on_command_line(const Glib::RefPtr &cmd) char **argv = cmd->get_arguments(argc); ctx.parse(argc, argv); if(argc>=2) { - for(size_t c=1;cbuffer()->signal_changed().connect([this]() { if(text_vec_.at(CurrentPage())->is_saved) { - std::string path=text_vec_.at(CurrentPage())->view->file_path; + std::string path=CurrentTextView().file_path; size_t pos = path.find_last_of("/\\"); std::string filename=path; if(pos!=std::string::npos) @@ -328,12 +328,8 @@ Gtk::Notebook& Notebook::Controller::Notebook() { return view_.notebook(); } -std::string Notebook::Controller::CurrentPagePath(){ - return text_vec_.at(CurrentPage())->view->file_path; -} - bool Notebook::Controller:: OnSaveFile() { - std::string path=text_vec_.at(CurrentPage())->view->file_path; + std::string path=CurrentTextView().file_path; return OnSaveFile(path); } bool Notebook::Controller:: OnSaveFile(std::string path) { @@ -343,7 +339,7 @@ bool Notebook::Controller:: OnSaveFile(std::string path) { file.open (path); file << CurrentTextView().get_buffer()->get_text(); file.close(); - text_vec_.at(CurrentPage())->view->file_path=path; + CurrentTextView().file_path=path; size_t pos = path.find_last_of("/\\"); std::string filename=path; if(pos!=std::string::npos) @@ -373,8 +369,7 @@ std::string Notebook::Controller::OnSaveFileAs(){ case(Gtk::RESPONSE_OK): { DEBUG("get_filename()"); std::string path = dialog.get_filename(); - unsigned pos = path.find_last_of("/\\"); - return path; + return path; } case(Gtk::RESPONSE_CANCEL): { break; @@ -394,7 +389,7 @@ void Notebook::Controller::AskToSaveDialog() { false, Gtk::MESSAGE_QUESTION, Gtk::BUTTONS_YES_NO); dialog.set_secondary_text( "Do you want to save: " + - text_vec_.at(CurrentPage())->view->file_path+" ?"); + CurrentTextView().file_path+" ?"); DEBUG("AskToSaveDialog: run dialog"); int result = dialog.run(); diff --git a/juci/notebook.h b/juci/notebook.h index 597ec6f..8816b86 100644 --- a/juci/notebook.h +++ b/juci/notebook.h @@ -32,7 +32,6 @@ namespace Notebook { Source::View& CurrentTextView(); int CurrentPage(); Gtk::Notebook& Notebook(); - std::string CurrentPagePath(); void OnCloseCurrentPage(); std::string GetCursorWord(); void OnEditCopy(); diff --git a/juci/source.cc b/juci/source.cc index 1993db2..fee103f 100644 --- a/juci/source.cc +++ b/juci/source.cc @@ -268,7 +268,7 @@ get_compilation_commands() { std::vector arguments; for (auto &i : cmds) { std::vector lol = i.get_command_as_args(); - for (int a = 1; a < lol.size()-4; a++) { + for (size_t a = 1; a < lol.size()-4; a++) { arguments.emplace_back(lol[a]); } } @@ -439,7 +439,7 @@ bool Source::ClangView::on_key_press(GdkEventKey* key) { string line(get_line_before_insert()); std::smatch sm; if(std::regex_match(line, sm, bracket_regex)) { - size_t line_nr=get_source_buffer()->get_insert()->get_iter().get_line(); + int line_nr=get_source_buffer()->get_insert()->get_iter().get_line(); if((line_nr+1)get_line_count()) { string next_line=get_line(line_nr+1); std::smatch sm2; diff --git a/juci/terminal.cc b/juci/terminal.cc index d6b653d..c58c97b 100644 --- a/juci/terminal.cc +++ b/juci/terminal.cc @@ -8,7 +8,7 @@ Terminal::Config::Config() { } Terminal::Config::Config(Terminal::Config& original) : run_command_(original.run_command_){ - for (auto it = 0; it Date: Thu, 25 Jun 2015 17:30:54 +0200 Subject: [PATCH 08/16] Instant file opening (can now see and write code while the file is being parsed for the first time), twice as fast initial parse+reparse, .h-files parsed as c++-files (guess this is ok). --- juci/source.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/juci/source.cc b/juci/source.cc index fee103f..cef7072 100644 --- a/juci/source.cc +++ b/juci/source.cc @@ -145,11 +145,12 @@ parse_thread_go(true), parse_thread_mapped(false), parse_thread_stop(false) { int start_offset = get_source_buffer()->begin().get_offset(); int end_offset = get_source_buffer()->end().get_offset(); - init_syntax_highlighting(get_buffer_map(), + std::map empty_buffer_map; + empty_buffer_map[file_path]=""; //for faster file opening + init_syntax_highlighting(empty_buffer_map, start_offset, end_offset, &ClangView::clang_index); - update_syntax(extract_tokens(start_offset, end_offset)); //GTK-calls must happen in main thread, so the parse_thread //sends signals to the main thread that it is to call the following functions: @@ -272,6 +273,8 @@ get_compilation_commands() { arguments.emplace_back(lol[a]); } } + if(boost::filesystem::path(file_path).extension()==".h") //TODO: temporary fix for .h-files (parse as c++) + arguments.emplace_back("-xc++"); return arguments; } From 6d7c4ffa09fdab4e292ca91e0bca0efc75c6887c Mon Sep 17 00:00:00 2001 From: eidheim Date: Fri, 26 Jun 2015 16:40:04 +0200 Subject: [PATCH 09/16] Mainly cleanup of terminal.*. Added first time clang-parsing message in terminal. --- juci/config.cc | 16 +++++----- juci/config.h | 9 ++---- juci/juci.cc | 8 ++--- juci/notebook.cc | 29 +++++++----------- juci/notebook.h | 17 +++++------ juci/source.cc | 17 +++++++---- juci/source.h | 7 +++-- juci/terminal.cc | 79 ++++++++++++++++++++++++++++++------------------ juci/terminal.h | 35 ++++++++------------- juci/window.cc | 54 ++++++++++++++++----------------- juci/window.h | 6 ++-- 11 files changed, 139 insertions(+), 138 deletions(-) diff --git a/juci/config.cc b/juci/config.cc index 6ba32b7..22418eb 100644 --- a/juci/config.cc +++ b/juci/config.cc @@ -2,7 +2,7 @@ #include "logging.h" MainConfig::MainConfig() : - keybindings_cfg_(), source_cfg() { + keybindings_cfg(), source_cfg() { INFO("Reading config file"); boost::property_tree::json_parser::read_json("config.json", cfg_); INFO("Config file read"); @@ -22,7 +22,7 @@ void MainConfig::GenerateSource() { auto visual_json = source_json.get_child("visual"); for (auto &i : visual_json) { if (i.first == "background") { - source_cfg.background = i.second.get_value(); + source_cfg.background = i.second.get_value(); } if (i.first == "show_line_numbers") { source_cfg.show_line_numbers = i.second.get_value() == "1" ? true : false; @@ -55,10 +55,10 @@ void MainConfig::GenerateTerminalCommands() { boost::property_tree::ptree compile_commands_json = source_json.get_child("compile_commands"); boost::property_tree::ptree run_commands_json = source_json.get_child("run_commands"); for (auto &i : compile_commands_json) { - terminal_cfg_.InsertCompileCommand(i.second.get_value()); + terminal_cfg.compile_commands.emplace_back(i.second.get_value()); } for (auto &i : run_commands_json) { - terminal_cfg_.SetRunCommand(i.second.get_value()); + terminal_cfg.run_command=(i.second.get_value()); //TODO: run_commands array->one run_command? } } @@ -68,11 +68,11 @@ void MainConfig::GenerateKeybindings() { std::ifstream menu_xml("menu.xml"); if (menu_xml.is_open()) { while (getline(menu_xml, line)) - keybindings_cfg_.AppendXml(line); + keybindings_cfg.AppendXml(line); } boost::property_tree::ptree keys_json = cfg_.get_child("keybindings"); for (auto &i : keys_json) - keybindings_cfg_.key_map()[i.first] = i.second.get_value(); + keybindings_cfg.key_map()[i.first] = i.second.get_value(); DEBUG("Keybindings fetched"); } @@ -82,8 +82,8 @@ void MainConfig::GenerateDirectoryFilter() { boost::property_tree::ptree ignore_json = dir_json.get_child("ignore"); boost::property_tree::ptree except_json = dir_json.get_child("exceptions"); for ( auto &i : except_json ) - dir_cfg_.AddException(i.second.get_value()); + dir_cfg.AddException(i.second.get_value()); for ( auto &i : ignore_json ) - dir_cfg_.AddIgnore(i.second.get_value()); + dir_cfg.AddIgnore(i.second.get_value()); DEBUG("Directory filter fetched"); } diff --git a/juci/config.h b/juci/config.h index 309e297..bbe03cf 100644 --- a/juci/config.h +++ b/juci/config.h @@ -12,10 +12,10 @@ class MainConfig { public: Source::Config source_cfg; + Terminal::Config terminal_cfg; + Keybindings::Config keybindings_cfg; + Directories::Config dir_cfg; MainConfig(); - Keybindings::Config& keybindings_cfg() { return keybindings_cfg_; } - Directories::Config& dir_cfg() { return dir_cfg_; } - Terminal::Config& terminal_cfg() { return terminal_cfg_; } void PrintMenu(); void GenerateSource(); void GenerateKeybindings(); @@ -24,8 +24,5 @@ public: private: boost::property_tree::ptree cfg_; boost::property_tree::ptree key_tree_; - Keybindings::Config keybindings_cfg_; - Directories::Config dir_cfg_; - Terminal::Config terminal_cfg_; }; #endif diff --git a/juci/juci.cc b/juci/juci.cc index 1ac98c6..f19e7da 100644 --- a/juci/juci.cc +++ b/juci/juci.cc @@ -35,12 +35,12 @@ void Juci::on_activate() { add_window(*window); window->show(); if(directory!="") { - //TODO: use the following instead, window->notebook_.open_directory(directory); - window->notebook_.project_path=directory; - window->notebook_.directories.open_folder(directory); + //TODO: use the following instead, window->notebook.open_directory(directory); + window->notebook.project_path=directory; + window->notebook.directories.open_folder(directory); } for(auto &f: files) - window->notebook_.OnOpenFile(f); + window->notebook.OnOpenFile(f); } int main(int argc, char *argv[]) { diff --git a/juci/notebook.cc b/juci/notebook.cc index f916539..bc89429 100644 --- a/juci/notebook.cc +++ b/juci/notebook.cc @@ -2,21 +2,21 @@ #include "notebook.h" #include "logging.h" -Notebook::View::View() : notebook_() { - view_.pack2(notebook_); - view_.set_position(120); +Notebook::View::View() { + pack2(notebook); + set_position(120); } -Notebook::Controller::Controller(Gtk::Window* window, - Keybindings::Controller& keybindings, +Notebook::Controller::Controller(Keybindings::Controller& keybindings, + Terminal::Controller& terminal, Source::Config& source_cfg, Directories::Config& dir_cfg) : + terminal(terminal), directories(dir_cfg), source_config(source_cfg) { INFO("Create notebook"); - window_ = window; refClipboard_ = Gtk::Clipboard::get(); - view().pack1(directories.widget(), true, true); + view.pack1(directories.widget(), true, true); CreateKeybindings(keybindings); INFO("Notebook Controller Success"); } // Constructor @@ -163,14 +163,10 @@ Notebook::Controller::~Controller() { for (auto &i : scrolledtext_vec_) delete i; } -Gtk::Paned& Notebook::Controller::view() { - return view_.view(); -} - void Notebook::Controller::OnOpenFile(std::string path) { INFO("Notebook open file"); INFO("Notebook create page"); - text_vec_.emplace_back(new Source::Controller(source_config, path, project_path)); + text_vec_.emplace_back(new Source::Controller(source_config, path, project_path, terminal)); scrolledtext_vec_.push_back(new Gtk::ScrolledWindow()); editor_vec_.push_back(new Gtk::HBox()); scrolledtext_vec_.back()->add(*text_vec_.back()->view); @@ -233,7 +229,6 @@ void Notebook::Controller::OnEditCut() { std::string Notebook::Controller::GetCursorWord() { INFO("Notebook get cursor word"); - int page = CurrentPage(); std::string word; Gtk::TextIter start, end; start = CurrentTextView().get_buffer()->get_insert()->get_iter(); @@ -261,7 +256,6 @@ void Notebook::Controller::OnEditSearch() { void Notebook::Controller::Search(bool forward) { INFO("Notebook search"); - int page = CurrentPage(); std::string search_word; search_word = entry(); Gtk::TextIter test; @@ -325,7 +319,7 @@ int Notebook::Controller::Pages() { return Notebook().get_n_pages(); } Gtk::Notebook& Notebook::Controller::Notebook() { - return view_.notebook(); + return view.notebook; } bool Notebook::Controller:: OnSaveFile() { @@ -354,10 +348,9 @@ bool Notebook::Controller:: OnSaveFile(std::string path) { std::string Notebook::Controller::OnSaveFileAs(){ INFO("Notebook save as"); - Gtk::FileChooserDialog dialog("Please choose a file", + Gtk::FileChooserDialog dialog((Gtk::Window&)(*view.get_toplevel()), "Please choose a file", Gtk::FILE_CHOOSER_ACTION_SAVE); DEBUG("SET TRANSISTEN FPR"); - dialog.set_transient_for(*window_); dialog.set_position(Gtk::WindowPosition::WIN_POS_CENTER_ALWAYS); dialog.add_button("_Cancel", Gtk::RESPONSE_CANCEL); dialog.add_button("_Save", Gtk::RESPONSE_OK); @@ -385,7 +378,7 @@ std::string Notebook::Controller::OnSaveFileAs(){ void Notebook::Controller::AskToSaveDialog() { INFO("AskToSaveDialog"); DEBUG("AskToSaveDialog: Finding file path"); - Gtk::MessageDialog dialog(*window_, "Save file!", + Gtk::MessageDialog dialog((Gtk::Window&)(*view.get_toplevel()), "Save file!", false, Gtk::MESSAGE_QUESTION, Gtk::BUTTONS_YES_NO); dialog.set_secondary_text( "Do you want to save: " + diff --git a/juci/notebook.h b/juci/notebook.h index 8816b86..4a7cc2e 100644 --- a/juci/notebook.h +++ b/juci/notebook.h @@ -12,20 +12,18 @@ #include #include "clangmm.h" #include "keybindings.h" +#include "terminal.h" namespace Notebook { - class View { + class View : public Gtk::Paned { public: View(); - Gtk::Paned& view() {return view_;} - Gtk::Notebook& notebook() {return notebook_; } - protected: - Gtk::Paned view_; - Gtk::Notebook notebook_; + Gtk::Notebook notebook; }; class Controller { public: - Controller(Gtk::Window* window, Keybindings::Controller& keybindings, + Controller(Keybindings::Controller& keybindings, + Terminal::Controller& terminal, Source::Config& config, Directories::Config& dir_cfg); ~Controller(); @@ -45,8 +43,8 @@ namespace Notebook { Gtk::TreeViewColumn* column); void OnOpenFile(std::string filename); int Pages(); - Gtk::Paned& view(); void Search(bool forward); + View view; std::string OnSaveFileAs(); std::string project_path; Directories::Controller directories; //Todo: make private after creating open_directory() @@ -56,8 +54,8 @@ namespace Notebook { void AskToSaveDialog(); Glib::RefPtr m_refBuilder; Glib::RefPtr refActionGroup; + Terminal::Controller& terminal; Source::Config& source_config; - View view_; std::vector > text_vec_; std::vector scrolledtext_vec_; @@ -66,7 +64,6 @@ namespace Notebook { Gtk::TextIter search_match_end_; Gtk::TextIter search_match_start_; Glib::RefPtr refClipboard_; - Gtk::Window* window_; }; // class controller } // namespace Notebook #endif // JUCI_NOTEBOOK_H_ diff --git a/juci/source.cc b/juci/source.cc index cef7072..8848c72 100644 --- a/juci/source.cc +++ b/juci/source.cc @@ -134,8 +134,8 @@ bool Source::View::on_key_press(GdkEventKey* key) { ////////////////// clang::Index Source::ClangView::clang_index(0, 1); -Source::ClangView::ClangView(const Source::Config& config, const std::string& file_path, const std::string& project_path): -Source::View(config, file_path, project_path), +Source::ClangView::ClangView(const Source::Config& config, const std::string& file_path, const std::string& project_path, Terminal::Controller& terminal): +Source::View(config, file_path, project_path), terminal(terminal), parse_thread_go(true), parse_thread_mapped(false), parse_thread_stop(false) { override_font(Pango::FontDescription(config.font)); override_background_color(Gdk::RGBA(config.background)); @@ -163,10 +163,15 @@ parse_thread_go(true), parse_thread_mapped(false), parse_thread_stop(false) { parse_thread_go=true; }); - parse_done.connect([this](){ + auto first_time_parse_done=this->terminal.PrintMessage("Parsing "+file_path, "finished"); + parse_done.connect([this, first_time_parse_done](){ if(parse_thread_mapped) { INFO("Updating syntax"); update_syntax(extract_tokens(0, get_source_buffer()->get_text().size())); + if(first_time_parse) { + first_time_parse_done(); + first_time_parse=false; + } INFO("Syntax updated"); } else { @@ -521,12 +526,12 @@ bool Source::ClangView::on_key_press(GdkEventKey* key) { // Source::Controller::Controller() // Constructor for Controller Source::Controller::Controller(const Source::Config &config, - const std::string& file_path, std::string project_path) { + const std::string& file_path, std::string project_path, Terminal::Controller& terminal) { if(project_path=="") { project_path=boost::filesystem::path(file_path).parent_path().string(); } if (config.legal_extension(file_path.substr(file_path.find_last_of(".") + 1))) - view=std::unique_ptr(new ClangView(config, file_path, project_path)); + view=std::unique_ptr(new ClangView(config, file_path, project_path, terminal)); else view=std::unique_ptr(new GenericView(config, file_path, project_path)); INFO("Source Controller with childs constructed"); @@ -534,4 +539,4 @@ Source::Controller::Controller(const Source::Config &config, Glib::RefPtr Source::Controller::buffer() { return view->get_source_buffer(); -} \ No newline at end of file +} diff --git a/juci/source.h b/juci/source.h index dce111d..a09dad6 100644 --- a/juci/source.h +++ b/juci/source.h @@ -10,6 +10,7 @@ #include #include #include "gtksourceviewmm.h" +#include "terminal.h" namespace Source { class Config { @@ -81,7 +82,7 @@ namespace Source { class ClangView : public View { public: - ClangView(const Source::Config& config, const std::string& file_path, const std::string& project_path); + ClangView(const Source::Config& config, const std::string& file_path, const std::string& project_path, Terminal::Controller& terminal); ~ClangView(); // inits the syntax highligthing on file open void init_syntax_highlighting(const std::map @@ -107,6 +108,8 @@ namespace Source { std::vector get_compilation_commands(); bool on_key_press(GdkEventKey* key); bool on_key_release(GdkEventKey* key); + Terminal::Controller& terminal; + bool first_time_parse=true; Glib::Dispatcher parse_done; Glib::Dispatcher parse_start; @@ -121,7 +124,7 @@ namespace Source { class Controller { public: Controller(const Source::Config &config, - const std::string& file_path, std::string project_path); + const std::string& file_path, std::string project_path, Terminal::Controller& terminal); Glib::RefPtr buffer(); bool is_saved = true; diff --git a/juci/terminal.cc b/juci/terminal.cc index c58c97b..3c322a8 100644 --- a/juci/terminal.cc +++ b/juci/terminal.cc @@ -1,36 +1,18 @@ #include "terminal.h" #include #include +#include #include "logging.h" - -Terminal::Config::Config() { -} -Terminal::Config::Config(Terminal::Config& original) : - run_command_(original.run_command_){ - for (size_t it = 0; itset_text(""); + view.text_view.get_buffer()->set_text(""); DEBUG("Terminal: Compile: running cmake command"); - std::vector commands = config().compile_commands(); + std::vector commands = config.compile_commands; for (size_t it = 0; it < commands.size(); ++it) { ExecuteCommand(commands.at(it), "r"); @@ -60,21 +42,58 @@ void Terminal::Controller::Run(std::string executable) { PrintMessage("juCi++ execute: " + executable + "\n"); DEBUG("Terminal: Compile: running run command: "); DEBUG_VAR(executable); - ExecuteCommand("cd "+config().run_command() + "; ./"+executable, "r"); + ExecuteCommand("cd "+config.run_command + "; ./"+executable, "r"); PrintMessage("\n"); } -void Terminal::Controller::PrintMessage(std::string message){ +int Terminal::Controller::PrintMessage(std::string message){ INFO("Terminal: PrintMessage"); - Terminal().get_buffer()-> - insert(Terminal().get_buffer()-> end(),"> "+message); + view.text_view.get_buffer()->insert(view.text_view.get_buffer()->end(), "> "+message); + auto mark_end=view.text_view.get_buffer()->create_mark(view.text_view.get_buffer()->end()); + view.text_view.scroll_to(mark_end); + return mark_end->get_iter().get_line(); +} + +void Terminal::Controller::PrintMessage(int line_nr, std::string message){ + INFO("Terminal: PrintMessage at line " << line_nr); + auto iter=view.text_view.get_buffer()->get_iter_at_line(line_nr); + while(!iter.ends_line()) + iter++; + view.text_view.get_buffer()->insert(iter, message); } +std::function Terminal::Controller::PrintMessage(std::string start_msg, std::string done_msg) { + int line_nr=PrintMessage(start_msg+"...\n"); + + std::shared_ptr > stop(new std::atomic(false)); + std::shared_ptr waiting_print(new Glib::Dispatcher()); + waiting_print->connect([this, line_nr](){ + PrintMessage(line_nr-1, "."); + }); + + std::shared_ptr wait_thread(new std::thread([this, stop, waiting_print](){ + size_t c=0; + while(!*stop) { + if(c%100==0) + (*waiting_print)(); + std::this_thread::sleep_for(std::chrono::milliseconds(10)); + c++; + } + })); + + std::function done=[this, line_nr, stop, done_msg, waiting_print, wait_thread](){ + *stop=true; + PrintMessage(line_nr-1, done_msg); + if(wait_thread->joinable()) + wait_thread->join(); //waiting_print has to be destroyed in main thread + }; + return done; +} bool Terminal::Controller::ExistInConsole(std::string string) { INFO("Terminal: ExistInConsole"); DEBUG("Terminal: PrintMessage: finding string in buffer"); - double pos = Terminal().get_buffer()-> + double pos = view.text_view.get_buffer()-> get_text().find(string); if (pos == std::string::npos) return false; return true; diff --git a/juci/terminal.h b/juci/terminal.h index a07d5a5..12fecc1 100644 --- a/juci/terminal.h +++ b/juci/terminal.h @@ -2,6 +2,7 @@ #define JUCI_TERMINAL_H_ #include +#include #include "gtkmm.h" #include @@ -9,44 +10,32 @@ namespace Terminal { class Config { public: - Config (); - Config(Terminal::Config& original); - std::vector& compile_commands() { return compile_commands_; } - void InsertCompileCommand(std::string command); - std::string& run_command() { return run_command_; } - void SetRunCommand(std::string command); - private: - std::vector compile_commands_; - std::string run_command_; + std::vector compile_commands; + std::string run_command; }; - class View { + class View : public Gtk::HBox { public: - View(); - Gtk::HBox& view() {return view_;} - Gtk::TextView& textview() {return textview_;} - private: - Gtk::HBox view_; - Gtk::TextView textview_; - Gtk::ScrolledWindow scrolledwindow_; + View(); + Gtk::TextView text_view; + Gtk::ScrolledWindow scrolled_window; }; // class view class Controller { public: Controller(Terminal::Config& cfg); - Gtk::HBox& view() {return view_.view();} - Gtk::TextView& Terminal(){return view_.textview();} void SetFolderCommand(boost::filesystem::path CMake_path); void Run(std::string executable); void Compile(); - Terminal::Config& config() { return config_; } - void PrintMessage(std::string message); + int PrintMessage(std::string message); + void PrintMessage(int line_nr, std::string message); + std::function PrintMessage(std::string start_msg, std::string stop_msg); + Terminal::View view; private: - Terminal::Config config_; + Terminal::Config& config; void ExecuteCommand(std::string command, std::string mode); bool OnButtonRealeaseEvent(GdkEventKey* key); bool ExistInConsole(std::string string); - Terminal::View view_; std::string folder_command_; std::string path_; const std::string cmake_sucsess = "Build files have been written to:"; diff --git a/juci/window.cc b/juci/window.cc index fcbf1d1..c7c1340 100644 --- a/juci/window.cc +++ b/juci/window.cc @@ -4,13 +4,13 @@ Window::Window() : window_box_(Gtk::ORIENTATION_VERTICAL), main_config_(), - keybindings_(main_config_.keybindings_cfg()), - terminal_(main_config_.terminal_cfg()), - notebook_(this,keybindings(), + keybindings_(main_config_.keybindings_cfg), + terminal(main_config_.terminal_cfg), + notebook(keybindings(), terminal, main_config_.source_cfg, - main_config_.dir_cfg()), + main_config_.dir_cfg), menu_(keybindings()), - api_(menu_, notebook_) { + api_(menu_, notebook) { INFO("Create Window"); set_title("juCi++"); set_default_size(600, 400); @@ -66,16 +66,16 @@ Window::Window() : SaveFile(); if (running.try_lock()) { std::thread execute([=]() { - std::string path = notebook_.CurrentTextView().file_path; + std::string path = notebook.CurrentTextView().file_path; size_t pos = path.find_last_of("/\\"); if(pos != std::string::npos) { path.erase(path.begin()+pos,path.end()); - terminal_.SetFolderCommand(path); + terminal.SetFolderCommand(path); } - terminal_.Compile(); - std::string executable = notebook_.directories. + terminal.Compile(); + std::string executable = notebook.directories. GetCmakeVarValue(path,"add_executable"); - terminal_.Run(executable); + terminal.Run(executable); running.unlock(); }); execute.detach(); @@ -92,13 +92,13 @@ Window::Window() : SaveFile(); if (running.try_lock()) { std::thread execute([=]() { - std::string path = notebook_.CurrentTextView().file_path; + std::string path = notebook.CurrentTextView().file_path; size_t pos = path.find_last_of("/\\"); if(pos != std::string::npos){ path.erase(path.begin()+pos,path.end()); - terminal_.SetFolderCommand(path); + terminal.SetFolderCommand(path); } - terminal_.Compile(); + terminal.Compile(); running.unlock(); }); execute.detach(); @@ -111,10 +111,10 @@ Window::Window() : window_box_.pack_start(menu_.view(), Gtk::PACK_SHRINK); - window_box_.pack_start(notebook_.entry, Gtk::PACK_SHRINK); + window_box_.pack_start(notebook.entry, Gtk::PACK_SHRINK); paned_.set_position(300); - paned_.pack1(notebook_.view(), true, false); - paned_.pack2(terminal_.view(), true, true); + paned_.pack1(notebook.view, true, false); + paned_.pack2(terminal.view, true, true); window_box_.pack_end(paned_); show_all_children(); INFO("Window created"); @@ -139,8 +139,8 @@ void Window::OnFileOpenFolder() { case(Gtk::RESPONSE_OK): { std::string project_path=dialog.get_filename(); - notebook_.project_path=project_path; - notebook_.directories.open_folder(project_path); + notebook.project_path=project_path; + notebook.directories.open_folder(project_path); break; } case(Gtk::RESPONSE_CANCEL): @@ -188,7 +188,7 @@ void Window::OnOpenFile() { switch (result) { case(Gtk::RESPONSE_OK): { std::string path = dialog.get_filename(); - notebook_.OnOpenFile(path); + notebook.OnOpenFile(path); break; } case(Gtk::RESPONSE_CANCEL): { @@ -201,20 +201,20 @@ void Window::OnOpenFile() { } bool Window::SaveFile() { - if(notebook_.OnSaveFile()) { - terminal_.PrintMessage("File saved to: " + - notebook_.CurrentTextView().file_path+"\n"); + if(notebook.OnSaveFile()) { + terminal.PrintMessage("File saved to: " + + notebook.CurrentTextView().file_path+"\n"); return true; } - terminal_.PrintMessage("File not saved"); + terminal.PrintMessage("File not saved"); return false; } bool Window::SaveFileAs() { - if(notebook_.OnSaveFile(notebook_.OnSaveFileAs())){ - terminal_.PrintMessage("File saved to: " + - notebook_.CurrentTextView().file_path+"\n"); + if(notebook.OnSaveFile(notebook.OnSaveFileAs())){ + terminal.PrintMessage("File saved to: " + + notebook.CurrentTextView().file_path+"\n"); return true; } - terminal_.PrintMessage("File not saved"); + terminal.PrintMessage("File not saved"); return false; } diff --git a/juci/window.h b/juci/window.h index 344a51e..dd63e6a 100644 --- a/juci/window.h +++ b/juci/window.h @@ -15,13 +15,11 @@ public: Gtk::Box window_box_; virtual ~Window() { } - -//private: MainConfig main_config_; Keybindings::Controller keybindings_; Menu::Controller menu_; - Notebook::Controller notebook_; - Terminal::Controller terminal_; + Notebook::Controller notebook; + Terminal::Controller terminal; PluginApi api_; Keybindings::Controller& keybindings() { return keybindings_; } From 5c21533435fc6e7b89a1c0df2873ed23723a6438 Mon Sep 17 00:00:00 2001 From: eidheim Date: Fri, 26 Jun 2015 17:08:26 +0200 Subject: [PATCH 10/16] Fixed a crash when tab was closed before the parsing was done. Juci sometimes crashes when quitting, maybe while parsing for the first time. Will look into it. --- juci/source.cc | 7 +++++-- juci/source.h | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/juci/source.cc b/juci/source.cc index 8848c72..d053cac 100644 --- a/juci/source.cc +++ b/juci/source.cc @@ -163,13 +163,14 @@ parse_thread_go(true), parse_thread_mapped(false), parse_thread_stop(false) { parse_thread_go=true; }); - auto first_time_parse_done=this->terminal.PrintMessage("Parsing "+file_path, "finished"); - parse_done.connect([this, first_time_parse_done](){ + first_time_parse_done=this->terminal.PrintMessage("Parsing "+file_path, "finished"); + parse_done.connect([this](){ if(parse_thread_mapped) { INFO("Updating syntax"); update_syntax(extract_tokens(0, get_source_buffer()->get_text().size())); if(first_time_parse) { first_time_parse_done(); + first_time_parse_done=[](){}; first_time_parse=false; } INFO("Syntax updated"); @@ -214,6 +215,8 @@ Source::ClangView::~ClangView() { parse_thread.join(); parsing_mutex.lock(); //Be sure not to destroy while still parsing with libclang parsing_mutex.unlock(); + if(first_time_parse) + first_time_parse_done(); //This function must be run if it is not run already } void Source::ClangView:: diff --git a/juci/source.h b/juci/source.h index a09dad6..3c0a71d 100644 --- a/juci/source.h +++ b/juci/source.h @@ -110,6 +110,7 @@ namespace Source { bool on_key_release(GdkEventKey* key); Terminal::Controller& terminal; bool first_time_parse=true; + std::function first_time_parse_done; Glib::Dispatcher parse_done; Glib::Dispatcher parse_start; From dd862698375faf0c0824f90de21c99a53ec0fb58 Mon Sep 17 00:00:00 2001 From: eidheim Date: Fri, 26 Jun 2015 17:16:18 +0200 Subject: [PATCH 11/16] See TODO. Should fix this before merge. --- juci/terminal.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/juci/terminal.cc b/juci/terminal.cc index 3c322a8..c1ba7d3 100644 --- a/juci/terminal.cc +++ b/juci/terminal.cc @@ -62,6 +62,7 @@ void Terminal::Controller::PrintMessage(int line_nr, std::string message){ view.text_view.get_buffer()->insert(iter, message); } +//TODO: this was way too dirty, return a class instead. std::function Terminal::Controller::PrintMessage(std::string start_msg, std::string done_msg) { int line_nr=PrintMessage(start_msg+"...\n"); From c1714c5b35e58f9ee19422f80850f424dbd6104b Mon Sep 17 00:00:00 2001 From: eidheim Date: Fri, 26 Jun 2015 21:32:11 +0200 Subject: [PATCH 12/16] Fixed crash from last commit. Moved the progress messages to a seperate class, and added cancel message. --- juci/notebook.h | 2 +- juci/source.cc | 12 +++---- juci/source.h | 3 +- juci/terminal.cc | 88 ++++++++++++++++++++++++++++-------------------- juci/terminal.h | 28 ++++++++++++--- juci/window.cc | 10 +++--- 6 files changed, 87 insertions(+), 56 deletions(-) diff --git a/juci/notebook.h b/juci/notebook.h index 4a7cc2e..6c96f5e 100644 --- a/juci/notebook.h +++ b/juci/notebook.h @@ -49,6 +49,7 @@ namespace Notebook { std::string project_path; Directories::Controller directories; //Todo: make private after creating open_directory() Entry entry; + std::vector > text_vec_; private: void CreateKeybindings(Keybindings::Controller& keybindings); void AskToSaveDialog(); @@ -57,7 +58,6 @@ namespace Notebook { Terminal::Controller& terminal; Source::Config& source_config; - std::vector > text_vec_; std::vector scrolledtext_vec_; std::vector editor_vec_; std::list listTargets_; diff --git a/juci/source.cc b/juci/source.cc index d053cac..cc6dbc6 100644 --- a/juci/source.cc +++ b/juci/source.cc @@ -163,16 +163,12 @@ parse_thread_go(true), parse_thread_mapped(false), parse_thread_stop(false) { parse_thread_go=true; }); - first_time_parse_done=this->terminal.PrintMessage("Parsing "+file_path, "finished"); + parsing_in_progress=this->terminal.print_in_progress("Parsing "+file_path); parse_done.connect([this](){ if(parse_thread_mapped) { INFO("Updating syntax"); update_syntax(extract_tokens(0, get_source_buffer()->get_text().size())); - if(first_time_parse) { - first_time_parse_done(); - first_time_parse_done=[](){}; - first_time_parse=false; - } + parsing_in_progress->done("done"); INFO("Syntax updated"); } else { @@ -210,13 +206,13 @@ parse_thread_go(true), parse_thread_mapped(false), parse_thread_stop(false) { } Source::ClangView::~ClangView() { + //TODO: Is it possible to stop the clang-process in progress? + parsing_in_progress->cancel("canceled"); parse_thread_stop=true; if(parse_thread.joinable()) parse_thread.join(); parsing_mutex.lock(); //Be sure not to destroy while still parsing with libclang parsing_mutex.unlock(); - if(first_time_parse) - first_time_parse_done(); //This function must be run if it is not run already } void Source::ClangView:: diff --git a/juci/source.h b/juci/source.h index 3c0a71d..7653ba1 100644 --- a/juci/source.h +++ b/juci/source.h @@ -109,8 +109,7 @@ namespace Source { bool on_key_press(GdkEventKey* key); bool on_key_release(GdkEventKey* key); Terminal::Controller& terminal; - bool first_time_parse=true; - std::function first_time_parse_done; + std::shared_ptr parsing_in_progress; Glib::Dispatcher parse_done; Glib::Dispatcher parse_start; diff --git a/juci/terminal.cc b/juci/terminal.cc index c1ba7d3..02b9933 100644 --- a/juci/terminal.cc +++ b/juci/terminal.cc @@ -1,16 +1,54 @@ #include "terminal.h" #include -#include -#include #include "logging.h" +Terminal::InProgress::InProgress(Controller& terminal, const std::string& start_msg): + start_msg(start_msg), terminal(terminal), stop(false) { + waiting_print.connect([this](){ + this->terminal.print(line_nr-1, "."); + }); + start(); +} + +Terminal::InProgress::~InProgress() { + stop=true; + if(wait_thread.joinable()) + wait_thread.join(); +} + +void Terminal::InProgress::start() { + line_nr=this->terminal.print(start_msg+"...\n"); + wait_thread=std::thread([this](){ + size_t c=0; + while(!stop) { + if(c%100==0) + waiting_print(); + std::this_thread::sleep_for(std::chrono::milliseconds(10)); + c++; + } + }); +} + +void Terminal::InProgress::done(const std::string& msg) { + if(!stop) { + stop=true; + this->terminal.print(line_nr-1, msg); + } +} + +void Terminal::InProgress::cancel(const std::string& msg) { + if(!stop) { + stop=true; + this->terminal.print(line_nr-1, msg); + } +} + Terminal::View::View(){ text_view.set_editable(false); scrolled_window.add(text_view); add(scrolled_window); } - Terminal::Controller::Controller(Terminal::Config& cfg) : config(cfg) { folder_command_ = ""; @@ -33,20 +71,20 @@ void Terminal::Controller::Compile(){ ExecuteCommand(commands.at(it), "r"); } - PrintMessage("\n"); + print("\n"); DEBUG("Terminal: Compile: compile done"); } void Terminal::Controller::Run(std::string executable) { INFO("Terminal: Run"); - PrintMessage("juCi++ execute: " + executable + "\n"); + print("juCi++ execute: " + executable + "\n"); DEBUG("Terminal: Compile: running run command: "); DEBUG_VAR(executable); ExecuteCommand("cd "+config.run_command + "; ./"+executable, "r"); - PrintMessage("\n"); + print("\n"); } -int Terminal::Controller::PrintMessage(std::string message){ +int Terminal::Controller::print(std::string message){ INFO("Terminal: PrintMessage"); view.text_view.get_buffer()->insert(view.text_view.get_buffer()->end(), "> "+message); auto mark_end=view.text_view.get_buffer()->create_mark(view.text_view.get_buffer()->end()); @@ -54,7 +92,7 @@ int Terminal::Controller::PrintMessage(std::string message){ return mark_end->get_iter().get_line(); } -void Terminal::Controller::PrintMessage(int line_nr, std::string message){ +void Terminal::Controller::print(int line_nr, std::string message){ INFO("Terminal: PrintMessage at line " << line_nr); auto iter=view.text_view.get_buffer()->get_iter_at_line(line_nr); while(!iter.ends_line()) @@ -62,33 +100,9 @@ void Terminal::Controller::PrintMessage(int line_nr, std::string message){ view.text_view.get_buffer()->insert(iter, message); } -//TODO: this was way too dirty, return a class instead. -std::function Terminal::Controller::PrintMessage(std::string start_msg, std::string done_msg) { - int line_nr=PrintMessage(start_msg+"...\n"); - - std::shared_ptr > stop(new std::atomic(false)); - std::shared_ptr waiting_print(new Glib::Dispatcher()); - waiting_print->connect([this, line_nr](){ - PrintMessage(line_nr-1, "."); - }); - - std::shared_ptr wait_thread(new std::thread([this, stop, waiting_print](){ - size_t c=0; - while(!*stop) { - if(c%100==0) - (*waiting_print)(); - std::this_thread::sleep_for(std::chrono::milliseconds(10)); - c++; - } - })); - - std::function done=[this, line_nr, stop, done_msg, waiting_print, wait_thread](){ - *stop=true; - PrintMessage(line_nr-1, done_msg); - if(wait_thread->joinable()) - wait_thread->join(); //waiting_print has to be destroyed in main thread - }; - return done; +std::shared_ptr Terminal::Controller::print_in_progress(std::string start_msg) { + std::shared_ptr in_progress=std::shared_ptr(new Terminal::InProgress(*this, start_msg)); + return in_progress; } bool Terminal::Controller::ExistInConsole(std::string string) { @@ -108,11 +122,11 @@ void Terminal::Controller::ExecuteCommand(std::string command, std::string mode) std::cout << command << std::endl; p = popen(command.c_str(), mode.c_str()); if (p == NULL) { - PrintMessage("juCi++ ERROR: Failed to run command" + command + "\n"); + print("juCi++ ERROR: Failed to run command" + command + "\n"); }else { char buffer[1028]; while (fgets(buffer, 1028, p) != NULL) { - PrintMessage(buffer); + print(buffer); } pclose(p); } diff --git a/juci/terminal.h b/juci/terminal.h index 12fecc1..00e2fba 100644 --- a/juci/terminal.h +++ b/juci/terminal.h @@ -5,9 +5,10 @@ #include #include "gtkmm.h" #include +#include +#include namespace Terminal { - class Config { public: std::vector compile_commands; @@ -21,15 +22,34 @@ namespace Terminal { Gtk::ScrolledWindow scrolled_window; }; // class view + class Controller; + + //Temporary solution for displaying functions in progress, and when they are done. + class InProgress { + public: + InProgress(Controller& terminal, const std::string& start_msg); + ~InProgress(); + void done(const std::string& msg); + void cancel(const std::string& msg); + private: + void start(); + Controller& terminal; + std::string start_msg; + int line_nr; + std::atomic stop; + Glib::Dispatcher waiting_print; + std::thread wait_thread; + }; + class Controller { public: Controller(Terminal::Config& cfg); void SetFolderCommand(boost::filesystem::path CMake_path); void Run(std::string executable); void Compile(); - int PrintMessage(std::string message); - void PrintMessage(int line_nr, std::string message); - std::function PrintMessage(std::string start_msg, std::string stop_msg); + int print(std::string message); + void print(int line_nr, std::string message); + std::shared_ptr print_in_progress(std::string start_msg); Terminal::View view; private: Terminal::Config& config; diff --git a/juci/window.cc b/juci/window.cc index c7c1340..6c54878 100644 --- a/juci/window.cc +++ b/juci/window.cc @@ -121,6 +121,8 @@ Window::Window() : } // Window constructor void Window::OnWindowHide() { + for(size_t c=0;c Date: Fri, 26 Jun 2015 21:37:52 +0200 Subject: [PATCH 13/16] Small cleanup. --- juci/terminal.cc | 9 ++++----- juci/terminal.h | 3 +-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/juci/terminal.cc b/juci/terminal.cc index 02b9933..cce7496 100644 --- a/juci/terminal.cc +++ b/juci/terminal.cc @@ -2,12 +2,11 @@ #include #include "logging.h" -Terminal::InProgress::InProgress(Controller& terminal, const std::string& start_msg): - start_msg(start_msg), terminal(terminal), stop(false) { +Terminal::InProgress::InProgress(Controller& terminal, const std::string& start_msg): terminal(terminal), stop(false) { waiting_print.connect([this](){ this->terminal.print(line_nr-1, "."); }); - start(); + start(start_msg); } Terminal::InProgress::~InProgress() { @@ -16,8 +15,8 @@ Terminal::InProgress::~InProgress() { wait_thread.join(); } -void Terminal::InProgress::start() { - line_nr=this->terminal.print(start_msg+"...\n"); +void Terminal::InProgress::start(const std::string& msg) { + line_nr=this->terminal.print(msg+"...\n"); wait_thread=std::thread([this](){ size_t c=0; while(!stop) { diff --git a/juci/terminal.h b/juci/terminal.h index 00e2fba..317e43e 100644 --- a/juci/terminal.h +++ b/juci/terminal.h @@ -32,9 +32,8 @@ namespace Terminal { void done(const std::string& msg); void cancel(const std::string& msg); private: - void start(); + void start(const std::string& msg); Controller& terminal; - std::string start_msg; int line_nr; std::atomic stop; Glib::Dispatcher waiting_print; From 7d9403f1a234ab59981fe78ca259f732a16c3d4f Mon Sep 17 00:00:00 2001 From: eidheim Date: Sat, 27 Jun 2015 00:09:04 +0200 Subject: [PATCH 14/16] Better autocompletion, working now even inside expressions. --- juci/source.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/juci/source.cc b/juci/source.cc index cc6dbc6..4bf3e99 100644 --- a/juci/source.cc +++ b/juci/source.cc @@ -244,13 +244,15 @@ std::vector Source::ClangView:: get_autocomplete_suggestions(int line_number, int column) { INFO("Getting auto complete suggestions"); std::vector suggestions; - auto buffer_map=get_buffer_map(); + std::map buffer_map; + buffer_map[file_path]=get_source_buffer()->get_text(get_source_buffer()->begin(), get_source_buffer()->get_insert()->get_iter()); + buffer_map[file_path]+="\n"; parsing_mutex.lock(); clang::CodeCompleteResults results(tu_.get(), file_path, buffer_map, line_number, - column); + column-1); for (int i = 0; i < results.size(); i++) { const vector chunks_ = results.get(i).get_chunks(); std::vector chunks; From 18c1f262203eec9726848dc6e1f6ee1980a9e46b Mon Sep 17 00:00:00 2001 From: eidheim Date: Sun, 28 Jun 2015 13:06:36 +0200 Subject: [PATCH 15/16] Added initial syntax highlighting when opening clang-files without #include. --- juci/source.cc | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/juci/source.cc b/juci/source.cc index 4bf3e99..7fc9cf1 100644 --- a/juci/source.cc +++ b/juci/source.cc @@ -132,7 +132,7 @@ bool Source::View::on_key_press(GdkEventKey* key) { ////////////////// //// ClangView /// ////////////////// -clang::Index Source::ClangView::clang_index(0, 1); +clang::Index Source::ClangView::clang_index(0, 0); Source::ClangView::ClangView(const Source::Config& config, const std::string& file_path, const std::string& project_path, Terminal::Controller& terminal): Source::View(config, file_path, project_path), terminal(terminal), @@ -145,12 +145,25 @@ parse_thread_go(true), parse_thread_mapped(false), parse_thread_stop(false) { int start_offset = get_source_buffer()->begin().get_offset(); int end_offset = get_source_buffer()->end().get_offset(); - std::map empty_buffer_map; - empty_buffer_map[file_path]=""; //for faster file opening - init_syntax_highlighting(empty_buffer_map, + auto buffer_map=get_buffer_map(); + //Remove includes for first parse for initial syntax highlighting + auto& str=buffer_map[file_path]; + std::size_t pos=0; + while((pos=str.find("#include", pos))!=std::string::npos) { + auto start_pos=pos; + pos=str.find('\n', pos+8); + if(pos==std::string::npos) + break; + if(start_pos==0 || str[start_pos-1]=='\n') { + str.replace(start_pos, pos-start_pos, pos-start_pos, ' '); + } + pos++; + } + init_syntax_highlighting(buffer_map, start_offset, end_offset, &ClangView::clang_index); + update_syntax(extract_tokens(0, get_source_buffer()->get_text().size())); //TODO: replace get_source_buffer()->get_text().size() //GTK-calls must happen in main thread, so the parse_thread //sends signals to the main thread that it is to call the following functions: From 7ad10db1fe685a7b4ce9667d392c3b56bf39a06e Mon Sep 17 00:00:00 2001 From: eidheim Date: Sun, 28 Jun 2015 14:06:03 +0200 Subject: [PATCH 16/16] Added llvm version 3.6.1. --- juci/cmake/Modules/FindLibClang.cmake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/juci/cmake/Modules/FindLibClang.cmake b/juci/cmake/Modules/FindLibClang.cmake index 8a4ed46..3d15636 100644 --- a/juci/cmake/Modules/FindLibClang.cmake +++ b/juci/cmake/Modules/FindLibClang.cmake @@ -14,7 +14,8 @@ # Known LLVM release numbers. # most recent versions come first -set(LIBCLANG_KNOWN_LLVM_VERSIONS 3.6 +set(LIBCLANG_KNOWN_LLVM_VERSIONS 3.6.1 + 3.6 3.5.1 3.5.0 #Arch Linux 3.5 #LLVM Debian/Ubuntu packages from http://llvm.org/apt/