Browse Source

Removed virtual calls during construction (found through clang-analyzer-optin.cplusplus.VirtualCall)

merge-requests/382/head
eidheim 8 years ago
parent
commit
d1f7a10614
  1. 1
      src/notebook.cc
  2. 1
      src/source_clang.cc
  3. 2
      src/source_diff.cc

1
src/notebook.cc

@ -154,6 +154,7 @@ void Notebook::open(const boost::filesystem::path &file_path_, size_t notebook_i
source_views.emplace_back(new Source::GenericView(file_path, language));
auto source_view=source_views.back();
source_view->configure();
source_view->scroll_to_cursor_delayed=[this](Source::BaseView* view, bool center, bool show_tooltips) {
while(Gtk::Main::events_pending())

1
src/source_clang.cc

@ -26,7 +26,6 @@ Source::ClangViewParse::ClangViewParse(const boost::filesystem::path &file_path,
get_buffer()->create_tag(item.second);
}
}
configure();
if(get_buffer()->size()==0 && (language->get_id()=="chdr" || language->get_id()=="cpphdr")) {
disable_spellcheck=true;

2
src/source_diff.cc

@ -45,8 +45,6 @@ Source::DiffView::DiffView(const boost::filesystem::path &file_path, Glib::RefPt
renderer->tag_removed=get_buffer()->create_tag("git_removed");
renderer->tag_removed_below=get_buffer()->create_tag();
renderer->tag_removed_above=get_buffer()->create_tag();
configure();
}
Source::DiffView::~DiffView() {

Loading…
Cancel
Save