Browse Source

Debug::get_return_value cleanup, and now works on older lldb versions

merge-requests/365/head
Ole Christian Eidheim 10 years ago
parent
commit
d2427b727b
  1. 5
      src/debug.cc
  2. 2
      src/debug.h
  3. 2
      src/source_clang.cc

5
src/debug.cc

@ -375,7 +375,7 @@ std::string Debug::get_value(const std::string &variable, const boost::filesyste
return variable_value; return variable_value;
} }
std::string Debug::get_return_value(const std::string &variable, const boost::filesystem::path &file_path, unsigned int line_nr, unsigned int line_index) { std::string Debug::get_return_value(const boost::filesystem::path &file_path, unsigned int line_nr, unsigned int line_index) {
std::string return_value; std::string return_value;
event_mutex.lock(); event_mutex.lock();
if(state==lldb::StateType::eStateStopped) { if(state==lldb::StateType::eStateStopped) {
@ -386,7 +386,8 @@ std::string Debug::get_return_value(const std::string &variable, const boost::fi
if(line_entry.IsValid()) { if(line_entry.IsValid()) {
lldb::SBStream stream; lldb::SBStream stream;
line_entry.GetFileSpec().GetDescription(stream); line_entry.GetFileSpec().GetDescription(stream);
if(boost::filesystem::path(stream.GetData())==file_path && line_entry.GetLine()==line_nr && line_entry.GetColumn()==line_index) { if(boost::filesystem::path(stream.GetData())==file_path && line_entry.GetLine()==line_nr &&
(line_entry.GetColumn()==0 || line_entry.GetColumn()==line_index)) {
lldb::SBStream stream; lldb::SBStream stream;
thread_return_value.GetDescription(stream); thread_return_value.GetDescription(stream);
return_value=stream.GetData(); return_value=stream.GetData();

2
src/debug.h

@ -46,7 +46,7 @@ public:
void delete_debug(); //can't use delete as function name void delete_debug(); //can't use delete as function name
std::string get_value(const std::string &variable, const boost::filesystem::path &file_path, unsigned int line_nr); std::string get_value(const std::string &variable, const boost::filesystem::path &file_path, unsigned int line_nr);
std::string get_return_value(const std::string &variable, const boost::filesystem::path &file_path, unsigned int line_nr, unsigned int line_index); std::string get_return_value(const boost::filesystem::path &file_path, unsigned int line_nr, unsigned int line_index);
bool is_invalid(); bool is_invalid();
bool is_stopped(); bool is_stopped();

2
src/source_clang.cc

@ -424,7 +424,7 @@ void Source::ClangViewParse::show_type_tooltips(const Gdk::Rectangle &rectangle)
if(debug_value.empty()) { if(debug_value.empty()) {
value_type="Return value"; value_type="Return value";
auto location=token.get_cursor().get_source_location(); auto location=token.get_cursor().get_source_location();
debug_value=Debug::get().get_return_value(token.get_spelling(), location.get_path(), location.get_offset().line, location.get_offset().index); debug_value=Debug::get().get_return_value(location.get_path(), location.get_offset().line, location.get_offset().index);
} }
if(!debug_value.empty()) { if(!debug_value.empty()) {
size_t pos=debug_value.find(" = "); size_t pos=debug_value.find(" = ");

Loading…
Cancel
Save