Fixes #446 : buffer overread in Tooltip::insert_doxygen(), and added _GLIBCXX_ASSERTIONS to tests

.gitlab-ci.yml

@@ -10,7 +10,7 @@ stages:
   stage: test
   script:
     - mkdir build && cd build
-    - CXXFLAGS=-Werror cmake -DBUILD_TESTING=1 ..
+    - CXXFLAGS="-Werror -D_GLIBCXX_ASSERTIONS" cmake -DBUILD_TESTING=1 ..
     - make -j$(nproc)
     - broadwayd & CTEST_OUTPUT_ON_FAILURE=1 make test
 

src/tooltips.cpp

@@ -1311,9 +1311,11 @@ void Tooltip::insert_doxygen(const std::string &input_, bool remove_delimiters)
       }
       else {
         auto i2 = i_saved;
-        --i2;
-        while(i2 > 0 && (input[i2] == ' ' || input[i2] == '\t'))
+        if(i2 > 0) {
           --i2;
+          while(i2 > 0 && (input[i2] == ' ' || input[i2] == '\t'))
+            --i2;
+        }
         if(input[i2] == '\n' || i2 == 0)
           markdown += "\n\n";
         if(input[i_saved] == '\\')