Browse Source

python: more missing moves, unnecessary inc_ref.

next
Aaron Gokaslan 4 years ago committed by Vladimír Vondruš
parent
commit
695c40b2d1
  1. 2
      src/Corrade/Containers/OptionalPythonBindings.h
  2. 2
      src/Magnum/PythonBindings.h

2
src/Corrade/Containers/OptionalPythonBindings.h

@ -37,7 +37,7 @@ template<class T> struct type_caster<Corrade::Containers::Optional<T>> {
using value_conv = make_caster<T>; using value_conv = make_caster<T>;
template<class T_> static handle cast(T_&& src, const return_value_policy policy, const handle parent) { template<class T_> static handle cast(T_&& src, const return_value_policy policy, const handle parent) {
if(!src) return none{}.inc_ref(); if(!src) return none{}.release();
return value_conv::cast(*std::forward<T_>(src), return_value_policy_override<T>::policy(policy), parent); return value_conv::cast(*std::forward<T_>(src), return_value_policy_override<T>::policy(policy), parent);
} }

2
src/Magnum/PythonBindings.h

@ -45,7 +45,7 @@ template<class T> struct PyImageViewHolder: std::unique_ptr<T> {
}; };
template<class T> PyImageViewHolder<T> pyImageViewHolder(const T& view, pybind11::object owner) { template<class T> PyImageViewHolder<T> pyImageViewHolder(const T& view, pybind11::object owner) {
return PyImageViewHolder<T>{new T{view}, owner}; return PyImageViewHolder<T>{new T{view}, std::move(owner)};
} }
} }

Loading…
Cancel
Save