ic
/
magnum
mirror of https://github.com/mosra/magnum.git
6
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
11716 Commits
21 Branches
19 Tags
74 MiB
Tree: abd81b9533
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'abd81b9533'
${ noResults }
magnum/src/Magnum/DebugTools/Test/ObjectRendererGLTest.cpp

208 lines
7.8 KiB
Raw Normal View History Unescape

DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
/*
This file is part of Magnum.
Updated copyright year.
6 years ago
Copyright © 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019,
Update copyright year.
6 months ago
2020, 2021, 2022, 2023, 2024, 2025, 2026
It's October already?!
2 years ago
Vladimír Vondruš <mosra@centrum.cz>
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"),
to deal in the Software without restriction, including without limitation
the rights to use, copy, modify, merge, publish, distribute, sublicense,
and/or sell copies of the Software, and to permit persons to whom the
Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
*/
DebugTools: deprecate ForceRenderer and ObjectRenderer. "These seemed like a good idea at the time." But that was in 2013 and while that might have been acceptable back then, it's not anymore, it's all just a complex abstraction that prevents any reasonable resource reuse and forces a dedicated draw call for each use. Just do this directly from the corresponding Primitives instead. Deprecating those allows me to eventually deprecate the (also overengineered) ResourceManager class, at which point Magnum should be finally free from the worst design decisions from 15 years ago. Unfortunately several examples still rely on it (while it only makes them more complex, not better), have to wait until those are cleaned up first.
4 days ago
#define _MAGNUM_NO_DEPRECATED_OBJECTRENDERER
#define _MAGNUM_NO_DEPRECATED_RESOURCEMANAGER
DebugTools: MSVC U mad? Can't you just work properly for once.
1 day ago
/* This damn joke of a compiler, even the 2022 version, ignores the
_MAGNUM_NO_DEPRECATED_OBJECTRENDERER macro for some reason, printing the
ObjectRenderer.h file deprecation warning here, so I have to work around it
like this. Same in ObjectRenderer.cpp and with ForceRenderer.h and its test,
but in ResourceManager.cpp as well as in doc/snippets/Magnum.cpp the macro
works. What the hell. */
#include <Corrade/configure.h>
#ifdef CORRADE_TARGET_MSVC
#define CORRADE_DEPRECATED_FILE(...)
#endif
DebugTools: expect more differences in renderer tests on ARM Mali. This makes the tests pass 100%.
7 years ago
#include <Corrade/Containers/Optional.h>
Test: port file/image comparison tests to the new Utility::Path.
4 years ago
#include <Corrade/Containers/String.h>
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
#include <Corrade/PluginManager/Manager.h>
Test: port file/image comparison tests to the new Utility::Path.
4 years ago
#include <Corrade/Utility/Path.h>
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
#include "Magnum/Image.h"
De-inline Image headers, remove dependency on ImageView. This means users have to add some more #includes on their side. Sorry but it's for your own good :P
7 years ago
#include "Magnum/ImageView.h"
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
#include "Magnum/PixelFormat.h"
#include "Magnum/DebugTools/CompareImage.h"
#include "Magnum/DebugTools/ObjectRenderer.h"
#include "Magnum/DebugTools/ResourceManager.h"
#include "Magnum/GL/Framebuffer.h"
#include "Magnum/GL/OpenGLTester.h"
#include "Magnum/GL/Renderbuffer.h"
#include "Magnum/GL/RenderbufferFormat.h"
#include "Magnum/SceneGraph/Camera.h"
#include "Magnum/SceneGraph/Scene.h"
#include "Magnum/SceneGraph/MatrixTransformation2D.h"
#include "Magnum/SceneGraph/MatrixTransformation3D.h"
#include "Magnum/Trade/AbstractImporter.h"
#include "configure.h"
DebugTools: expect more differences in renderer tests on ARM Mali. This makes the tests pass 100%.
7 years ago
#ifdef CORRADE_TARGET_ANDROID
#include "Magnum/GL/Context.h"
#endif
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
namespace Magnum { namespace DebugTools { namespace Test { namespace {
struct ObjectRendererGLTest: GL::OpenGLTester {
explicit ObjectRendererGLTest();
void render2D();
void render3D();
private:
PluginManager::Manager<Trade::AbstractImporter> _manager{"nonexistent"};
};
ObjectRendererGLTest::ObjectRendererGLTest() {
addTests({&ObjectRendererGLTest::render2D,
&ObjectRendererGLTest::render3D});
/* Load the plugins directly from the build tree. Otherwise they're either
static and already loaded or not present in the build tree */
#ifdef ANYIMAGEIMPORTER_PLUGIN_FILENAME
Make this compile and test cleanly with CORRADE_NO_ASSERT defined.
6 years ago
CORRADE_INTERNAL_ASSERT_OUTPUT(_manager.load(ANYIMAGEIMPORTER_PLUGIN_FILENAME) & PluginManager::LoadState::Loaded);
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
#endif
#ifdef TGAIMPORTER_PLUGIN_FILENAME
Make this compile and test cleanly with CORRADE_NO_ASSERT defined.
6 years ago
CORRADE_INTERNAL_ASSERT_OUTPUT(_manager.load(TGAIMPORTER_PLUGIN_FILENAME) & PluginManager::LoadState::Loaded);
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
#endif
}
using namespace Math::Literals;
void ObjectRendererGLTest::render2D() {
SceneGraph::Scene<SceneGraph::MatrixTransformation2D> scene;
SceneGraph::DrawableGroup2D drawables;
SceneGraph::Camera2D camera{scene};
camera.setProjectionMatrix(Matrix3::projection({4.0f, 4.0f}));
DebugTools: deprecate ForceRenderer and ObjectRenderer. "These seemed like a good idea at the time." But that was in 2013 and while that might have been acceptable back then, it's not anymore, it's all just a complex abstraction that prevents any reasonable resource reuse and forces a dedicated draw call for each use. Just do this directly from the corresponding Primitives instead. Deprecating those allows me to eventually deprecate the (also overengineered) ResourceManager class, at which point Magnum should be finally free from the worst design decisions from 15 years ago. Unfortunately several examples still rely on it (while it only makes them more complex, not better), have to wait until those are cleaned up first.
4 days ago
CORRADE_IGNORE_DEPRECATED_PUSH
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
ResourceManager manager;
manager.set("my", ObjectRendererOptions{}.setSize(2.2f));
DebugTools: deprecate ForceRenderer and ObjectRenderer. "These seemed like a good idea at the time." But that was in 2013 and while that might have been acceptable back then, it's not anymore, it's all just a complex abstraction that prevents any reasonable resource reuse and forces a dedicated draw call for each use. Just do this directly from the corresponding Primitives instead. Deprecating those allows me to eventually deprecate the (also overengineered) ResourceManager class, at which point Magnum should be finally free from the worst design decisions from 15 years ago. Unfortunately several examples still rely on it (while it only makes them more complex, not better), have to wait until those are cleaned up first.
4 days ago
CORRADE_IGNORE_DEPRECATED_POP
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
SceneGraph::Object<SceneGraph::MatrixTransformation2D> object{&scene};
object
.rotate(-17.3_degf)
.translate({-1.0f, -1.0f});
DebugTools: deprecate ForceRenderer and ObjectRenderer. "These seemed like a good idea at the time." But that was in 2013 and while that might have been acceptable back then, it's not anymore, it's all just a complex abstraction that prevents any reasonable resource reuse and forces a dedicated draw call for each use. Just do this directly from the corresponding Primitives instead. Deprecating those allows me to eventually deprecate the (also overengineered) ResourceManager class, at which point Magnum should be finally free from the worst design decisions from 15 years ago. Unfortunately several examples still rely on it (while it only makes them more complex, not better), have to wait until those are cleaned up first.
4 days ago
CORRADE_IGNORE_DEPRECATED_PUSH
DebugTools: finish ResourceManager singleton deprecation.
7 years ago
ObjectRenderer2D renderer{manager, object, "my", &drawables};
DebugTools: deprecate ForceRenderer and ObjectRenderer. "These seemed like a good idea at the time." But that was in 2013 and while that might have been acceptable back then, it's not anymore, it's all just a complex abstraction that prevents any reasonable resource reuse and forces a dedicated draw call for each use. Just do this directly from the corresponding Primitives instead. Deprecating those allows me to eventually deprecate the (also overengineered) ResourceManager class, at which point Magnum should be finally free from the worst design decisions from 15 years ago. Unfortunately several examples still rely on it (while it only makes them more complex, not better), have to wait until those are cleaned up first.
4 days ago
CORRADE_IGNORE_DEPRECATED_POP
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
GL::Renderbuffer color;
color.setStorage(
#if !defined(MAGNUM_TARGET_GLES2) || !defined(MAGNUM_TARGET_WEBGL)
GL::RenderbufferFormat::RGBA8,
#else
GL::RenderbufferFormat::RGBA4,
#endif
{64, 64});
GL::Framebuffer framebuffer{{{}, {64, 64}}};
framebuffer.attachRenderbuffer(GL::Framebuffer::ColorAttachment{0}, color)
.clear(GL::FramebufferClear::Color)
.bind();
camera.draw(drawables);
MAGNUM_VERIFY_NO_GL_ERROR();
DebugTools,TextureTools: better diagnostics for missing plugins in tests.
7 years ago
if(!(_manager.loadState("AnyImageImporter") & PluginManager::LoadState::Loaded) ||
!(_manager.loadState("TgaImporter") & PluginManager::LoadState::Loaded))
CORRADE_SKIP("AnyImageImporter / TgaImporter plugins not found.");
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
CORRADE_COMPARE_WITH(
framebuffer.read({{}, {64, 64}}, {PixelFormat::RGBA8Unorm}),
Test: port file/image comparison tests to the new Utility::Path.
4 years ago
Utility::Path::join(DEBUGTOOLS_TEST_DIR, "ObjectRenderer2D.tga"),
DebugTools: add some fuziness to ObjectRenderer test. SwiftShader misplaces two pixels. No biggie.
7 years ago
/* SwiftShader misplaces two pixels here. Nothing serious. */
(CompareImageToFile{_manager, 71.6f, 0.07f}));
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
}
void ObjectRendererGLTest::render3D() {
SceneGraph::Scene<SceneGraph::MatrixTransformation3D> scene;
SceneGraph::DrawableGroup3D drawables;
SceneGraph::Camera3D camera{scene};
camera.setProjectionMatrix(Matrix4::orthographicProjection({4.0f, 4.0f}, 0.1f, 2.0f));
DebugTools: deprecate ForceRenderer and ObjectRenderer. "These seemed like a good idea at the time." But that was in 2013 and while that might have been acceptable back then, it's not anymore, it's all just a complex abstraction that prevents any reasonable resource reuse and forces a dedicated draw call for each use. Just do this directly from the corresponding Primitives instead. Deprecating those allows me to eventually deprecate the (also overengineered) ResourceManager class, at which point Magnum should be finally free from the worst design decisions from 15 years ago. Unfortunately several examples still rely on it (while it only makes them more complex, not better), have to wait until those are cleaned up first.
4 days ago
CORRADE_IGNORE_DEPRECATED_PUSH
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
ResourceManager manager;
manager.set("my", ObjectRendererOptions{}.setSize(2.2f));
DebugTools: deprecate ForceRenderer and ObjectRenderer. "These seemed like a good idea at the time." But that was in 2013 and while that might have been acceptable back then, it's not anymore, it's all just a complex abstraction that prevents any reasonable resource reuse and forces a dedicated draw call for each use. Just do this directly from the corresponding Primitives instead. Deprecating those allows me to eventually deprecate the (also overengineered) ResourceManager class, at which point Magnum should be finally free from the worst design decisions from 15 years ago. Unfortunately several examples still rely on it (while it only makes them more complex, not better), have to wait until those are cleaned up first.
4 days ago
CORRADE_IGNORE_DEPRECATED_POP
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
SceneGraph::Object<SceneGraph::MatrixTransformation3D> object{&scene};
object
.rotateZ(17.3_degf)
.rotateY(45.0_degf)
.translate({-1.0f, -1.0f, -1.0f});
DebugTools: deprecate ForceRenderer and ObjectRenderer. "These seemed like a good idea at the time." But that was in 2013 and while that might have been acceptable back then, it's not anymore, it's all just a complex abstraction that prevents any reasonable resource reuse and forces a dedicated draw call for each use. Just do this directly from the corresponding Primitives instead. Deprecating those allows me to eventually deprecate the (also overengineered) ResourceManager class, at which point Magnum should be finally free from the worst design decisions from 15 years ago. Unfortunately several examples still rely on it (while it only makes them more complex, not better), have to wait until those are cleaned up first.
4 days ago
CORRADE_IGNORE_DEPRECATED_PUSH
DebugTools: finish ResourceManager singleton deprecation.
7 years ago
ObjectRenderer3D renderer{manager, object, "my", &drawables};
DebugTools: deprecate ForceRenderer and ObjectRenderer. "These seemed like a good idea at the time." But that was in 2013 and while that might have been acceptable back then, it's not anymore, it's all just a complex abstraction that prevents any reasonable resource reuse and forces a dedicated draw call for each use. Just do this directly from the corresponding Primitives instead. Deprecating those allows me to eventually deprecate the (also overengineered) ResourceManager class, at which point Magnum should be finally free from the worst design decisions from 15 years ago. Unfortunately several examples still rely on it (while it only makes them more complex, not better), have to wait until those are cleaned up first.
4 days ago
CORRADE_IGNORE_DEPRECATED_POP
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
GL::Renderbuffer color;
color.setStorage(
#if !defined(MAGNUM_TARGET_GLES2) || !defined(MAGNUM_TARGET_WEBGL)
GL::RenderbufferFormat::RGBA8,
#else
GL::RenderbufferFormat::RGBA4,
#endif
{64, 64});
GL::Framebuffer framebuffer{{{}, {64, 64}}};
framebuffer.attachRenderbuffer(GL::Framebuffer::ColorAttachment{0}, color)
.clear(GL::FramebufferClear::Color)
.bind();
camera.draw(drawables);
MAGNUM_VERIFY_NO_GL_ERROR();
DebugTools,TextureTools: better diagnostics for missing plugins in tests.
7 years ago
if(!(_manager.loadState("AnyImageImporter") & PluginManager::LoadState::Loaded) ||
!(_manager.loadState("TgaImporter") & PluginManager::LoadState::Loaded))
CORRADE_SKIP("AnyImageImporter / TgaImporter plugins not found.");
DebugTools: expect more differences in renderer tests on ARM Mali. This makes the tests pass 100%.
7 years ago
/* Intel Windows drivers misplace one pixel here. Nothing serious.
ARM Mali G71 (Huawei P10) has some rounding differences causing the
the bottom blue line to be on a different place (but the rest is
okay and the 2D case matches exactly), however to avoid false negatives
DebugTools,MeshTools,Shaders: increase test thresholds for llvmpipe. These are all just minor off-by-one errors, nothing to worry about. Except maybe for that one case with MeshTools::compile() but the rest of the image renders fine, so it's not like I'd have some critical issue there.
12 months ago
elsewhere I'm making it conditional. Same for llvmpipe. */
Adapt to Corrade changes.
5 years ago
Containers::Optional<CompareImageToFile> comparator{InPlaceInit, _manager, 71.6f, 0.018f};
DebugTools,MeshTools,Shaders: increase test thresholds for llvmpipe. These are all just minor off-by-one errors, nothing to worry about. Except maybe for that one case with MeshTools::compile() but the rest of the image renders fine, so it's not like I'd have some critical issue there.
12 months ago
if(
#ifdef CORRADE_TARGET_ANDROID
GL::Context::current().detectedDriver() >= GL::Context::DetectedDriver::ArmMali ||
#endif
GL::Context::current().rendererString().contains("llvmpipe")
)
DebugTools: expect more differences in renderer tests on ARM Mali. This makes the tests pass 100%.
7 years ago
comparator.emplace(_manager, 127.6f, 0.54f);
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
CORRADE_COMPARE_WITH(
framebuffer.read({{}, {64, 64}}, {PixelFormat::RGBA8Unorm}),
Test: port file/image comparison tests to the new Utility::Path.
4 years ago
Utility::Path::join(DEBUGTOOLS_TEST_DIR, "ObjectRenderer3D.tga"),
DebugTools: expect more differences in renderer tests on ARM Mali. This makes the tests pass 100%.
7 years ago
*comparator);
DebugTools: test ForceRenderer and ObjectRenderer. I spent some time trying ForceRenderer3D to produce the same image as ForceRenderer2D but it *does not want* to show the arrowhead to me, so I gave up.
7 years ago
}
}}}}
CORRADE_TEST_MAIN(Magnum::DebugTools::Test::ObjectRendererGLTest)