Physics: adapted ObjectShape to new SceneGraph implementation.

Before it was subclass of Object, now it is implemented as feature.

src/Physics/CMakeLists.txt

@@ -6,6 +6,8 @@ set(MagnumPhysics_SRCS
     Line.cpp
     Plane.cpp
     Point.cpp
+    ObjectShape.cpp
+    ObjectShapeGroup.cpp
     ShapeGroup.cpp
     Sphere.cpp)
 set(MagnumPhysics_HEADERS
@@ -17,6 +19,8 @@ set(MagnumPhysics_HEADERS
     LineSegment.h
     Plane.h
     Point.h
+    ObjectShape.h
+    ObjectShapeGroup.h
     ShapeGroup.h
     Sphere.h
 

src/Physics/ObjectShape.cpp

@@ -0,0 +1,46 @@
+/*
+    Copyright © 2010, 2011, 2012 Vladimír Vondruš <mosra@centrum.cz>
+
+    This file is part of Magnum.
+
+    Magnum is free software: you can redistribute it and/or modify
+    it under the terms of the GNU Lesser General Public License version 3
+    only, as published by the Free Software Foundation.
+
+    Magnum is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+    GNU Lesser General Public License version 3 for more details.
+*/
+
+#include "ObjectShape.h"
+
+#include <algorithm>
+
+#include "AbstractShape.h"
+#include "ObjectShapeGroup.h"
+
+using namespace std;
+
+namespace Magnum { namespace Physics {
+
+template<uint8_t dimensions> ObjectShape<dimensions>::ObjectShape(SceneGraph::AbstractObject<dimensions>* object, ObjectShapeGroup<dimensions>* group): SceneGraph::AbstractGroupedFeature<dimensions, ObjectShape<dimensions>>(object, group), _shape(nullptr) {
+    this->setCachedTransformations(SceneGraph::AbstractFeature<dimensions>::CachedTransformation::Absolute);
+}
+
+template<uint8_t dimensions> ObjectShape<dimensions>::~ObjectShape() {
+    delete _shape;
+}
+
+template<uint8_t dimensions> void ObjectShape<dimensions>::markDirty() {
+    group()->setDirty();
+}
+
+template<uint8_t dimensions> void ObjectShape<dimensions>::clean(const typename DimensionTraits<dimensions, GLfloat>::MatrixType& absoluteTransformation) {
+    if(_shape) _shape->applyTransformation(absoluteTransformation);
+}
+
+template class ObjectShape<2>;
+template class ObjectShape<3>;
+
+}}

src/Physics/ObjectShape.h

@@ -0,0 +1,98 @@
+#ifndef Magnum_Physics_ObjectShape_h
+#define Magnum_Physics_ObjectShape_h
+/*
+    Copyright © 2010, 2011, 2012 Vladimír Vondruš <mosra@centrum.cz>
+
+    This file is part of Magnum.
+
+    Magnum is free software: you can redistribute it and/or modify
+    it under the terms of the GNU Lesser General Public License version 3
+    only, as published by the Free Software Foundation.
+
+    Magnum is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+    GNU Lesser General Public License version 3 for more details.
+*/
+
+/** @file
+ * @brief Class Magnum::Physics::ObjectShape
+ */
+
+#include "SceneGraph/AbstractGroupedFeature.h"
+#include "ObjectShapeGroup.h"
+
+#include "magnumPhysicsVisibility.h"
+
+namespace Magnum { namespace Physics {
+
+template<std::uint8_t> class ObjectShapeGroup;
+template<std::uint8_t> class AbstractShape;
+
+/**
+@brief Object shape
+
+Adds shape for collision detection to object.
+@see ObjectShape2D, ObjectShape3D
+*/
+template<std::uint8_t dimensions> class PHYSICS_EXPORT ObjectShape: public SceneGraph::AbstractGroupedFeature<dimensions, ObjectShape<dimensions>> {
+    public:
+        /**
+         * @brief Constructor
+         * @param object    Object holding this feature
+         * @param group     Group this shape belongs to
+         *
+         * Creates empty object shape.
+         * @see setShape()
+         */
+        ObjectShape(SceneGraph::AbstractObject<dimensions>* object, ObjectShapeGroup<dimensions>* group = nullptr);
+
+        /**
+         * @brief Destructor
+         *
+         * Deletes associated shape.
+         */
+        ~ObjectShape();
+
+        /** @brief Shape */
+        inline AbstractShape<dimensions>* shape() { return _shape; }
+        inline const AbstractShape<dimensions>* shape() const { return _shape; } /**< @overload */
+
+        /**
+         * @brief Set shape
+         * @return Pointer to self (for method chaining)
+         */
+        inline ObjectShape<dimensions>* setShape(AbstractShape<dimensions>* shape) {
+            _shape = shape;
+            this->object()->setDirty();
+            return this;
+        }
+
+        inline ObjectShapeGroup<dimensions>* group() {
+            return static_cast<ObjectShapeGroup<dimensions>*>(SceneGraph::AbstractGroupedFeature<dimensions, ObjectShape<dimensions>>::group());
+        }
+
+        inline const ObjectShapeGroup<dimensions>* group() const {
+            return static_cast<const ObjectShapeGroup<dimensions>*>(SceneGraph::AbstractGroupedFeature<dimensions, ObjectShape<dimensions>>::group());
+        }
+
+    protected:
+        /** Marks also the group as dirty */
+        void markDirty() override;
+
+        /** Applies transformation to associated shape. */
+        void clean(const typename DimensionTraits<dimensions>::MatrixType& absoluteTransformation) override;
+
+    private:
+        AbstractShape<dimensions>* _shape;
+};
+
+/** @brief Two-dimensional object shape */
+typedef ObjectShape<2> ObjectShape2D;
+
+/** @brief Three-dimensional object shape */
+typedef ObjectShape<3> ObjectShape3D;
+
+}}
+
+#endif

src/Physics/ObjectShapeGroup.cpp

@@ -13,20 +13,26 @@
     GNU Lesser General Public License version 3 for more details.
 */
 
-#include "ShapedObjectGroup.h"
+#include "ObjectShapeGroup.h"
 
-#include "ShapedObject.h"
+#include "ObjectShape.h"
 
 namespace Magnum { namespace Physics {
 
-template<std::uint8_t dimensions> void ShapedObjectGroup<dimensions>::setClean() {
+template<std::uint8_t dimensions> void ObjectShapeGroup<dimensions>::setClean() {
-    for(ShapedObject<dimensions>* object: objects)
+    /* Clean all objects */
-        if(object->isDirty()) object->setClean();
+    if(!this->isEmpty()) {
+        std::vector<SceneGraph::AbstractObject<dimensions>*> objects(this->size());
+        for(std::size_t i = 0; i != this->size(); ++i)
+            objects[i] = (*this)[i]->object();
+
+        objects[0]->setClean(objects);
+    }
 
     dirty = false;
 }
 
-template class ShapedObjectGroup<2>;
+template class ObjectShapeGroup<2>;
-template class ShapedObjectGroup<3>;
+template class ObjectShapeGroup<3>;
 
 }}

src/Physics/ObjectShapeGroup.h

@@ -1,5 +1,5 @@
-#ifndef Magnum_Physics_ShapedObjectGroup_h
+#ifndef Magnum_Physics_ObjectShapeGroup_h
-#define Magnum_Physics_ShapedObjectGroup_h
+#define Magnum_Physics_ObjectShapeGroup_h
 /*
     Copyright © 2010, 2011, 2012 Vladimír Vondruš <mosra@centrum.cz>
 
@@ -16,28 +16,28 @@
 */
 
 /** @file
- * @brief Class Magnum::Physics::ShapedObjectGroup
+ * @brief Class Magnum::Physics::ObjectShapeGroup
  */
 
 #include <cstdint>
 #include <vector>
 
+#include "SceneGraph/FeatureGroup.h"
+
 #include "magnumPhysicsVisibility.h"
 
 namespace Magnum { namespace Physics {
 
-template<std::uint8_t> class ShapedObject;
+template<std::uint8_t> class ObjectShape;
 
 /**
-@brief Group of shaped objects
+@brief Group of object shapes
+
 
-@ref ShapedObject "ShapedObject*D" instances are added to the group by
+@see ObjectShapeGroup2D, ObjectShapeGroup3D
-specifying it in the constructor. When the group is deleted, all objects
-belogning to it are deleted too.
-@see ShapedObjectGroup2D, ShapedObjectGroup3D
 */
-template<std::uint8_t dimensions> class PHYSICS_EXPORT ShapedObjectGroup {
+template<std::uint8_t dimensions> class PHYSICS_EXPORT ObjectShapeGroup: public SceneGraph::FeatureGroup<dimensions, ObjectShape<dimensions>> {
-    friend class ShapedObject<dimensions>;
+    friend class ObjectShape<dimensions>;
 
     public:
         /**
@@ -45,16 +45,7 @@ template<std::uint8_t dimensions> class PHYSICS_EXPORT ShapedObjectGroup {
          *
          * Marks the group as dirty.
          */
-        inline ShapedObjectGroup(): dirty(true) {}
+        inline ObjectShapeGroup(): dirty(true) {}
-
-        /**
-         * @brief Destructor
-         *
-         * Deletes all objects belogning to the group.
-         */
-        inline virtual ~ShapedObjectGroup() {
-            for(auto i: objects) delete i;
-        }
 
         /**
          * @brief Whether the group is dirty
@@ -82,15 +73,14 @@ template<std::uint8_t dimensions> class PHYSICS_EXPORT ShapedObjectGroup {
         void setClean();
 
     private:
-        std::vector<ShapedObject<dimensions>*> objects;
         bool dirty;
 };
 
 /** @brief Group of two-dimensional shaped objects */
-typedef ShapedObjectGroup<2> ShapedObjectGroup2D;
+typedef ObjectShapeGroup<2> ObjectShapeGroup2D;
 
 /** @brief Group of three-dimensional shaped objects */
-typedef ShapedObjectGroup<3> ShapedObjectGroup3D;
+typedef ObjectShapeGroup<3> ObjectShapeGroup3D;
 
 }}
 

src/Physics/ShapedObject.cpp

@@ -1,51 +0,0 @@
-/*
-    Copyright © 2010, 2011, 2012 Vladimír Vondruš <mosra@centrum.cz>
-
-    This file is part of Magnum.
-
-    Magnum is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Lesser General Public License version 3
-    only, as published by the Free Software Foundation.
-
-    Magnum is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-    GNU Lesser General Public License version 3 for more details.
-*/
-
-#include "ShapedObject.h"
-
-#include <algorithm>
-
-#include "AbstractShape.h"
-#include "ShapedObjectGroup.h"
-
-using namespace std;
-
-namespace Magnum { namespace Physics {
-
-template<uint8_t dimensions> ShapedObject<dimensions>::ShapedObject(ShapedObjectGroup<dimensions>* group, typename SceneGraph::AbstractObject<dimensions>::ObjectType* parent): SceneGraph::AbstractObject<dimensions>::ObjectType(parent), group(group), _shape(nullptr) {
-    group->objects.push_back(this);
-}
-
-template<uint8_t dimensions> ShapedObject<dimensions>::~ShapedObject() {
-    group->objects.erase(find(group->objects.begin(), group->objects.end(), this));
-    delete _shape;
-}
-
-template<uint8_t dimensions> void ShapedObject<dimensions>::setDirty() {
-    SceneGraph::AbstractObject<dimensions>::ObjectType::setDirty();
-
-    group->setDirty();
-}
-
-template<uint8_t dimensions> void ShapedObject<dimensions>::clean(const typename DimensionTraits<dimensions, GLfloat>::MatrixType& absoluteTransformation) {
-    SceneGraph::AbstractObject<dimensions>::ObjectType::clean(absoluteTransformation);
-
-    if(_shape) _shape->applyTransformation(absoluteTransformation);
-}
-
-template class ShapedObject<2>;
-template class ShapedObject<3>;
-
-}}

src/Physics/ShapedObject.h

@@ -1,97 +0,0 @@
-#ifndef Magnum_Physics_ShapedObject_h
-#define Magnum_Physics_ShapedObject_h
-/*
-    Copyright © 2010, 2011, 2012 Vladimír Vondruš <mosra@centrum.cz>
-
-    This file is part of Magnum.
-
-    Magnum is free software: you can redistribute it and/or modify
-    it under the terms of the GNU Lesser General Public License version 3
-    only, as published by the Free Software Foundation.
-
-    Magnum is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-    GNU Lesser General Public License version 3 for more details.
-*/
-
-/** @file
- * @brief Class Magnum::Physics::ShapedObject
- */
-
-#include "SceneGraph/Object.h"
-
-#include "magnumPhysicsVisibility.h"
-
-namespace Magnum { namespace Physics {
-
-template<std::uint8_t> class ShapedObjectGroup;
-template<std::uint8_t> class AbstractShape;
-
-/**
-@brief Object with assigned shape
-
-@see ShapedObject2D, ShapedObject3D
-*/
-template<std::uint8_t dimensions> class PHYSICS_EXPORT ShapedObject: public SceneGraph::AbstractObject<dimensions>::ObjectType {
-    public:
-        /**
-         * @brief Constructor
-         * @param group     Group this shaped object belongs to
-         * @param parent    Parent object
-         *
-         * Creates object with no shape.
-         * @see setShape()
-         */
-        ShapedObject(ShapedObjectGroup<dimensions>* group, typename SceneGraph::AbstractObject<dimensions>::ObjectType* parent = nullptr);
-
-        /**
-         * @brief Destructor
-         *
-         * Deletes associated shape.
-         */
-        ~ShapedObject();
-
-        /** @brief Object shape */
-        inline AbstractShape<dimensions>* shape() { return _shape; }
-        inline const AbstractShape<dimensions>* shape() const { return _shape; } /**< @overload */
-
-        /**
-         * @brief Set object shape
-         * @return Pointer to self (for method chaining)
-         */
-        inline ShapedObject<dimensions>* setShape(AbstractShape<dimensions>* shape) {
-            _shape = shape;
-            setDirty();
-            return this;
-        }
-
-        /**
-         * @copybrief SceneGraph::AbstractObject::setDirty()
-         *
-         * Marks shaped object group as dirty.
-         */
-        void setDirty();
-
-    protected:
-        /**
-         * @copybrief SceneGraph::AbstractObject::clean()
-         *
-         * Applies transformation to associated shape.
-         */
-        void clean(const typename DimensionTraits<dimensions, GLfloat>::MatrixType& absoluteTransformation);
-
-    private:
-        ShapedObjectGroup<dimensions>* group;
-        AbstractShape<dimensions>* _shape;
-};
-
-/** @brief Two-dimensional shaped object */
-typedef ShapedObject<2> ShapedObject2D;
-
-/** @brief Three-dimensional shaped object */
-typedef ShapedObject<3> ShapedObject3D;
-
-}}
-
-#endif

src/Physics/Test/CMakeLists.txt

@@ -7,3 +7,5 @@ corrade_add_test2(PhysicsPlaneTest PlaneTest.cpp LIBRARIES MagnumPhysics)
 corrade_add_test2(PhysicsPointTest PointTest.cpp LIBRARIES MagnumPhysics)
 corrade_add_test2(PhysicsShapeGroupTest ShapeGroupTest.cpp LIBRARIES MagnumPhysics)
 corrade_add_test2(PhysicsSphereTest SphereTest.cpp LIBRARIES MagnumPhysics)
+
+corrade_add_test2(PhysicsObjectShapeTest ObjectShapeTest.cpp LIBRARIES MagnumPhysics)

src/Physics/Test/ObjectShapeTest.cpp

@@ -13,23 +13,36 @@
     GNU Lesser General Public License version 3 for more details.
 */
 
-#include "ShapedObjectTest.h"
+#include "ObjectShapeTest.h"
 
-#include "Physics/ShapedObjectGroup.h"
+#include "Physics/ObjectShapeGroup.h"
-#include "Physics/ShapedObject.h"
+#include "Physics/ObjectShape.h"
+#include "Physics/Point.h"
+#include "SceneGraph/MatrixTransformation3D.h"
+#include "SceneGraph/Scene.h"
 
-CORRADE_TEST_MAIN(Magnum::Physics::Test::ShapedObjectTest)
+CORRADE_TEST_MAIN(Magnum::Physics::Test::ObjectShapeTest)
 
 namespace Magnum { namespace Physics { namespace Test {
 
-ShapedObjectTest::ShapedObjectTest() {
+typedef SceneGraph::Scene<SceneGraph::MatrixTransformation3D<>> Scene3D;
-    addTests(&ShapedObjectTest::clean);
+typedef SceneGraph::Object<SceneGraph::MatrixTransformation3D<>> Object3D;
+
+ObjectShapeTest::ObjectShapeTest() {
+    addTests(&ObjectShapeTest::clean);
 }
 
-void ShapedObjectTest::clean() {
+void ObjectShapeTest::clean() {
-    ShapedObjectGroup3D group;
+    Scene3D scene;
+    ObjectShapeGroup3D group;
+
+    Object3D a(&scene);
+    ObjectShape3D* shape = new ObjectShape3D(&a, &group);
+    shape->setShape(new Physics::Point3D({1.0f, -2.0f, 3.0f}));
+    a.scale(Vector3(-2.0f));
 
-    ShapedObject3D a(&group), b(&group);
+    Object3D b(&scene);
+    new ObjectShape3D(&b, &group);
 
     /* Everything is dirty at the beginning */
     CORRADE_VERIFY(group.isDirty());
@@ -42,6 +55,10 @@ void ShapedObjectTest::clean() {
     CORRADE_VERIFY(!a.isDirty());
     CORRADE_VERIFY(b.isDirty());
 
+    /* Verify that the feature was actually cleaned */
+    CORRADE_COMPARE(static_cast<const Physics::Point3D*>(shape->shape())->transformedPosition(),
+        Vector3(-2.0f, 4.0f, -6.0f));
+
     /* Setting group clean will clean whole group */
     a.setDirty();
     group.setClean();

src/Physics/Test/ObjectShapeTest.h

@@ -1,5 +1,5 @@
-#ifndef Magnum_Physics_Test_ShapedObjectTest_h
+#ifndef Magnum_Physics_Test_ObjectShapeTest_h
-#define Magnum_Physics_Test_ShapedObjectTest_h
+#define Magnum_Physics_Test_ObjectShapeTest_h
 /*
     Copyright © 2010, 2011, 2012 Vladimír Vondruš <mosra@centrum.cz>
 
@@ -19,9 +19,9 @@
 
 namespace Magnum { namespace Physics { namespace Test {
 
-class ShapedObjectTest: public Corrade::TestSuite::Tester<ShapedObjectTest> {
+class ObjectShapeTest: public Corrade::TestSuite::Tester<ObjectShapeTest> {
     public:
-        ShapedObjectTest();
+        ObjectShapeTest();
 
         void clean();
 };