Browse Source

Removed TODOs already done in gcc4.7 branch.

It cannot be done another way than with delegating constructors, so it's
no reason to keep this todo for gcc 4.6.
vectorfields
Vladimír Vondruš 14 years ago
parent
commit
eb80448912
  1. 1
      src/Math/Matrix.h
  2. 1
      src/Math/Matrix3.h
  3. 1
      src/Math/Matrix4.h
  4. 1
      src/Math/Vector.h
  5. 1
      src/Math/Vector2.h
  6. 1
      src/Math/Vector3.h
  7. 1
      src/Math/Vector4.h

1
src/Math/Matrix.h

@ -96,7 +96,6 @@ template<class T, size_t size> class Matrix {
* you to specify value on diagonal. * you to specify value on diagonal.
*/ */
inline explicit Matrix(IdentityType = Identity, T value = T(1)): _data() { inline explicit Matrix(IdentityType = Identity, T value = T(1)): _data() {
/** @todo constexpr how? */
for(size_t i = 0; i != size; ++i) for(size_t i = 0; i != size; ++i)
_data[size*i+i] = value; _data[size*i+i] = value;
} }

1
src/Math/Matrix3.h

@ -47,7 +47,6 @@ template<class T> class Matrix3: public Matrix<T, 3> {
/** @copydoc Matrix::Matrix(IdentityType, T) */ /** @copydoc Matrix::Matrix(IdentityType, T) */
inline constexpr explicit Matrix3(typename Matrix<T, 3>::IdentityType = Matrix<T, 3>::Identity, T value = T(1)): Matrix<T, 3>( inline constexpr explicit Matrix3(typename Matrix<T, 3>::IdentityType = Matrix<T, 3>::Identity, T value = T(1)): Matrix<T, 3>(
/** @todo Make this in Matrix itself, after it will be constexpr */
value, 0.0f, 0.0f, value, 0.0f, 0.0f,
0.0f, value, 0.0f, 0.0f, value, 0.0f,
0.0f, 0.0f, value 0.0f, 0.0f, value

1
src/Math/Matrix4.h

@ -114,7 +114,6 @@ template<class T> class Matrix4: public Matrix<T, 4> {
/** @copydoc Matrix::Matrix(IdentityType, T) */ /** @copydoc Matrix::Matrix(IdentityType, T) */
inline constexpr explicit Matrix4(typename Matrix<T, 4>::IdentityType = Matrix<T, 4>::Identity, T value = T(1)): Matrix<T, 4>( inline constexpr explicit Matrix4(typename Matrix<T, 4>::IdentityType = Matrix<T, 4>::Identity, T value = T(1)): Matrix<T, 4>(
/** @todo Make this in Matrix itself, after it will be constexpr */
value, 0.0f, 0.0f, 0.0f, value, 0.0f, 0.0f, 0.0f,
0.0f, value, 0.0f, 0.0f, 0.0f, value, 0.0f, 0.0f,
0.0f, 0.0f, value, 0.0f, 0.0f, 0.0f, value, 0.0f,

1
src/Math/Vector.h

@ -101,7 +101,6 @@ template<class T, size_t size> class Vector {
* @param value Value for all fields * @param value Value for all fields
*/ */
inline explicit Vector(T value) { inline explicit Vector(T value) {
/** @todo constexprize */
for(size_t i = 0; i != size; ++i) for(size_t i = 0; i != size; ++i)
_data[i] = value; _data[i] = value;
} }

1
src/Math/Vector2.h

@ -37,7 +37,6 @@ template<class T> class Vector2: public Vector<T, 2> {
} }
/** @copydoc Vector::Vector(T) */ /** @copydoc Vector::Vector(T) */
/** @todo Use original constructor when it is constexpr */
inline constexpr explicit Vector2(T value = T()): Vector<T, 2>(value, value) {} inline constexpr explicit Vector2(T value = T()): Vector<T, 2>(value, value) {}
/** @copydoc Vector::Vector(const Vector&) */ /** @copydoc Vector::Vector(const Vector&) */

1
src/Math/Vector3.h

@ -60,7 +60,6 @@ template<class T> class Vector3: public Vector<T, 3> {
} }
/** @copydoc Vector::Vector(T) */ /** @copydoc Vector::Vector(T) */
/** @todo Use original constructor when it is constexpr */
inline constexpr explicit Vector3(T value = T()): Vector<T, 3>(value, value, value) {} inline constexpr explicit Vector3(T value = T()): Vector<T, 3>(value, value, value) {}
/** @copydoc Vector::Vector(const Vector&) */ /** @copydoc Vector::Vector(const Vector&) */

1
src/Math/Vector4.h

@ -44,7 +44,6 @@ template<class T> class Vector4: public Vector<T, 4> {
inline constexpr Vector4(): Vector<T, 4>(T(0), T(0), T(0), T(1)) {} inline constexpr Vector4(): Vector<T, 4>(T(0), T(0), T(0), T(1)) {}
/** @copydoc Vector::Vector(T) */ /** @copydoc Vector::Vector(T) */
/** @todo Use original constructor when it is constexpr */
inline constexpr explicit Vector4(T value): Vector<T, 4>(value, value, value, value) {} inline constexpr explicit Vector4(T value): Vector<T, 4>(value, value, value, value) {}
/** @copydoc Vector::Vector(const Vector&) */ /** @copydoc Vector::Vector(const Vector&) */

Loading…
Cancel
Save