magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	25320af545	Trade: pass strided views by const&. Those have 3 pointers at least, my limit for passing by value is trivial copyability and two pointers. I hope that reflects the actual HW at least vaguely, heh.	5 years ago
Vladimír Vondruš	2b2b7d5f2f	Trade: provide a clear doc snippet for AbstractImporter::openData(). The snippet with callbacks was too heavyweight for this kind of operation and workflow with in-memory data may be non-obvious to some users.	5 years ago
Vladimír Vondruš	5c06eecde8	Trade: actually, do it like this.	5 years ago
Vladimír Vondruš	bf6caece50	Trade: fix MeshData range checks for array attributes. And add a comment explaining why we don't check the pointer for empty meshes -- otherwise empty interleaved meshes would fail with stuff like Trade::MeshData: attribute 0 [0xc:0xc] is not contained in passed vertexData array [0x0:0x0] which ... helps nobody.	5 years ago
Vladimír Vondruš	b4666a2194	Trade: improve tests for MeshData index/attribute view range checks. Found a bug with attribute array size not being taken into account. It triggers now.	5 years ago
Vladimír Vondruš	2059b2b164	Trade: doc++	5 years ago
Vladimír Vondruš	093957a6ed	Trade: no need to zero-init memory in MeshData::*AsArray() helpers. It's all going to get overwritten by the data anyway, so this just unnecessarily hurts perf.	5 years ago
Vladimír Vondruš	3eb5f887d0	Trade: move a helper definition above where it's used first.	5 years ago
Vladimír Vondruš	cc8d88cbb1	Trade: move a test case to where it fits better.	5 years ago
Vladimír Vondruš	206c4d7a9e	Trade: no need to type that much.	5 years ago
Vladimír Vondruš	26a0bf94ff	Trade: improve MeshData type mismatch assertions. We do know what type the user requested, so why not print it as well. And for the array access the message was especially lazy.	5 years ago
Vladimír Vondruš	7a91b56aa1	Trade: test all MeshData mutable/array attribute assertion variants.	5 years ago
Vladimír Vondruš	c904cd0599	Trade: properly propagate array size from MeshData::attributeData(). The test now passes again.	5 years ago
Vladimír Vondruš	f4da3d78cc	Trade: merge MeshData array attribute tests with the main test. Because otherwise we don't properly test all cases. Case in point -- attributeData(UnsignedInt) wasn't correctly propagating the array size, causing the new tests to fail. Fix in the next commit.	5 years ago
Vladimír Vondruš	0ba5f33f73	Trade: consistent terminology in an assert message.	5 years ago
Vladimír Vondruš	343fc8794d	Trade: don't need to delegate trivial things.	5 years ago
Vladimír Vondruš	c24a762e15	Trade: not sure what's up with this silly temporary. Some places have it, some don't. It's shorter without.	5 years ago
Vladimír Vondruš	2b8d9c7e74	Trade: internal API was named in an outdated way. Long ago, during one of the few initial MeshData iterations. there was no VertexFormat, but rather Trade::MeshAttributeType. I managed to get rid of it mostly, except this place.	5 years ago
Vladimír Vondruš	fe57f23e12	Trade: const++	5 years ago
Vladimír Vondruš	e1d62fb154	Trade: typos.	5 years ago
Vladimír Vondruš	46a6724198	Trade: doc++	5 years ago
Vladimír Vondruš	03b7adf71b	imageconverter: some examples of how to use the new functionality. Originally I wanted to show how to convert a JPEG to an EXR directly, however after trying and miserably failing to implement that inside OpenExrImageConverter I realized the plugin is definitely not the place where to perform such conversion. So this will have to wait until there's some proper API in TextureTools or somewhere.	5 years ago
Vladimír Vondruš	77b979041b	imageconverter: ability to extract layers again.	5 years ago
Vladimír Vondruš	5d4342f1c1	imageconverter: implicitly import and convert all image levels. In case of --layers and --levels this only works if the input images have a single level, otherwise --level has to be set. The internal implementation would be too complex otherwise. As a consequence, combining a set of 2D mipmapped images into a 3D mipmapped image means one first has to combine particular 2D image levels to 3D levels and then combine all 3D levels to a 3D mipmapped image, it can't be done in a single step and it also can't be done by first combining levels and then layers.	5 years ago
Vladimír Vondruš	e017ba135c	imageconverter: ability to combine multiple levels together. I still have to figure out the interactions between --layers and --levels and how to implicitly handle conversion of multi-level files.	5 years ago
Vladimír Vondruš	b83099a8c6	imageconverter: ability to combine multiple image layers together. Hey, this was fun, after all!	5 years ago
Vladimír Vondruš	c3213cff9b	imageconverter: print the input filename in each error message. In preparation for support of multiple input files.	5 years ago
Vladimír Vondruš	7a072c59c2	imageconverter: ability to convert also 1D and 3D images. As well as a proper, graceful and helpful diagnostic for images and levels out of bounds. Before the thing just asserted and died.	5 years ago
Vladimír Vondruš	7702c579a5	imageconverter: shorten the argument help a bit.	5 years ago
Vladimír Vondruš	36b7446a6a	Trade: add docs about multi-level image conversion.	5 years ago
Vladimír Vondruš	f989630a09	AnyImageImporter: test 3D image loading code path. Using the fresh new OpenExrImporter cubemap support.	5 years ago
Vladimír Vondruš	3e8627e688	AnyImageImporter: test detection of Basis file data as well. Hnngh, why did I have the file there at all, then?	5 years ago
Vladimír Vondruš	a130f26797	AnyImageConverter: add conversion of 3D and multi-level 2D/3D images. Now that OpenExrImageConverter has cubemap and multi-level support we can finally add and test these code paths.	5 years ago
Vladimír Vondruš	a3faf8e7e1	AnyImageConverter: minor cleanup in a test.	5 years ago
Vladimír Vondruš	8ec056bcc9	AnyImageConverter: there's no point in having this test instanced.	5 years ago
Vladimír Vondruš	3265f428fb	AnyImageConverter: uppercase variables? nooo	5 years ago
Vladimír Vondruš	cf5b02b2bc	sceneconverter: note how many dimensions images have in --info. Same as with imageconverter in `696e9fb105`. This stuff should get deduplicated because such errors will happen more and more.	5 years ago
Vladimír Vondruš	eccf2f5820	GL: doc++	5 years ago
Vladimír Vondruš	c2ecaa6abf	GL: AbstractShaderProgram::draw() that takes plain array views. Because a MeshView might not be the best thing to have when you are submitting a batch of thousand draws. It takes a strided array views to allow for more flexibility, but can also detect if the input is already contiguous and use it as-is. UNFORTUNATELY the GL 1.0 legacy still continues to stink and so there has to be a 64-bit-specific overload which is the actual variant that doesn't allocate because glMultiDrawElements takes a `void**` for INDEX OFFSETS and it's IN BYTES! Which foolish soul designed such a thing back in the 1860s, I wonder. There's no reason to not have an index offset in elements because all indices have to have the same type ANYWAY. And yes, I wasted about three hours debugging driver crashes because I THOUGHT this parameter takes offset in elements, not bytes. Also note: on 32-bit platforms this depends on latest Corrade with the CORRADE_TARGET_32BIT definition. Spent an embarrassing amount of time wondering why all local builds but Emscripten work.	5 years ago
Vladimír Vondruš	ae0aa306c6	GL: clarify an assert. "Cannot draw multiple instanced meshes." is no better than "SOMETHING WENT WRONG PLEASE SHRED YOUR APPLE DEVICE."	5 years ago
Vladimír Vondruš	d8c6a7d690	GL: the multi-draw test for Mesh was underwhelming, to say the least. Or, the horror when I comment-out half of it and it still kinda passes. The new code tests it more thoroughly, with actually checking that different draw produce different results instead of one draw overwriting the other. Plus also verifying interaction with gl_VertexID and gl_DrawID to ensure it really behaves correctly: - gl_VertexID should get the same value regardless of whether we perform a multi-draw or a one-by-one fallback, so this catches issues where the mesh would get reconfigured in some nasty way, losing this information - gl_DrawID should get properly populated if and only if we use the multi-draw code path, so this catches issues where the fallback would get used instead of the actual multi-draw code path	5 years ago
Vladimír Vondruš	dc5fdd7cb5	GL: fix a confusing typo in a comment.	5 years ago
Vladimír Vondruš	1beb2edb64	package/ci: I'm tired of Emscripten builds randomly failing. Let's reduce the parallelism even more. SIGH.	5 years ago
Vladimír Vondruš	eea9d32959	Trade: tighten AbstractImageConverter input requirements. The multi-level APIs still don't check anything regarding level sizes and order since for example *.ico has no restrictions at all. But the rest (like non-zero size) is a restriction for all file formats I'm aware of. TgaImageConverter test had to be adapted, I expect a lot of breakages in plugins tests as well. But user code should be fine I think. Also reduced the rather excessive dimensions in AbstractImageConverterTest, since the allocation requirement now made the default Emscripten heap OOM.	5 years ago
Vladimír Vondruš	df0b085cdc	AnyImageImporter: doc++	5 years ago
Vladimír Vondruš	f96adfdc37	Doc++, updated changelog.	5 years ago
Vladimír Vondruš	b25ab9d809	AnyImageConverter: recognize KTX2 files. Preparing for the soon-to-be-merged KTX files. Not hooking up 1D/3D and the compressed APIs yet, doing that only when the plugins get merged so I have a way to test.	5 years ago
Vladimír Vondruš	696e9fb105	imageconverter: note how many dimensions the image has in --info.	5 years ago
Vladimír Vondruš	8ce842117e	imageconverter: am I stupid? yes!	5 years ago
Vladimír Vondruš	e7dc2f00a1	Vk: fix an unused variable warning on a no-assert build.	5 years ago

1 2 3 4 5 ...

9045 Commits (25320af545a2e3d637dd4e5b8de6ee2cb3609c80) All Branches Search

9045 Commits (25320af545a2e3d637dd4e5b8de6ee2cb3609c80)

All Branches