Browse Source

Platform: add a TODO.

Of course it's all extremely messy because there's no better way.
pull/680/head
Vladimír Vondruš 9 months ago
parent
commit
968b9a59dc
  1. 4
      src/Magnum/Platform/EmscriptenApplication.cpp
  2. 4
      src/Magnum/Platform/GlfwApplication.cpp
  3. 4
      src/Magnum/Platform/Sdl2Application.cpp

4
src/Magnum/Platform/EmscriptenApplication.cpp

@ -220,6 +220,10 @@ EmscriptenApplication::EmscriptenApplication(const Arguments& arguments, NoCreat
{
Utility::Arguments args{Implementation::windowScalingArguments()};
#ifdef MAGNUM_TARGET_GL
/** @todo this means GL::Context is constructed even with Contextless
present, do we actually want that at all? It's just for argument
parsing (which affect GL context creation), so maybe separate that from
the GL::Context somehow? Chicken and egg... */
_context.emplace(NoCreate, args, arguments.argc, arguments.argv);
#else
/** @todo this is duplicated here, in Sdl2Application and in

4
src/Magnum/Platform/GlfwApplication.cpp

@ -85,6 +85,10 @@ GlfwApplication::GlfwApplication(const Arguments& arguments, NoCreateT):
{
Utility::Arguments args{Implementation::windowScalingArguments()};
#ifdef MAGNUM_TARGET_GL
/** @todo this means GL::Context is constructed even with Contextless
present, do we actually want that at all? It's just for argument
parsing (which affect GL context creation), so maybe separate that from
the GL::Context somehow? Chicken and egg... */
_context.emplace(NoCreate, args, arguments.argc, arguments.argv);
#else
/** @todo this is duplicated here, in Sdl2Application and in

4
src/Magnum/Platform/Sdl2Application.cpp

@ -166,6 +166,10 @@ Sdl2Application::Sdl2Application(const Arguments& arguments, NoCreateT):
{
Utility::Arguments args{Implementation::windowScalingArguments()};
#ifdef MAGNUM_TARGET_GL
/** @todo this means GL::Context is constructed even with Contextless
present, do we actually want that at all? It's just for argument
parsing (which affect GL context creation), so maybe separate that from
the GL::Context somehow? Chicken and egg... */
_context.emplace(NoCreate, args, arguments.argc, arguments.argv);
#else
/** @todo this is duplicated here, in GlfwApplication and in

Loading…
Cancel
Save