Browse Source

SceneGraph: use `virtual` where it hurts less.

Having `virtual` destructor in less templated base is better than having
it repeated in five times more subclass specializations.
pull/278/head
Vladimír Vondruš 13 years ago
parent
commit
b8b6b63919
  1. 4
      src/SceneGraph/FeatureGroup.h

4
src/SceneGraph/FeatureGroup.h

@ -50,7 +50,7 @@ class MAGNUM_SCENEGRAPH_EXPORT AbstractFeatureGroup {
template<UnsignedInt, class, class> friend class FeatureGroup; template<UnsignedInt, class, class> friend class FeatureGroup;
explicit AbstractFeatureGroup(); explicit AbstractFeatureGroup();
~AbstractFeatureGroup(); virtual ~AbstractFeatureGroup();
void add(AbstractFeature<dimensions, T>* feature); void add(AbstractFeature<dimensions, T>* feature);
void remove(AbstractFeature<dimensions, T>* feature); void remove(AbstractFeature<dimensions, T>* feature);
@ -80,7 +80,7 @@ class FeatureGroup: public AbstractFeatureGroup<dimensions, T> {
* *
* Removes all features belonging to this group, but not deletes them. * Removes all features belonging to this group, but not deletes them.
*/ */
virtual ~FeatureGroup(); ~FeatureGroup();
/** @brief Whether the group is empty */ /** @brief Whether the group is empty */
bool isEmpty() const { return this->features.empty(); } bool isEmpty() const { return this->features.empty(); }

Loading…
Cancel
Save