magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	c2ecaa6abf	GL: AbstractShaderProgram::draw() that takes plain array views. Because a MeshView might not be the best thing to have when you are submitting a batch of thousand draws. It takes a strided array views to allow for more flexibility, but can also detect if the input is already contiguous and use it as-is. UNFORTUNATELY the GL 1.0 legacy still continues to stink and so there has to be a 64-bit-specific overload which is the actual variant that doesn't allocate because glMultiDrawElements takes a `void**` for INDEX OFFSETS and it's IN BYTES! Which foolish soul designed such a thing back in the 1860s, I wonder. There's no reason to not have an index offset in elements because all indices have to have the same type ANYWAY. And yes, I wasted about three hours debugging driver crashes because I THOUGHT this parameter takes offset in elements, not bytes. Also note: on 32-bit platforms this depends on latest Corrade with the CORRADE_TARGET_32BIT definition. Spent an embarrassing amount of time wondering why all local builds but Emscripten work.	5 years ago
Vladimír Vondruš	ae0aa306c6	GL: clarify an assert. "Cannot draw multiple instanced meshes." is no better than "SOMETHING WENT WRONG PLEASE SHRED YOUR APPLE DEVICE."	5 years ago
Vladimír Vondruš	d8c6a7d690	GL: the multi-draw test for Mesh was underwhelming, to say the least. Or, the horror when I comment-out half of it and it still kinda passes. The new code tests it more thoroughly, with actually checking that different draw produce different results instead of one draw overwriting the other. Plus also verifying interaction with gl_VertexID and gl_DrawID to ensure it really behaves correctly: - gl_VertexID should get the same value regardless of whether we perform a multi-draw or a one-by-one fallback, so this catches issues where the mesh would get reconfigured in some nasty way, losing this information - gl_DrawID should get properly populated if and only if we use the multi-draw code path, so this catches issues where the fallback would get used instead of the actual multi-draw code path	5 years ago
Vladimír Vondruš	dc5fdd7cb5	GL: fix a confusing typo in a comment.	5 years ago
Vladimír Vondruš	d44514b60f	GL: properly skip a test on a no-assert build.	5 years ago
Vladimír Vondruš	2f24199ed7	GL: improve message for the common mesh assert in multi-draw. In my case I was using a dangling MeshView reference there, and it was hard to debug without these.	5 years ago
Vladimír Vondruš	65a935cedc	Test: adapt to changes in CORRADE_SKIP(). Chose to update the tests instead of adding a compatibility DebugStl.h include to Tester.h, which would have a significant impact on compile times.	5 years ago
Vladimír Vondruš	ffdebff048	GL: implement the base instance and base vertex ES and WebGL extensions. AAAAAAAAAAAAAAAAAAAAAAAAAAAAA this was terrible! Why the hell it needs to have so many variants, special cases and exceptions!!!	5 years ago
Vladimír Vondruš	63f55a37b1	GL: implement ANGLE_multi_draw and WEBGL_multi_draw support.	5 years ago
Vladimír Vondruš	3d136503d8	Updated copyright year.	5 years ago
Vladimír Vondruš	e8f13af4be	GL: test noexcept-movability of all GL classes. Not sure why this wasn't done for ages already, all other (non-GL) classes have it.	6 years ago
Vladimír Vondruš	d0fa28c331	Use the new half/packed typedefs where appropriate. Had this in a stash for a while, not sure why it wasn't commited already.	6 years ago
Vladimír Vondruš	19e0e96d74	Updated copyright year.	6 years ago
Vladimír Vondruš	65a2ced2a7	Make this compile and test cleanly with CORRADE_NO_ASSERT defined.	6 years ago
Vladimír Vondruš	d3f2235759	Adapted to Corrade changes.	6 years ago
Vladimír Vondruš	e983a2a168	GL: make it possible to describe matrix attributes with DynamicAttribute. Not sure why this wasn't done when originally implementing those.	6 years ago
Vladimír Vondruš	b7da1323c8	Minor cleanup.	6 years ago
Vladimír Vondruš	de9c289328	Adapted all code and doc snippets to GL library changes.	6 years ago
Vladimír Vondruš	946c3cdac9	GL: rename PixelType::HalfFloat and Attribute::DataType::HalfFloat to Half. For consistency with the Half type we use elsewhere. The old enums are still available, but deprecated and scheduled for removal.	6 years ago
Vladimír Vondruš	f2ba5602a4	GL: Intel Windows drivers 26 are less shitty w/ double attributes.	7 years ago
Vladimír Vondruš	3d5f50ac49	Test: use the new setTestCaseTemplateName().	7 years ago
Vladimír Vondruš	6144a73c8e	GL: avoid using deprecated templated Image::data() in tests. This discovered quite a few potentially dangerous casts, so yay!	7 years ago
Vladimír Vondruš	b77651cf93	GL: remove Buffer::set[Sub]Data() taking std::array / std::vector. Instead make use of the ArrayView STL compatibility. To avoid breaking almost all existing code the Corrade/Containers/ArrayViewStl.h header is included implicitly when MAGNUM_BUILD_DEPRECATED is defined, but this will get removed in some future release to speed up the compilation.	7 years ago
Vladimír Vondruš	3626562e1d	Adapted to Corrade changes. Mostly missing includes now.	7 years ago
Vladimír Vondruš	d008d59c79	GL: fix MeshGLTest::bindScratchVaoWhenEnteringExternalSection(). Would fail on an incomplete framebuffer error on framebuffer-less windowless contexts. Didn't happen before, I think it's because of a new check in a new Mesa.	7 years ago
Vladimír Vondruš	fa62122c98	GL: add XFAIL to some well-known failures with Intel Windows drivers.	7 years ago
Vladimír Vondruš	572b64bb5c	GL: drop support for EXT_direct_state_access.	7 years ago
Vladimír Vondruš	579d7b489f	GL: use proper literals in a test.	7 years ago
Vladimír Vondruš	d8a2e70617	GL: XFAIL on SwiftShader with integer data type mismatches. Accepted everywhere else (or so is my experience).	7 years ago
Vladimír Vondruš	fdac0a7150	GL: expect less precision on ES2 tests that use RGBA4 renderbuffers.	7 years ago
Vladimír Vondruš	c9937f73a0	GL: disable indexed Mesh tests on drivers w/o indexed extensions.	7 years ago
Vladimír Vondruš	f5e9ba7e8a	GL: wait, there's not just three ES instanced extensions, there's FIVE. Like, why can't they just depend on each other or something?	7 years ago
Vladimír Vondruš	ee16c25125	GL: further harden VAO and index buffer binding state interaction tests. This one crashes. Turns out the `169031fb7b` contained a random temporary test state instead of the real solution (and so the comment didn't even match the code, it should have been resetting that to 0). That also made some tests fail with DSA disabled, but none of the tests were actual Mesh tests, just accidentally hitting the problematic code path. I took the opportunity to look at this more closely and investigate why this failed -- turns out, in setIndexBuffer(), I was resetting the state tracker to a VAO state that was about to be set in the very next step, and then, when doing that next step the state tracker "optimized away" the state change because it thought it was already done (even though it wasn't). The new test in MeshGLTest covers this particular case.	7 years ago
Vladimír Vondruš	df463d5452	GL: test yet another interaction of VAOs and index buffer binding. Fails (well, why else would I be adding the test, right?).	7 years ago
Vladimír Vondruš	6ee6898c31	GL: properly execute these tests on WebGL 1 as well.	7 years ago
Vladimír Vondruš	2149f7b869	Wrap all tests in unnamed namespaces. This makes the compiler warn about test cases that aren't ever used, which is a good thing.	7 years ago
Vladimír Vondruš	e6b7aa12fa	Updated copyright year.	7 years ago
Vladimír Vondruš	543c9cf7ed	GL: don't use old GLSL names in ES3 Mesh tests.	8 years ago
Vladimír Vondruš	3e6ab765b6	GL: properly name the test case.	8 years ago
Vladimír Vondruš	670d532566	GL: fix various OOB / unaligned access issues in Mesh test.	8 years ago
Vladimír Vondruš	816869fc88	GL: properly specify Buffer target hints for tests on WebGL.	8 years ago
Vladimír Vondruš	dd343fe35b	GL: make it possible to bind a scratch VAO for external GL code. Used in those sad and unfortunate cases where we need to call shitty external GL code that's not VAO-aware.	8 years ago
Vladimír Vondruš	36461ce7ea	GL: clean up rendundant ifdefs.	8 years ago
Vladimír Vondruš	b4c52b096d	GL: don't try to test mesh labels if VAOs are disabled.	8 years ago
Vladimír Vondruš	6465fa14c9	GL: fix undefined behavior and potential leaks in Mesh. The change done in `680144f1c5` was not properly handling these cases: * Mesh(NoCreateT) and wrap() were not constructing the internal vector, which blew up when move-assigning another instance. * ~Mesh() was not destructing the internal vector if the VAO ID was zero or non-owning wrap() was used. Strangely enough none of these were causing any problems for me on Linux (even ASan was totally quiet and due to the unfortunate combination of bugs even when I assigned totally random data to the storage vector). This however blew up on MSVC, assuming there the implementation is more checked. Because it's possible to construct Mesh with no GL context available, the move construction and destruction needs to avoid accessing Context unless really necessary (it would be also unclear which type of vector should be constructed if we have no context). Extended the tests to handle hopefully all the cases.	8 years ago
Vladimír Vondruš	f47d591244	GL: move noncopyability tests to non-GL test executables.	8 years ago
Vladimír Vondruš	d3a91ef22d	GL: test that vertex attrib divisor is properly reset when not using VAOs. Fails, because it's not. Fix in next commit.	8 years ago
Vladimír Vondruš	b2ec555a84	GL: ANGLE_instanced_arrays is on WebGL 1, so test it.	8 years ago
Vladimír Vondruš	9be24a241e	GL: make it possible for a Mesh to own the vertex/index buffers. I wanted to do this since 2015.	8 years ago
Vladimír Vondruš	16558c8877	GL: assert that addVertexBuffer() is called with a valid Buffer.	8 years ago

1 2

55 Commits (1ee1f23f77ad7d54f7b440453bec38e21ef3edb2)