Browse Source

Minor comment changes in the process files.

merge-requests/365/head
eidheim 10 years ago
parent
commit
2b953d6d03
  1. 4
      src/process.hpp
  2. 2
      src/process_win.cpp

4
src/process.hpp

@ -14,8 +14,8 @@
#endif #endif
///Create a new process given command and run path. ///Create a new process given command and run path.
///Note: on Windows it seems impossible to specify which pipes to use. ///TODO: on Windows it is harder to specify which pipes to redirect.
///Thus, if read_stdout==nullptr, read_stderr==nullptr and open_stdin==false, ///Thus, at the moment, if read_stdout==nullptr, read_stderr==nullptr and open_stdin==false,
///the stdout, stderr and stdin are sent to the parent process instead. ///the stdout, stderr and stdin are sent to the parent process instead.
///Compile with -DMSYS_PROCESS_USE_SH to run command using "sh -c [command]" on Windows as well. ///Compile with -DMSYS_PROCESS_USE_SH to run command using "sh -c [command]" on Windows as well.
class Process { class Process {

2
src/process_win.cpp

@ -8,8 +8,6 @@ using namespace std; //TODO: remove
Process::Data::Data(): id(0), handle(NULL) {} Process::Data::Data(): id(0), handle(NULL) {}
//Based on the example at https://msdn.microsoft.com/en-us/library/windows/desktop/ms682499(v=vs.85).aspx. //Based on the example at https://msdn.microsoft.com/en-us/library/windows/desktop/ms682499(v=vs.85).aspx.
//Note: on Windows it seems impossible to specify which pipes to use.
//Thus, if read_stdout==nullptr, read_stderr==nullptr and open_stdin==false, the stdout, stderr and stdin are sent to the parent process instead.
Process::id_type Process::open(const std::string &command, const std::string &path) { Process::id_type Process::open(const std::string &command, const std::string &path) {
if(open_stdin) if(open_stdin)
stdin_fd=std::unique_ptr<fd_type>(new fd_type); stdin_fd=std::unique_ptr<fd_type>(new fd_type);

Loading…
Cancel
Save